downgrade bootstrap `cc` by onur-ozkan · Pull Request #137460 · rust-lang/rust

onur-ozkan · 2025-02-23T05:29:08Z

Current cc version causing bootstrap to fail on custom targets. See rust-lang/cc-rs#1317 for more context.

Fixes (after beta and stable backports): #137064 and #135271

Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot · 2025-02-23T05:29:17Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-02-23T08:42:14Z

Yeah, this is a reasonable mitigation in the meantime. Thanks!

@bors r+

bors · 2025-02-23T08:42:17Z

📌 Commit e4ca11f has been approved by jieyouxu

It is now in the queue for this repository.

stefson · 2025-02-23T08:46:37Z

If this sticks, it will be super helpfull if you backport this further into beta and stable.

onur-ozkan · 2025-02-23T11:59:31Z

If this sticks, it will be super helpfull if you backport this further into beta and stable.

That's the plan, yeah.

jieyouxu · 2025-02-23T14:04:04Z

I modified the PR description to not have this PR auto-close the linked issues, since they won't be fixed on stable/beta without corresponding backports landing.

onur-ozkan · 2025-02-24T04:49:12Z

@rustbot label +stable-accepted +beta-accepted

See the team decision.

downgrade bootstrap `cc` Current `cc` version causing bootstrap to fail on custom targets. See rust-lang/cc-rs#1317 for more context. Fixes (after beta and stable backports): rust-lang#137064 and rust-lang#135271

Rollup of 6 pull requests Successful merges: - rust-lang#135480 (Don't require method impls for methods with `Self:Sized` bounds for impls for unsized types) - rust-lang#137360 (Use `as_chunks` in `analyze_source_file_sse2`) - rust-lang#137460 (downgrade bootstrap `cc`) - rust-lang#137515 (Update `compiler-builtins` to 0.1.148) - rust-lang#137522 (use stage 2 on cargo and clippy tests when possible) - rust-lang#137597 (Revert accidental cargo submodule update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137460 - onur-ozkan:downgrade-cc, r=jieyouxu downgrade bootstrap `cc` Current `cc` version causing bootstrap to fail on custom targets. See rust-lang/cc-rs#1317 for more context. Fixes (after beta and stable backports): rust-lang#137064 and rust-lang#135271

[beta] backports - Pass vendored sources from bootstrap to generate-copyright rust-lang#137020 - Fix `-win7-windows-msvc` target since 26eeac1* rust-lang#137270 - skip submodule updating logics on tarballs rust-lang#137338 - Improve behavior of `IF_LET_RESCOPE` around temporaries and place expressions rust-lang#137444 - downgrade bootstrap `cc` rust-lang#137460 - Remove latest Windows SDK from 32-bit CI rust-lang#137753 - [beta-1.86] Ensure we can package directories ending with '.rs' (rust-lang/cargo#15248) rust-lang#137842 r? cuviper

[stable] Release 1.85.1 - [Fix the doctest-merging feature of the 2024 Edition.](rust-lang#137899) - [Relax some `target_feature` checks when generating docs.](rust-lang#137632) - DRAFT NOTE: this is not formally `stable-accepted` yet. It also required some fixup to deal with differences in the `Stability` system, but I think it should have the same effect, limited to `rustdoc` execution. - [Fix errors in `fs::rename` on Windows 1607.](rust-lang#137528) - [Downgrade bootstrap `cc` to fix custom targets.](rust-lang#137460) - [Skip submodule updates when building Rust from a source tarball.](rust-lang#137338) cc `@rust-lang/release` r? cuviper try-job: dist-x86_64-linux try-job: dist-i686-msvc try-job: x86_64-rust-for-linux

[stable] Release 1.85.1 - [Fix the doctest-merging feature of the 2024 Edition.](rust-lang#137899) - [Relax some `target_feature` checks when generating docs.](rust-lang#137632) - DRAFT NOTE: this is not formally `stable-accepted` yet. It also required some fixup to deal with differences in the `Stability` system, but I think it should have the same effect, limited to `rustdoc` execution. - [Fix errors in `fs::rename` on Windows 1607.](rust-lang#137528) - [Downgrade bootstrap `cc` to fix custom targets.](rust-lang#137460) - [Skip submodule updates when building Rust from a source tarball.](rust-lang#137338) cc `@rust-lang/release` r? cuviper try-job: dist-x86_64-linux try-job: dist-i686-msvc try-job: i686-msvc try-job: x86_64-rust-for-linux

[stable] Release 1.85.1 - [Fix the doctest-merging feature of the 2024 Edition.](rust-lang#137899) - [Relax some `target_feature` checks when generating docs.](rust-lang#137632) - [Fix errors in `std::fs::rename` on Windows 1607.](rust-lang#137528) - [Downgrade bootstrap `cc` to fix custom targets.](rust-lang#137460) - [Skip submodule updates when building Rust from a source tarball.](rust-lang#137338) Added backports to fix CI: - Remove latest Windows SDK from 32-bit CI rust-lang#137753 - Do not install rustup on Rust for Linux job rust-lang#137947 cc `@rust-lang/release` r? cuviper

…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) for exact details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various

Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) for exact details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various

…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) for exact details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various

…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the `cc-rs` changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) and [the `cmake-rs` changelog](https://github.com/rust-lang/cmake-rs/blob/fd56c5a6b4ecda8815c863eb5b12d7b3f0391197/CHANGELOG.md) for details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various

…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the `cc-rs` changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) and [the `cmake-rs` changelog](https://github.com/rust-lang/cmake-rs/blob/fd56c5a6b4ecda8815c863eb5b12d7b3f0391197/CHANGELOG.md) for details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: *apple*

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [rust](https://github.com/rust-lang/rust) | patch | `1.85.0` -> `1.85.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.85.1`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1851-2025-03-18) [Compare Source](rust-lang/rust@1.85.0...1.85.1) \========================== <a id="1.85.1"></a> - [Fix the doctest-merging feature of the 2024 Edition.](rust-lang/rust#137899) - [Relax some `target_feature` checks when generating docs.](rust-lang/rust#137632) - [Fix errors in `std::fs::rename` on Windows 10, version 1607.](rust-lang/rust#137528) - [Downgrade bootstrap `cc` to fix custom targets.](rust-lang/rust#137460) - [Skip submodule updates when building Rust from a source tarball.](rust-lang/rust#137338) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

https://build.opensuse.org/request/show/1255785 by user xiaoguang_wang + anag+factory Version 1.85.1 (2025-03-18) ========================== - [Fix the doctest-merging feature of the 2024 Edition.](rust-lang/rust#137899) - [Relax some `target_feature` checks when generating docs.](rust-lang/rust#137632) - [Fix errors in `std::fs::rename` on Windows 10, version 1607.](rust-lang/rust#137528) - [Downgrade bootstrap `cc` to fix custom targets.](rust-lang/rust#137460) - [Skip submodule updates when building Rust from a source tarball.](rust-lang/rust#137338)

…ieyouxu Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the `cc-rs` changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) and [the `cmake-rs` changelog](https://github.com/rust-lang/cmake-rs/blob/fd56c5a6b4ecda8815c863eb5b12d7b3f0391197/CHANGELOG.md) for details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: *apple*

Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang/rust#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the `cc-rs` changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) and [the `cmake-rs` changelog](https://github.com/rust-lang/cmake-rs/blob/fd56c5a6b4ecda8815c863eb5b12d7b3f0391197/CHANGELOG.md) for details on what has changed here. r? jieyouxu who tried this last in rust-lang/rust#137022. `@rustbot` label T-bootstrap try-job: *apple*

downgrade bootstrap cc

e4ca11f

Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot assigned jieyouxu Feb 23, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 23, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025

jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Feb 23, 2025

rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Feb 24, 2025

ognevny mentioned this pull request Feb 24, 2025

rust: update to 1.85.0 msys2/MINGW-packages#23426

Merged

This was referenced Feb 25, 2025

Rollup of 7 pull requests #137607

Closed

Rollup of 6 pull requests #137611

Merged

bors merged commit 849a60a into rust-lang:master Feb 25, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Feb 25, 2025

onur-ozkan deleted the downgrade-cc branch February 25, 2025 21:59

cuviper mentioned this pull request Feb 27, 2025

[beta] backports #137747

Merged

cuviper modified the milestones: 1.87.0, 1.86.0 Feb 27, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 27, 2025

madsmtm mentioned this pull request Feb 28, 2025

Parse rustc target names rust-lang/cc-rs#1413

Merged

jieyouxu mentioned this pull request Mar 12, 2025

feat: add succinct-zkvm target #138433

Closed

bjorn3 mentioned this pull request Mar 13, 2025

Error building libstd: with_hasher cannot be (indirectly) exposed to stable #133857

Closed

cuviper mentioned this pull request Mar 14, 2025

[stable] Release 1.85.1 #138521

Merged

cuviper removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Mar 15, 2025

cuviper modified the milestones: 1.86.0, 1.85.1 Mar 15, 2025

madsmtm mentioned this pull request Mar 21, 2025

Bump boostrap cc to 1.2.17 and cmake to 0.1.54 #138784

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

downgrade bootstrap `cc`#137460

downgrade bootstrap `cc`#137460
bors merged 1 commit intorust-lang:masterfrom
onur-ozkan:downgrade-cc

onur-ozkan commented Feb 23, 2025 •

edited by jieyouxu

Loading

Uh oh!

rustbot commented Feb 23, 2025

Uh oh!

jieyouxu commented Feb 23, 2025

Uh oh!

bors commented Feb 23, 2025

Uh oh!

stefson commented Feb 23, 2025

Uh oh!

onur-ozkan commented Feb 23, 2025

Uh oh!

jieyouxu commented Feb 23, 2025

Uh oh!

onur-ozkan commented Feb 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

onur-ozkan commented Feb 23, 2025 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 23, 2025

Uh oh!

jieyouxu commented Feb 23, 2025

Uh oh!

bors commented Feb 23, 2025

Uh oh!

stefson commented Feb 23, 2025

Uh oh!

onur-ozkan commented Feb 23, 2025

Uh oh!

jieyouxu commented Feb 23, 2025

Uh oh!

onur-ozkan commented Feb 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

onur-ozkan commented Feb 23, 2025 •

edited by jieyouxu

Loading