ports the compiler test cases to new rust_intrinsic format by aaishwarymishra · Pull Request #138364 · rust-lang/rust

aaishwarymishra · 2025-03-11T17:36:37Z

pr is part of #132735

rustbot · 2025-03-11T17:36:42Z

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

aaishwarymishra · 2025-03-11T17:38:38Z

@RalfJung I ran test rustc_error_codes and the test passed on my local machine.

RalfJung · 2025-03-11T17:48:30Z

First of all, please pick a PR title ~~and description~~ that actually says something about what the PR does. :)

compiler/rustc_error_codes/src/error_codes/E0092.md

compiler/rustc_error_codes/src/error_codes/E0093.md

compiler/rustc_error_codes/src/error_codes/E0511.md

aaishwarymishra · 2025-03-11T21:10:07Z

Should we bless the test?

RalfJung · 2025-03-12T06:49:21Z

You'll need to provide a definition for the static, as the error says.

RalfJung · 2025-03-12T06:49:58Z

compiler/rustc_error_codes/src/error_codes/E0511.md

-    fn simd_add<T>(a: T, b: T) -> T;
-}
+#[rustc_intrinsic]
+unsafe fn simd_add<T>(_a: T, _b: T) -> T;


Please remove the leading _ again (everywhere in this PR)

RalfJung · 2025-03-12T17:51:35Z

compiler/rustc_error_codes/src/error_codes/E0622.md

-    // error: intrinsic must be a function
-}
+#[rustc_intrinsic]
+pub static atomic_singlethreadfence_seqcst: fn() = || {};


Suggested change

pub static atomic_singlethreadfence_seqcst: fn() = || {};

#[allow(non_upper_case_globals)]

pub static atomic_singlethreadfence_seqcst: fn() = || {};

I think the problem is pub static atomic_singlethreadfence_seqcst: fn() = || {}; as the atomic_singlethreadfence_seqcst being declared as a static fn declared as an empty closer making the test cases pass which should have been failed .

It should be pub static atomic_singlethreadfence_seqcst: fn() ; but it gives the error "provide a definition for the static" instead of the expected one

It seems there is a bug somewhere, and we are not complaining when #[rustc_intrinsic] is used on a non-function (and then likely being ignored).

@oli-obk is that deliberate? Any suggestion for what to do with this old test?

it's a rustc attribute, it's fine to just not work on things and/or ICE. ICEing is better, but there is no requirement for it.

Okay so the error code E0622 should just be removed then when we remove the ABI.

@BLANKatGITHUB just leave E0622.md unchanged in this PR.

RalfJung · 2025-03-13T14:18:58Z

@rustbot author
There are still CI failures.

Update compiler/rustc_error_codes/src/error_codes/E0622.md Co-authored-by: Ralf Jung <post@ralfj.de> reverted chages on E0622.md updated E0622.md

RalfJung · 2025-03-18T18:04:37Z

Thanks, LGTM!

@bors r+ rollup

bors · 2025-03-18T18:04:40Z

📌 Commit a3669b8 has been approved by RalfJung

It is now in the queue for this repository.

bors · 2025-03-18T18:04:41Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

ports the compiler test cases to new rust_intrinsic format pr is part of rust-lang#132735

Rollup of 15 pull requests Successful merges: - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) - rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format) - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138435 (Add support for postfix yield expressions) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt) - rust-lang#138650 (Optimize `io::Write::write_fmt` for constant strings) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138685 (Use `Option<Ident>` for lowered param names.) - rust-lang#138694 (Fix: add ohos target notes) - rust-lang#138700 (Suggest `-Whelp` when pass `--print lints` to rustc) - rust-lang#138709 (Update GCC submodule) - rust-lang#138724 (Check attrs: Don't try to retrieve the name of list stems) - rust-lang#138731 (coverage: Add LLVM plumbing for expansion regions) - rust-lang#138732 (Use `def_path_str` for def id arg in `UnsupportedOpInfo`) r? `@ghost` `@rustbot` modify labels: rollup

ports the compiler test cases to new rust_intrinsic format pr is part of rust-lang#132735

Rollup of 10 pull requests Successful merges: - rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format) - rust-lang#138570 (add `naked_functions_target_feature` unstable feature) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt) - rust-lang#138627 (Autodiff cleanups) - rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled) - rust-lang#138706 (Improve bootstrap git modified path handling) - rust-lang#138709 (Update GCC submodule) - rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it) - rust-lang#138721 (Use explicit cpu in some asm and codegen tests.) - rust-lang#138728 (Update `compiler-builtins` to 0.1.152) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format) - rust-lang#138570 (add `naked_functions_target_feature` unstable feature) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt) - rust-lang#138627 (Autodiff cleanups) - rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled) - rust-lang#138706 (Improve bootstrap git modified path handling) - rust-lang#138709 (Update GCC submodule) - rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it) - rust-lang#138721 (Use explicit cpu in some asm and codegen tests.) - rust-lang#138728 (Update `compiler-builtins` to 0.1.152) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl

ports the compiler test cases to new rust_intrinsic format pr is part of rust-lang#132735

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format) - rust-lang#138570 (add `naked_functions_target_feature` unstable feature) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt) - rust-lang#138627 (Autodiff cleanups) - rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled) - rust-lang#138706 (Improve bootstrap git modified path handling) - rust-lang#138709 (Update GCC submodule) - rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it) - rust-lang#138721 (Use explicit cpu in some asm and codegen tests.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138364 - BLANKatGITHUB:compiler, r=RalfJung ports the compiler test cases to new rust_intrinsic format pr is part of rust-lang#132735

rustbot assigned BoxyUwU Mar 11, 2025

This comment has been minimized.

Sign in to view

RalfJung reviewed Mar 11, 2025

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0092.md Outdated Show resolved Hide resolved

RalfJung reviewed Mar 11, 2025

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0093.md Show resolved Hide resolved

aaishwarymishra marked this pull request as draft March 11, 2025 17:51

aaishwarymishra changed the title ~~Compiler~~ ports the compiler test cases to new rust_intrinsic format Mar 11, 2025

aaishwarymishra commented Mar 11, 2025

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0511.md Show resolved Hide resolved

This comment has been minimized.

Sign in to view

RalfJung reviewed Mar 12, 2025

View reviewed changes

RalfJung removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2025

aaishwarymishra marked this pull request as ready for review March 12, 2025 11:27

aaishwarymishra force-pushed the compiler branch from 5627a78 to 8600a0d Compare March 12, 2025 11:30

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2025

This comment has been minimized.

Sign in to view

RalfJung reviewed Mar 12, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 13, 2025

aaishwarymishra force-pushed the compiler branch from f7c2eca to a18a278 Compare March 18, 2025 16:18

updated compiler tests for rustc_intrinsic'

a3669b8

Update compiler/rustc_error_codes/src/error_codes/E0622.md Co-authored-by: Ralf Jung <post@ralfj.de> reverted chages on E0622.md updated E0622.md

aaishwarymishra force-pushed the compiler branch from a18a278 to a3669b8 Compare March 18, 2025 16:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 20, 2025

Rollup merge of rust-lang#138364 - BLANKatGITHUB:compiler, r=RalfJung

2a9480d

ports the compiler test cases to new rust_intrinsic format pr is part of rust-lang#132735

jieyouxu mentioned this pull request Mar 20, 2025

Rollup of 15 pull requests #138733

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2025

Rollup merge of rust-lang#138364 - BLANKatGITHUB:compiler, r=RalfJung

7e624c5

ports the compiler test cases to new rust_intrinsic format pr is part of rust-lang#132735

matthiaskrgr mentioned this pull request Mar 21, 2025

Rollup of 10 pull requests #138771

Closed

matthiaskrgr mentioned this pull request Mar 21, 2025

Rollup of 9 pull requests #138791

Merged

Kobzol added a commit to Kobzol/rust that referenced this pull request Mar 21, 2025

Rollup merge of rust-lang#138364 - BLANKatGITHUB:compiler, r=RalfJung

0ea049b

ports the compiler test cases to new rust_intrinsic format pr is part of rust-lang#132735

Kobzol mentioned this pull request Mar 21, 2025

Rollup of 10 pull requests #138792

Closed

bors merged commit f7f2870 into rust-lang:master Mar 21, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 21, 2025

BoxyUwU assigned RalfJung and unassigned BoxyUwU Apr 1, 2025

	pub static atomic_singlethreadfence_seqcst: fn() = \|\| {};
	#[allow(non_upper_case_globals)]
	pub static atomic_singlethreadfence_seqcst: fn() = \|\| {};

Uh oh!

Conversation

aaishwarymishra commented Mar 11, 2025

Uh oh!

rustbot commented Mar 11, 2025

Uh oh!

This comment has been minimized.

aaishwarymishra commented Mar 11, 2025

Uh oh!

RalfJung commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

aaishwarymishra commented Mar 11, 2025

Uh oh!

RalfJung commented Mar 12, 2025

Uh oh!

RalfJung Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

RalfJung Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

aaishwarymishra Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Mar 16, 2025

Choose a reason for hiding this comment

Uh oh!

oli-obk Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

RalfJung commented Mar 13, 2025

Uh oh!

RalfJung commented Mar 18, 2025

Uh oh!

bors commented Mar 18, 2025

Uh oh!

bors commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RalfJung commented Mar 11, 2025 •

edited

Loading