Avoid sending a non-null pointer for empty strings

[oli-obk]

Another try at fixing the perf regression from #138674

r? @ghost

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 6f92951 with merge 7d28bf1...

[bors]

☀️ Try build successful - checks-actions
Build commit: 7d28bf1 (7d28bf18a3202b09bfdd6b42b3602853e2d3e114)

[rust-timer]

Finished benchmarking commit (7d28bf1): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.9%, secondary 3.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.966s -> 775.263s (0.04%)
Artifact size: 365.53 MiB -> 365.52 MiB (-0.00%)

[oli-obk]

Nope, not it either. Time to bisect