bootstrap: Avoid cloning `change-id` list by thaliaarchi · Pull Request #139044 · rust-lang/rust

thaliaarchi · 2025-03-28T05:50:02Z

Inspired by recent discussion on the bootstrap change-id field, I took a look at the code and found this little optimization. It does not change behavior.

rustbot · 2025-03-28T05:50:06Z

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

onur-ozkan

Seems like a good improvement!

Waiting for the CI to turn green.

onur-ozkan · 2025-03-28T06:43:44Z

There is a linting error.

@rustbot author

onur-ozkan · 2025-03-28T07:36:21Z

@bors r+

bors · 2025-03-28T07:36:24Z

📌 Commit ad29f94 has been approved by onur-ozkan

It is now in the queue for this repository.

Kobzol · 2025-03-28T07:54:47Z

@bors rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#137889 (update outdated doc with new example) - rust-lang#138104 (Greatly simplify doctest parsing and information extraction) - rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents) - rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings) - rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name) - rust-lang#139045 (bootstrap: update `test_find` test) - rust-lang#139047 (Remove ScopeDepth) Failed merges: - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#138976 (Explain one-past-the-end pointer in std library) - rust-lang#139052 (Put pin!() tests in the right file.) - rust-lang#139058 (Fix formatting nit in process.rs) - rust-lang#139063 (Fix TAIT & ATPIT feature gating in the presence of anon consts) - rust-lang#139065 (Miri subtree update) - rust-lang#139069 (`io::Take`: avoid new `BorrowedBuf` creation in some case) - rust-lang#139075 (Do not treat lifetimes from parent items as influencing child items) - rust-lang#139079 (tracking autodiff files via triagebot.toml) Failed merges: - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-03-28T21:27:48Z

☔ The latest upstream changes (presumably #139054) made this pull request unmergeable. Please resolve the merge conflicts.

thaliaarchi · 2025-03-28T21:47:38Z

So it did conflict with #138986. Rebased.

Kobzol · 2025-03-28T21:52:08Z

@bors r=onur-ozkan

bors · 2025-03-28T21:52:10Z

📌 Commit fbe5e55 has been approved by onur-ozkan

It is now in the queue for this repository.

…one, r=onur-ozkan bootstrap: Avoid cloning `change-id` list Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.

Rollup of 8 pull requests Successful merges: - rust-lang#138692 (Reject `{true,false}` as revision names) - rust-lang#138757 (wasm: increase default thread stack size to 1 MB) - rust-lang#138832 (Start using `with_native_path` in `std::sys::fs`) - rust-lang#138988 (Change the syntax of the internal `weak!` macro) - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) - rust-lang#139056 (use `try_fold` instead of `fold`) - rust-lang#139057 (use `slice::contains` where applicable) - rust-lang#139086 (Various cleanup in ExprUseVisitor) r? `@ghost` `@rustbot` modify labels: rollup

…one, r=onur-ozkan bootstrap: Avoid cloning `change-id` list Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.

Rollup of 7 pull requests Successful merges: - rust-lang#138692 (Reject `{true,false}` as revision names) - rust-lang#138757 (wasm: increase default thread stack size to 1 MB) - rust-lang#138988 (Change the syntax of the internal `weak!` macro) - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) - rust-lang#139056 (use `try_fold` instead of `fold`) - rust-lang#139057 (use `slice::contains` where applicable) - rust-lang#139086 (Various cleanup in ExprUseVisitor) r? `@ghost` `@rustbot` modify labels: rollup

…one, r=onur-ozkan bootstrap: Avoid cloning `change-id` list Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.

Rollup of 5 pull requests Successful merges: - rust-lang#137836 (Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl`) - rust-lang#138206 ([AIX] Ignore linting on repr(C) structs with repr(packed) or repr(align(n))) - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) - rust-lang#139092 (Move `fd` into `std::sys`) - rust-lang#139111 (Properly document FakeReads) r? `@ghost` `@rustbot` modify labels: rollup

…one, r=onur-ozkan bootstrap: Avoid cloning `change-id` list Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.

Rollup of 6 pull requests Successful merges: - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) - rust-lang#139111 (Properly document FakeReads) - rust-lang#139113 (unstable book: in a sanitizer example, check the code) - rust-lang#139122 (Remove attribute `#[rustc_error]`) - rust-lang#139132 (Improve hir_pretty for struct expressions.) - rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 5 pull requests Successful merges: - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) - rust-lang#139111 (Properly document FakeReads) - rust-lang#139122 (Remove attribute `#[rustc_error]`) - rust-lang#139132 (Improve hir_pretty for struct expressions.) - rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#139044 - thaliaarchi:bootstrap-change-id-clone, r=onur-ozkan bootstrap: Avoid cloning `change-id` list Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.

Rollup of 5 pull requests Successful merges: - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) - rust-lang#139111 (Properly document FakeReads) - rust-lang#139122 (Remove attribute `#[rustc_error]`) - rust-lang#139132 (Improve hir_pretty for struct expressions.) - rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned onur-ozkan Mar 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 28, 2025

onur-ozkan approved these changes Mar 28, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2025

thaliaarchi force-pushed the bootstrap-change-id-clone branch from 4f506f5 to ad29f94 Compare March 28, 2025 06:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2025

matthiaskrgr mentioned this pull request Mar 28, 2025

Rollup of 7 pull requests #139054

Merged

matthiaskrgr mentioned this pull request Mar 28, 2025

Rollup of 8 pull requests #139085

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2025

bootstrap: Avoid cloning change-id list

fbe5e55

thaliaarchi force-pushed the bootstrap-change-id-clone branch from ad29f94 to fbe5e55 Compare March 28, 2025 21:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2025

jhpratt mentioned this pull request Mar 29, 2025

Rollup of 8 pull requests #139094

Closed

jhpratt mentioned this pull request Mar 29, 2025

Rollup of 7 pull requests #139096

Closed

jhpratt mentioned this pull request Mar 30, 2025

Rollup of 5 pull requests #139126

Closed

jhpratt mentioned this pull request Mar 30, 2025

Rollup of 6 pull requests #139147

Closed

jhpratt mentioned this pull request Mar 30, 2025

Rollup of 5 pull requests #139154

Merged

bors merged commit 4cfcafd into rust-lang:master Mar 31, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Mar 31, 2025

thaliaarchi deleted the bootstrap-change-id-clone branch March 31, 2025 04:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bootstrap: Avoid cloning `change-id` list#139044

bootstrap: Avoid cloning `change-id` list#139044
bors merged 1 commit intorust-lang:masterfrom
thaliaarchi:bootstrap-change-id-clone

thaliaarchi commented Mar 28, 2025 •

edited

Loading

Uh oh!

rustbot commented Mar 28, 2025

Uh oh!

onur-ozkan left a comment

Uh oh!

This comment has been minimized.

onur-ozkan commented Mar 28, 2025

Uh oh!

onur-ozkan commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

Kobzol commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

thaliaarchi commented Mar 28, 2025

Uh oh!

Kobzol commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

thaliaarchi commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 28, 2025

Uh oh!

onur-ozkan left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

onur-ozkan commented Mar 28, 2025

Uh oh!

onur-ozkan commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

Kobzol commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

thaliaarchi commented Mar 28, 2025

Uh oh!

Kobzol commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

thaliaarchi commented Mar 28, 2025 •

edited

Loading