Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 20.1.2 #139250

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Update to LLVM 20.1.2 #139250

merged 1 commit into from
Apr 3, 2025

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Apr 2, 2025

@rustbot label A-LLVM T-compiler

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
@cuviper
Copy link
Member

cuviper commented Apr 2, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Apr 2, 2025

📌 Commit 6e6d4a8 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
@bors
Copy link
Collaborator

bors commented Apr 3, 2025

⌛ Testing commit 6e6d4a8 with merge b6d74b5...

@bors
Copy link
Collaborator

bors commented Apr 3, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing b6d74b5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 3, 2025
@bors bors merged commit b6d74b5 into rust-lang:master Apr 3, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 3, 2025
Copy link

github-actions bot commented Apr 3, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3658060 (parent) -> b6d74b5 (this PR)

Test differences

Show 13 test diffs

Stage 2

  • [assembly] tests/assembly/riscv-soft-abi-with-float-features.rs#LLVM-PRE-20: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 19) (J0)
  • [assembly] tests/assembly/x86_64-bigint-helpers.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 19) (J0)
  • [codegen] tests/codegen/branch-protection-old-llvm.rs#BKEY: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 18) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 18) (J0)
  • [codegen] tests/codegen/branch-protection-old-llvm.rs#BTI: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 18) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 18) (J0)
  • [codegen] tests/codegen/branch-protection-old-llvm.rs#LEAF: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 18) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 18) (J0)
  • [codegen] tests/codegen/branch-protection-old-llvm.rs#NONE: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 18) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 18) (J0)
  • [codegen] tests/codegen/branch-protection-old-llvm.rs#PACRET: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 18) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 18) (J0)
  • [codegen] tests/codegen/call-metadata.rs: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 18) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 18) (J0)
  • [codegen] tests/codegen/integer-cmp.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 19) (J0)
  • [codegen] tests/codegen/vec_pop_push_noop.rs#llvm-pre-19: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 18) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 18) (J0)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-DEBUG: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 19) (J1)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-OPTIM: ignore (ignored when the LLVM version (20.1.1) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.2) is newer than majorversion 19) (J1)
  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J2)

Job group index

  • J0: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
  • J1: test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
  • J2: x86_64-gnu-nopt

Job duration changes

  1. aarch64-gnu-debug: 4195.6s -> 6948.6s (65.6%)
  2. x86_64-rust-for-linux: 2713.5s -> 4322.3s (59.3%)
  3. arm-android: 5118.0s -> 7772.6s (51.9%)
  4. mingw-check: 1233.1s -> 1869.0s (51.6%)
  5. armhf-gnu: 4500.4s -> 6509.4s (44.6%)
  6. x86_64-gnu-nopt: 5533.3s -> 7712.6s (39.4%)
  7. test-various: 4246.0s -> 5757.5s (35.6%)
  8. dist-x86_64-illumos: 5730.7s -> 7708.4s (34.5%)
  9. x86_64-gnu: 6383.6s -> 8568.5s (34.2%)
  10. x86_64-gnu-tools: 6112.9s -> 8054.3s (31.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@dianqk dianqk deleted the llvm-20.1.2 branch April 3, 2025 07:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b6d74b5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.8%, secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

Cycles

Results (secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-3.5%, -1.9%] 15
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.368s -> 778.474s (0.01%)
Artifact size: 365.91 MiB -> 365.89 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants