Rehome 35 tests/ui/issues/ tests to other subdirectories under tests/ui/#144089
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 26, 2025
Merged
Rehome 35 tests/ui/issues/ tests to other subdirectories under tests/ui/#144089bors merged 1 commit intorust-lang:masterfrom
tests/ui/issues/ tests to other subdirectories under tests/ui/#144089bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
|
rustbot
added
A-tidy
Collaborator
|
There are changes to the cc @jieyouxu |
Oneirical
force-pushed
the
uncountable-integer-1
branch
from
74fe4ca to
a62b29d
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #144145) made this pull request unmergeable. Please resolve the merge conflicts. |
Oneirical
force-pushed
the
uncountable-integer-1
branch
from
a62b29d to
2cfcf5d
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer-1
branch
from
2cfcf5d to
f63de22
Compare
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
Member
|
I'm going to review the PR removing the issue limits check first, as otherwise this and Kivo's other PR moving |
rustbot
added
S-waiting-on-author
Oneirical
force-pushed
the
uncountable-integer-1
branch
from
f63de22 to
06227df
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer-1
branch
from
06227df to
c66a895
Compare
Collaborator
|
☔ The latest upstream changes (presumably #144360) made this pull request unmergeable. Please resolve the merge conflicts. |
Oneirical
force-pushed
the
uncountable-integer-1
branch
from
c66a895 to
a924d44
Compare
Collaborator
|
This PR modifies |
Contributor
Author
|
@rustbot ready |
rustbot
removed
the
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
jieyouxu
approved these changes
Jul 25, 2025
| stdout.write(b"Hello!"); | ||
| } | ||
|
|
||
| // https://github.com/rust-lang/rust/issues/4333 |
Member
There was a problem hiding this comment.
Remark: hm, I think I would still prefer having these comments at the top of the test, and keep two commits {move, edits}. It's fine for this PR, but I do still think it's nicer to have the doc comments / backlinks on start of file.
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
jieyouxu
removed
T-bootstrap
bors
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup of 9 pull requests Successful merges: - #144089 (Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144171 (pattern_analysis: add option to get a full set of witnesses) - #144201 (Mention type that could be `Clone` but isn't in more cases) - #144316 (bootstrap: Move musl-root fallback out of sanity check) - #144339 (Enable dwarf-mixed-versions-lto.rs test on RISC-V (riscv64)) - #144341 (Enable const-vector.rs test on RISC-V (riscv64)) - #144352 (RustWrapper: Suppress getNextNonDebugInfoInstruction) - #144356 (Add `ignore-backends` annotations in failing GCC backend ui tests) - #144364 (Update `dlmalloc` dependency of libstd) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup merge of #144089 - Oneirical:uncountable-integer-1, r=jieyouxu Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` #143902 divided into smaller, easier to review chunks. Part of #133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer The URL addition at the end, as well as moving around the auxiliary files and editing the `stderr` files with the new filename, were done using a Python script. Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#143902 divided into smaller, easier to review chunks.
Part of #133895
Methodology:
tests/ui/SUMMARY.mdThe URL addition at the end, as well as moving around the auxiliary files and editing the
stderrfiles with the new filename, were done using a Python script.Inspired by the methodology that @Kivooeo was using.
r? @jieyouxu