Rollup of 8 pull requests by jhpratt · Pull Request #144238 · rust-lang/rust

jhpratt · 2025-07-21T03:11:24Z

Successful merges:

tests: Skip supported-crate-types test on musl hosts #144144 (tests: Skip supported-crate-types test on musl hosts)
opt-dist: change build_dir field to be an actual build dir #144159 (opt-dist: change build_dir field to be an actual build dir)
Debug impls for DropElaborators #144162 (Debug impls for DropElaborators)
Add non-regression test for #144168 #144189 (Add non-regression test for zerocopy-0.8.25 no longer builds on nightly #144168)
Don't consider unstable fields always-inhabited #144216 (Don't consider unstable fields always-inhabited)
Miri subtree update #144229 (Miri subtree update)
Option::as_slice: fix comment #144230 (Option::as_slice: fix comment)
Fix run-make tests on musl hosts #144235 (Fix run-make tests on musl hosts)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

triagebot welcome message for new users

Automatic Rustup

allow using different cargo binary

triagebot: tweak welcome message

Automatic Rustup

make native-lib support compile-time-optional, and centralize cfg usage

and ensure we don't unwind out of the "weird state" during tracing

move page protection logic inside native_lib

This test depends on the target-specific behavior of crt-static for musl targets. However, running the testsuite on a musl host requires setting `crt-static` to `false`, as it wouldn't otherwise be possible to build rustc. This in turn will enable `-Ctarget-feature=-crt-static` for all tests, mismatching the expected `+crt-static` for the musl target tested in this testcase. Since this test specifically tests the default value of `crt-static` for the musl target, ignoring it entirely makes more sense than manually setting `-Ctarget-feature=+crt-static` here, but both would be valid approaches. Signed-off-by: Jens Reidel <adrian@travitia.xyz>

Automatic Rustup

…part of float-nondet

add -Zmiri-no-extra-rounding-error to specifically disable just that part of float-nondet

…ix, r=scottmcm Option::as_slice: fix comment The implementation got changed in rust-lang#117525 without updating the comment. Now the comment makes no sense any more since there is no intrinsic that returns a pointer in this function any more. (It is also very strange to say "in the new version" in a comment -- what is that supposed to tell someone reading the code 2 years later? That wording was introduced even earlier, in rust-lang#109179.) Cc `@GKFX` `@petrochenkov` `@llogiq` `@scottmcm`

Fix run-make tests on musl hosts On musl hosts, we already set `-Ctarget-feature=-crt-static` and `IS_MUSL_HOST=1` in compiletest. However, in order for the run-make tests to compile fine on musl hosts, we need to propagate this flag in our rustc invocations to ensure we can generate cdylibs.

jhpratt · 2025-07-21T03:11:34Z

@bors r+ rollup=never p=5

bors · 2025-07-21T03:11:36Z

📌 Commit f0da6e2 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-07-21T05:45:50Z

⌛ Testing commit f0da6e2 with merge 79dd0d1...

Rollup of 8 pull requests Successful merges: - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144159 (opt-dist: change build_dir field to be an actual build dir) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) - #144229 (Miri subtree update) - #144230 (Option::as_slice: fix comment) - #144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-21T08:10:13Z

💔 Test failed - checks-actions

jieyouxu · 2025-07-21T08:25:30Z

The CI runner couldn't find the way back to home 😔

The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors retry

bors · 2025-07-21T08:42:58Z

⌛ Testing commit f0da6e2 with merge 6781992...

jieyouxu · 2025-07-21T08:48:12Z

(Github is having issues atm)

bors · 2025-07-21T11:41:44Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 6781992 to master...

rust-timer · 2025-07-21T11:44:02Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#144144	tests: Skip supported-crate-types test on musl hosts	`09df50bc080a994793a8519d26b5257554af047d` (link)
#144159	opt-dist: change build_dir field to be an actual build dir	`266a0e29f513782c998d975406c72f9392f250c4` (link)
#144162	Debug impls for DropElaborators	`6f7f1945bd182e3a604060d296ff177daebc2fef` (link)
#144189	Add non-regression test for #144168	`37782b0e42ca8fb7ad92cb7f35e2952b1b4258ec` (link)
#144216	Don't consider unstable fields always-inhabited	`08b30f95d80cf68f2cd189061c6469759c0af474` (link)
#144229	Miri subtree update	`948d70ad90f24808e759c1eb82eefac1713af938` (link)
#144230	Option::as_slice: fix comment	`410dbd39d553c331ee19a3c616c98959280853ae` (link)
#144235	Fix run-make tests on musl hosts	`9a3f812673cf55bf8b24818793908bb7be952164` (link)

previous master: e05ab47e6c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-21T11:45:00Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e05ab47 (parent) -> 6781992 (this PR)

Test differences

Show 15 test diffs

Stage 1

[ui] tests/ui/resolve/underscore-bindings-disambiguators.rs: [missing] -> pass (J1)
[ui] tests/ui/uninhabited/uninhabited-unstable-field.rs: [missing] -> pass (J1)
[ui] tests/ui/uninhabited/uninhabited-unstable-field.rs#current: pass -> [missing] (J1)
[ui] tests/ui/uninhabited/uninhabited-unstable-field.rs#exhaustive: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/resolve/underscore-bindings-disambiguators.rs: [missing] -> pass (J0)
[ui] tests/ui/uninhabited/uninhabited-unstable-field.rs: [missing] -> pass (J0)
[ui] tests/ui/uninhabited/uninhabited-unstable-field.rs#current: pass -> [missing] (J0)
[ui] tests/ui/uninhabited/uninhabited-unstable-field.rs#exhaustive: pass -> [missing] (J0)
[ui] tests/ui/print-request/supported-crate-types.rs#linux: pass -> ignore (ignored when the target environment is musl) (J2)
[ui] tests/ui/print-request/supported-crate-types.rs#musl: pass -> ignore (ignored when the target environment is musl) (J2)
[ui] tests/ui/print-request/supported-crate-types.rs#wasm: pass -> ignore (ignored when the target environment is musl) (J2)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 67819923ac8ea353aaa775303f4c3aacbf41d010 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 7985.1s -> 5703.4s (-28.6%)
dist-apple-various: 5588.6s -> 7119.5s (27.4%)
dist-x86_64-apple: 10890.5s -> 8418.1s (-22.7%)
x86_64-apple-1: 8108.3s -> 9564.2s (18.0%)
pr-check-2: 2600.1s -> 2144.0s (-17.5%)
aarch64-apple: 5193.2s -> 4380.9s (-15.6%)
pr-check-1: 1721.8s -> 1507.7s (-12.4%)
x86_64-rust-for-linux: 2919.2s -> 2579.5s (-11.6%)
i686-gnu-1: 8114.5s -> 7274.3s (-10.4%)
x86_64-gnu-tools: 3643.1s -> 3300.8s (-9.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-21T12:51:38Z

Finished benchmarking commit (6781992): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.3%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.4%, -0.3%]	6

Max RSS (memory usage)

Results (secondary 5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[4.1%, 7.4%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.8%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	2.9%	[2.4%, 3.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.6%, -1.6%]	1
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.006s -> 465.321s (-0.15%)
Artifact size: 374.60 MiB -> 374.50 MiB (-0.03%)

Rollup of 8 pull requests Successful merges: - rust-lang#144144 (tests: Skip supported-crate-types test on musl hosts) - rust-lang#144159 (opt-dist: change build_dir field to be an actual build dir) - rust-lang#144162 (Debug impls for DropElaborators) - rust-lang#144189 (Add non-regression test for rust-lang#144168) - rust-lang#144216 (Don't consider unstable fields always-inhabited) - rust-lang#144229 (Miri subtree update) - rust-lang#144230 (Option::as_slice: fix comment) - rust-lang#144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup

RalfJung and others added 30 commits July 16, 2025 13:58

triagebot welcome message for new users

6e3b9dd

Merge pull request rust-lang#4471 from RalfJung/triagebot-welcome

4e8ce1e

triagebot welcome message for new users

triagebot: tweak welcome message

b390c41

set S-waiting-on labels on new PRs

6728da5

Preparing for merge from rustc

5946616

Merge from rustc

52db0ce

Merge pull request rust-lang#4473 from rust-lang/rustup-2025-07-17

0131e38

Automatic Rustup

allow using different cargo binary

387b603

tweak PR process description

1205c53

Merge pull request rust-lang#4470 from nia-e/custom-cargo-bin

05df8aa

allow using different cargo binary

Merge pull request rust-lang#4472 from RalfJung/triagebot

e30baec

triagebot: tweak welcome message

Preparing for merge from rustc

60f6ad8

Merge from rustc

3e3166f

Merge pull request rust-lang#4474 from rust-lang/rustup-2025-07-18

8339590

Automatic Rustup

make native-lib support compile-time-optional, and centralize cfg usage

24ea3e2

RA config: disable default features for faster build script build

cc6bc7a

Merge pull request rust-lang#4475 from RalfJung/native-lib-optional

aef3d9e

make native-lib support compile-time-optional, and centralize cfg usage

move page protection logic inside native_lib

a438401

and ensure we don't unwind out of the "weird state" during tracing

Merge pull request rust-lang#4476 from RalfJung/page-prot

3799cbd

move page protection logic inside native_lib

debug impls for drop elaborators

2a03750

Preparing for merge from rustc

b8bcb4d

Merge from rustc

e11ea3d

Merge pull request rust-lang#4478 from rust-lang/rustup-2025-07-19

eef454f

Automatic Rustup

add -Zmiri-no-extra-rounding-error to specifically disable just that …

4aa4376

…part of float-nondet

Merge pull request rust-lang#4480 from RalfJung/no-extra-rounding-error

1f15460

add -Zmiri-no-extra-rounding-error to specifically disable just that part of float-nondet

cargo update

c1242b7

bump colored dep

bb79e79

bump ipc-channel

4bd8088

bump ui_test

0b8f558

jhpratt added 2 commits July 20, 2025 23:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2025

bors merged commit 6781992 into rust-lang:master Jul 21, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 21, 2025

jhpratt deleted the rollup-xb8aida branch July 21, 2025 11:42

Uh oh!

Conversation

jhpratt commented Jul 21, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jul 21, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

jieyouxu commented Jul 21, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

jieyouxu commented Jul 21, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jul 21, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

jhpratt commented Jul 21, 2025 •

edited by rustbot

Loading