recommend using a HashMap if a HashSet's second generic parameter doesn't implement BuildHasher #147171
+68
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
Qelxiros
force-pushed
the
hashmap_diag
branch
from
48c4887 to
65afb13
Compare
This comment has been minimized.
This comment has been minimized.
Qelxiros
force-pushed
the
hashmap_diag
branch
from
65afb13 to
9d34ff5
Compare
fee1-dead
requested changes
Oct 2, 2025
Comment on lines
+10
to
+13
| note: the foreign item type `String` doesn't implement `BuildHasher` | ||
| --> $SRC_DIR/alloc/src/string.rs:LL:COL | ||
| | | ||
| = note: not implement `BuildHasher` |
There was a problem hiding this comment.
note to self, this probably needs improvement.
There was a problem hiding this comment.
Hmm. Could there be other tests that showcase when this help message could appear? For example when I try to insert, or when I try to create a new value of the HashSet type.
Also I think it might be better to put this under the less crowded tests/ui/hashmap directory.
rustbot
added
S-waiting-on-author
…sn't implement BuildHasher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #147147
The suggestion span is wrong, but I'm not sure how to find the right one.fixedI'm relatively new to the diagnostics ecosystem, so I'm not sure if
span_helpis the right choice.span_suggestion_*might be better, but the output fromx testlooks weird in that case.