Use #[cfg(debug_assertions)] instead of if cfg!(debug_assertions) for debug_assert_* macros

[Kivooeo]

Due to limit knowledges about conditional compilation I'm not sure if this is fine change and will not cause any greater problems in future, but seems (according to new test) that is addresses #147241

So, even though it's a small change, it needs a thorough review by someone more tech-savvy

r? libs

[tgross35]

I don't think we want this change, so I closed #147241. A type implementing PartialEq only in debug mode is rare, and it's an advantage that we have type checking regardless of whether or not debug assertions are enabled. In the rare cases this is a problem, the user can use #[cfg] themselves.

There is also no syntax validation as-written if debug_assertions is disabled (e.g. debug_assert!(anything you like); is accepted)

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[Kivooeo]

Thanks , that sounds reasonable enough for me, I guess I can close this one as well, at least for now, so if we will ever decide to use attributes instead we already will have this 😅