Fix ICE when applying test macro to crate root #147841

jdonszelmann · 2025-10-18T10:28:10Z

This PR does a couple of things. First of all, I found an ICE that happens when applying #![core::prelude::v1::test] to the crate root. This is caused by the test macro not expanding to an item when --test isn't applied. For the crate root, that means it deletes the crate....

The fix now first does target checking, and only if the target is valid discards the item when --test isn't applied. The discarding is, I think, important for perf.

The problem with this PR is that it means that #[test] applied to structs previously would give no errors unless --test is applied! That sounds like a bug to me, but maybe we should crater run it just in case, since technically that's a breaking change. Errors in such items wouldn't be reported previously.

Also fixed a smol diagnostics bug with #[bench]'s error messages refering to #[test] accidentally.

r? noratrieb (since I already explained you a bunch, feel free to re-assign)

Fixes #114920

rustbot · 2025-10-18T10:28:14Z

noratrieb is not on the review rotation at the moment.
They may take a while to respond.

jdonszelmann · 2025-10-18T10:29:07Z

compiler/rustc_builtin_macros/src/test.rs

+
+    if !is_bench {
+        err.with_span_suggestion(attr_sp,
            "replace with conditional compilation to make the item only exist when tests are being run",


only give the suggestion of cfg(test) when we're dealing with test attrs

jdonszelmann · 2025-10-18T10:29:39Z

tests/ui/feature-gates/gating-of-test-attrs.rs

@@ -0,0 +1,48 @@
+#![feature(test)]
+
+// test is a built-in macro, not a built-in attribute, but it kind of acts like both.


New test for test attributes. The previous tests simply asserted no errors would be given but that's not true anymore, and I think they should error!

jdonszelmann · 2025-10-18T10:30:01Z

tests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs

-// non-crate-level #[test] attributes seem to be ignored.
-
-#[test]
-mod test { mod inner { #![test] }


these were weird here anyway, test isn't a built-in attribute but a built-in macro!

jdonszelmann · 2025-10-18T10:30:39Z

tests/ui/macros/issue-111749.rs

@@ -5,8 +5,8 @@ macro_rules! cbor_map {
 }

 fn main() {
-    cbor_map! { #[test(test)] 4};
-    //~^ ERROR removing an expression is not supported in this position
+    cbor_map! { #[test(test)] 4i32};


changed to an i32 cause signum wouldn't be valid on just 4

jdonszelmann · 2025-10-18T10:31:26Z

tests/ui/macros/issue-111749.rs

-    cbor_map! { #[test(test)] 4};
-    //~^ ERROR removing an expression is not supported in this position
+    cbor_map! { #[test(test)] 4i32};
+    //~^ ERROR the `#[test]` attribute may only be used on a non-associated function


I think this is the correct error here, not something about removing expressions. I think noting that the target is wrong is more important.

jdonszelmann · 2025-10-18T10:31:45Z

tests/ui/macros/test-on-crate-root.rs

@@ -0,0 +1,8 @@
+// ICE when applying `#![test]` to the crate root,
+// though only when specified with a full path. `#![test]` is not enough.
+#![core::prelude::v1::test]


tests the specific ICE from the PR description

jdonszelmann · 2025-10-18T10:33:12Z

tests/ui/macros/attr-empty-expr.stderr

-LL |     let _ = #[test] 0;
-   |             ^^^^^^^
-
-error: removing an expression is not supported in this position


this test was testing for "empty expressions". this is super niche, can only happen with ast-based attributes (only like 10 in the compiler) and none of the examples in this test should actually remove the expression, they should instead report that the target is wrong. I can't find any other examples of node-removing attributes so I think this test is simply superfluous now.

jdonszelmann · 2025-10-18T10:34:22Z

@bors try
@craterbot check

craterbot · 2025-10-18T10:34:24Z

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Fix ICE when applying test macro to crate root

matthiaskrgr · 2025-10-18T10:58:11Z

does this fix #114920 ?

jdonszelmann · 2025-10-18T11:10:10Z

yea, that's actually exactly what it fixes. there was a crashtest for it I just notice but the fix is rather trivial in the end

jdonszelmann · 2025-10-18T11:12:41Z

@bors try cancel

rust-bors · 2025-10-18T11:12:44Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/18614510844

rustbot · 2025-10-18T11:14:19Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

jdonszelmann · 2025-10-18T11:14:25Z

@bors try

Fix ICE when applying test macro to crate root

rust-bors · 2025-10-18T13:25:55Z

☀️ Try build successful (CI)
Build commit: 73ffebf (73ffebff6f34db7eb167bf9edcf2afa19c3073e9, parent: ab1d2444533d829e2d5cff6634cd3c70de6d7103)

jdonszelmann · 2025-10-18T14:11:58Z

@craterbot check

craterbot · 2025-10-18T14:12:30Z

👌 Experiment pr-147841 created and queued.
🤖 Automatically detected try build 73ffebf
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Urgau · 2025-12-03T17:48:56Z

cc @Urgau range diff doesn't seem to work?

As far as I can see the range-diff is right, there aren't changes between the two diffs (previous - current - patch diff - range-diff).

The commits are exactly the same (modulo the ids). I don't see in the new version the requested changes by Waffle.

…flelapkin Fix ICE when applying test macro to crate root This PR does a couple of things. First of all, I found [an ICE](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=a733a7f3d223e1a9712e44b571f3e5cf) that happens when applying `#![core::prelude::v1::test]` to the crate root. This is caused by the test macro not expanding to an item when `--test` isn't applied. For the crate root, that means it deletes the crate.... The fix now first does target checking, and only if the target is valid discards the item when `--test` isn't applied. The discarding is, I think, important for perf. The problem with this PR is that it means that `#[test]` applied to structs previously would give no errors unless `--test` is applied! That sounds like a bug to me, but maybe we should crater run it just in case, since technically that's a breaking change. Errors in such items wouldn't be reported previously. Also fixed a smol diagnostics bug with `#[bench]`'s error messages refering to `#[test]` accidentally. r? noratrieb (since I already explained you a bunch, feel free to re-assign) Fixes rust-lang#114920

Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup

jdonszelmann · 2025-12-03T20:04:09Z

hm, but they are though, here https://github.com/rust-lang/rust/pull/147841/files#diff-8596d519cee5fd6a240b88d1330b213686d37a7faafb9afffc66713efdd4e793R3

WaffleLapkin · 2025-12-03T20:53:28Z

@Urgau I'll also add that "View changes since this review" link redirects to github diff which is affected by the rebase on main.

Urgau · 2025-12-03T22:41:28Z

Okay, I think I know why triagebot links to the wrong pages.

For some reason the GitHub's force-push event thinks you only forced-push until 97d4d21 not until 8f82478, and the webhook we got also has 97d4d21 as the head, not 8f82478.

If we correct for that, the range-diff looks more usual, and contains the changes you made.

As for the "View changes since this review" link, we seemed to think that the oldbase of the PR was 568b117 and the newbase is also 568b117, so we don't go to the range-diff, but I don't know why GitHub thinks the base was 568b117 when the parent of 552d971 is 9b82a4f. Which (surprise, surprise!) would give us the same range-diff.

Seems like something is messed up in GitHub's API/webhook, which makes triagebot links to the wrong thing. I will keep an eye open, in case it happens on other PRs too.

Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup

…flelapkin Fix ICE when applying test macro to crate root This PR does a couple of things. First of all, I found [an ICE](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=a733a7f3d223e1a9712e44b571f3e5cf) that happens when applying `#![core::prelude::v1::test]` to the crate root. This is caused by the test macro not expanding to an item when `--test` isn't applied. For the crate root, that means it deletes the crate.... The fix now first does target checking, and only if the target is valid discards the item when `--test` isn't applied. The discarding is, I think, important for perf. The problem with this PR is that it means that `#[test]` applied to structs previously would give no errors unless `--test` is applied! That sounds like a bug to me, but maybe we should crater run it just in case, since technically that's a breaking change. Errors in such items wouldn't be reported previously. Also fixed a smol diagnostics bug with `#[bench]`'s error messages refering to `#[test]` accidentally. r? noratrieb (since I already explained you a bunch, feel free to re-assign) Fixes rust-lang#114920

Rollup of 12 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149147 (Fix unused_assignments false positives from macros) - #149183 (Use `TypingMode::PostAnalysis` in `try_evaluate_const`) - #149456 (std: don't call `current_os_id` from signal handler) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149528 (reword error for invalid range patterns) - #149539 (Additional test for uN::{gather,scatter}_bits) - #149549 (Regression test for system register `ttbr0_el2`) - #149550 (Disable native-lib for x check miri) - #149554 (build-manifest: generate MSI and MINGW arrays from rustc) - #149557 (c-variadic: bpf and spirv do not support c-variadic definitions) - #149569 (Fix mailmap issue) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147841 - jdonszelmann:test-macro-ice, r=wafflelapkin Fix ICE when applying test macro to crate root This PR does a couple of things. First of all, I found [an ICE](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=a733a7f3d223e1a9712e44b571f3e5cf) that happens when applying `#![core::prelude::v1::test]` to the crate root. This is caused by the test macro not expanding to an item when `--test` isn't applied. For the crate root, that means it deletes the crate.... The fix now first does target checking, and only if the target is valid discards the item when `--test` isn't applied. The discarding is, I think, important for perf. The problem with this PR is that it means that `#[test]` applied to structs previously would give no errors unless `--test` is applied! That sounds like a bug to me, but maybe we should crater run it just in case, since technically that's a breaking change. Errors in such items wouldn't be reported previously. Also fixed a smol diagnostics bug with `#[bench]`'s error messages refering to `#[test]` accidentally. r? noratrieb (since I already explained you a bunch, feel free to re-assign) Fixes #114920

Kobzol · 2025-12-04T12:50:24Z

@rust-timer build 9b9e073

For #149631 (comment).

rust-timer · 2025-12-04T12:51:23Z

Finished benchmarking commit (9b9e073): comparison URL.

Overall result: no relevant changes - BENCHMARK(S) FAILED

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

Job failure

❗ ❗ ❗ ❗ ❗

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: missing data

Kobzol · 2025-12-04T13:50:42Z

@rust-timer build 9b9e073

rust-timer · 2025-12-04T15:09:53Z

Finished benchmarking commit (9b9e073): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.789s -> 468.167s (-0.13%)
Artifact size: 386.75 MiB -> 386.74 MiB (-0.00%)

Rollup of 12 pull requests Successful merges: - rust-lang/rust#147841 (Fix ICE when applying test macro to crate root) - rust-lang/rust#149147 (Fix unused_assignments false positives from macros) - rust-lang/rust#149183 (Use `TypingMode::PostAnalysis` in `try_evaluate_const`) - rust-lang/rust#149456 (std: don't call `current_os_id` from signal handler) - rust-lang/rust#149501 (CTFE: avoid emitting a hard error on generic normalization failures) - rust-lang/rust#149528 (reword error for invalid range patterns) - rust-lang/rust#149539 (Additional test for uN::{gather,scatter}_bits) - rust-lang/rust#149549 (Regression test for system register `ttbr0_el2`) - rust-lang/rust#149550 (Disable native-lib for x check miri) - rust-lang/rust#149554 (build-manifest: generate MSI and MINGW arrays from rustc) - rust-lang/rust#149557 (c-variadic: bpf and spirv do not support c-variadic definitions) - rust-lang/rust#149569 (Fix mailmap issue) r? `@ghost` `@rustbot` modify labels: rollup

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [rust](https://github.com/rust-lang/rust) | minor | `1.92.0` → `1.93.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.93.0`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1930-2026-01-22) [Compare Source](rust-lang/rust@1.92.0...1.93.0) \========================== <a id="1.93.0-Language"></a> ## Language - [Stabilize several s390x `vector`-related target features and the `is_s390x_feature_detected!` macro](rust-lang/rust#145656) - [Stabilize declaration of C-style variadic functions for the `system` ABI](rust-lang/rust#145954) - [Emit error when using some keyword as a `cfg` predicate](rust-lang/rust#146978) - [Stabilize `asm_cfg`](rust-lang/rust#147736) - [During const-evaluation, support copying pointers byte-by-byte](rust-lang/rust#148259) - [LUB coercions now correctly handle function item types, and functions with differing safeties](rust-lang/rust#148602) - [Allow `const` items that contain mutable references to `static` (which is *very* unsafe, but not *always* UB)](rust-lang/rust#148746) - [Add warn-by-default `const_item_interior_mutations` lint to warn against calls which mutate interior mutable `const` items](rust-lang/rust#148407) - [Add warn-by-default `function_casts_as_integer` lint](rust-lang/rust#141470) <a id="1.93.0-Compiler"></a> ## Compiler - [Stabilize `-Cjump-tables=bool`](rust-lang/rust#145974). The flag was previously called `-Zno-jump-tables`. <a id="1.93.0-Platform-Support"></a> ## Platform Support - [Promote `riscv64a23-unknown-linux-gnu` to Tier 2 (without host tools)](rust-lang/rust#148435) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. [platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html <a id="1.93.0-Libraries"></a> ## Libraries - [Stop internally using `specialization` on the `Copy` trait as it is unsound in the presence of lifetime dependent `Copy` implementations. This may result in some performance regressions as some standard library APIs may now call `Clone::clone` instead of performing bitwise copies](rust-lang/rust#135634) - [Allow the global allocator to use thread-local storage and `std::thread::current()`](rust-lang/rust#144465) - [Make `BTree::append` not update existing keys when appending an entry which already exists](rust-lang/rust#145628) - [Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`](rust-lang/rust#145665) <a id="1.93.0-Stabilized-APIs"></a> ## Stabilized APIs - [`<[MaybeUninit<T>]>::assume_init_drop`](https://doc.rust-lang.org/stable/core/primitive.slice.html#method.assume_init_drop) - [`<[MaybeUninit<T>]>::assume_init_ref`](https://doc.rust-lang.org/stable/core/primitive.slice.html#method.assume_init_ref) - [`<[MaybeUninit<T>]>::assume_init_mut`](https://doc.rust-lang.org/stable/core/primitive.slice.html#method.assume_init_mut) - [`<[MaybeUninit<T>]>::write_copy_of_slice`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.write_copy_of_slice) - [`<[MaybeUninit<T>]>::write_clone_of_slice`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.write_clone_of_slice) - [`String::into_raw_parts`](https://doc.rust-lang.org/stable/std/string/struct.String.html#method.into_raw_parts) - [`Vec::into_raw_parts`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.into_raw_parts) - [`<iN>::unchecked_neg`](https://doc.rust-lang.org/stable/std/primitive.isize.html#method.unchecked_neg) - [`<iN>::unchecked_shl`](https://doc.rust-lang.org/stable/std/primitive.isize.html#method.unchecked_shl) - [`<iN>::unchecked_shr`](https://doc.rust-lang.org/stable/std/primitive.isize.html#method.unchecked_shr) - [`<uN>::unchecked_shl`](https://doc.rust-lang.org/stable/std/primitive.usize.html#method.unchecked_shl) - [`<uN>::unchecked_shr`](https://doc.rust-lang.org/stable/std/primitive.usize.html#method.unchecked_shr) - [`<[T]>::as_array`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.as_array) - [`<[T]>::as_array_mut`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.as_mut_array) - [`<*const [T]>::as_array`](https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.as_array) - [`<*mut [T]>::as_array_mut`](https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.as_mut_array) - [`VecDeque::pop_front_if`](https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.pop_front_if) - [`VecDeque::pop_back_if`](https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.pop_back_if) - [`Duration::from_nanos_u128`](https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.from_nanos_u128) - [`char::MAX_LEN_UTF8`](https://doc.rust-lang.org/stable/std/primitive.char.html#associatedconstant.MAX_LEN_UTF8) - [`char::MAX_LEN_UTF16`](https://doc.rust-lang.org/stable/std/primitive.char.html#associatedconstant.MAX_LEN_UTF16) - [`std::fmt::from_fn`](https://doc.rust-lang.org/stable/std/fmt/fn.from_fn.html) - [`std::fmt::FromFn`](https://doc.rust-lang.org/stable/std/fmt/struct.FromFn.html) <a id="1.93.0-Cargo"></a> ## Cargo - [Enable CARGO\_CFG\_DEBUG\_ASSERTIONS in build scripts based on profile](rust-lang/cargo#16160) - [In `cargo tree`, support long forms for `--format` variables](rust-lang/cargo#16204) - [Add `--workspace` to `cargo clean`](rust-lang/cargo#16263) <a id="1.93.0-Rustdoc"></a> ## Rustdoc - [Remove `#![doc(document_private_items)]`](rust-lang/rust#146495) - [Include attribute and derive macros in search filters for "macros"](rust-lang/rust#148176) - [Include extern crates in search filters for `import`](rust-lang/rust#148301) - [Validate usage of crate-level doc attributes](rust-lang/rust#149197). This means if any of `html_favicon_url`, `html_logo_url`, `html_playground_url`, `issue_tracker_base_url`, or `html_no_source` either has a missing value, an unexpected value, or a value of the wrong type, rustdoc will emit the deny-by-default lint `rustdoc::invalid_doc_attributes`. <a id="1.93.0-Compatibility-Notes"></a> ## Compatibility Notes - [Introduce `pin_v2` into the builtin attributes namespace](rust-lang/rust#139751) - [Update bundled musl to 1.2.5](rust-lang/rust#142682) - [On Emscripten, the unwinding ABI used when compiling with `panic=unwind` was changed from the JS exception handling ABI to the wasm exception handling ABI.](rust-lang/rust#147224) If linking C/C++ object files with Rust objects, `-fwasm-exceptions` must be passed to the linker now. On nightly Rust, it is possible to get the old behavior with `-Zwasm-emscripten-eh=false -Zbuild-std`, but it will be removed in a future release. - The `#[test]` attribute, used to define tests, was previously ignored in various places where it had no meaning (e.g on trait methods or types). Putting the `#[test]` attribute in these places is no longer ignored, and will now result in an error; this may also result in errors when generating rustdoc. [Error when `test` attribute is applied to structs](rust-lang/rust#147841) - Cargo now sets the `CARGO_CFG_DEBUG_ASSERTIONS` environment variable in more situations. This will cause crates depending on `static-init` versions 1.0.1 to 1.0.3 to fail compilation with "failed to resolve: use of unresolved module or unlinked crate `parking_lot`". See [the linked issue](rust-lang/rust#150646 (comment)) for details. - [User written types in the `offset_of!` macro are now checked to be well formed.](rust-lang/rust#150465) - `cargo publish` no longer emits `.crate` files as a final artifact for user access when the `build.build-dir` config is unset - [Upgrade the `deref_nullptr` lint from warn-by-default to deny-by-default](rust-lang/rust#148122) - [Add future-incompatibility warning for `...` function parameters without a pattern outside of `extern` blocks](rust-lang/rust#143619) - [Introduce future-compatibility warning for `repr(C)` enums whose discriminant values do not fit into a `c_int` or `c_uint`](rust-lang/rust#147017) - [Introduce future-compatibility warning against ignoring `repr(C)` types as part of `repr(transparent)`](rust-lang/rust#147185) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

rustbot assigned Noratrieb Oct 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2025

jdonszelmann commented Oct 18, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Oct 18, 2025

Auto merge of #147841 - jdonszelmann:test-macro-ice, r=<try>

013fb92

Fix ICE when applying test macro to crate root

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the test-macro-ice branch from 3e897fe to a9e4630 Compare October 18, 2025 11:14

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Oct 18, 2025

Auto merge of #147841 - jdonszelmann:test-macro-ice, r=<try>

73ffebf

Fix ICE when applying test macro to crate root

jdonszelmann mentioned this pull request Oct 18, 2025

Fix ICE from invalid delimeter in attrs parsing #147778

Closed

craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2025

matthiaskrgr mentioned this pull request Dec 3, 2025

Rollup of 9 pull requests #149603

Closed

Zalathar mentioned this pull request Dec 4, 2025

Rollup of 14 pull requests #149628

Closed

This was referenced Dec 4, 2025

Rollup of 13 pull requests #149629

Closed

Rollup of 12 pull requests #149631

Merged

bors merged commit 5019bda into rust-lang:main Dec 4, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Dec 4, 2025

This comment has been minimized.

Sign in to view

theemathas mentioned this pull request Jan 4, 2026

Regressions in 1.93.0 crater run: rustdoc errors on invalid #[test] attribute #150665

Open

BoxyUwU mentioned this pull request Jan 7, 2026

Draft release notes for 1.93 #150760

Closed

		@@ -0,0 +1,48 @@
		#![feature(test)]

		// test is a built-in macro, not a built-in attribute, but it kind of acts like both.

Uh oh!

Fix ICE when applying test macro to crate root #147841

Fix ICE when applying test macro to crate root #147841

Uh oh!

Conversation

jdonszelmann commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Oct 18, 2025

Uh oh!

craterbot commented Oct 18, 2025

Uh oh!

This comment has been minimized.

matthiaskrgr commented Oct 18, 2025

Uh oh!

This comment has been minimized.

jdonszelmann commented Oct 18, 2025

Uh oh!

jdonszelmann commented Oct 18, 2025

Uh oh!

rust-bors bot commented Oct 18, 2025

Uh oh!

rustbot commented Oct 18, 2025

Uh oh!

jdonszelmann commented Oct 18, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Oct 18, 2025

Uh oh!

jdonszelmann commented Oct 18, 2025

Uh oh!

craterbot commented Oct 18, 2025

Uh oh!

Urgau commented Dec 3, 2025

Uh oh!

jdonszelmann commented Dec 3, 2025

Uh oh!

WaffleLapkin commented Dec 3, 2025

Uh oh!

Urgau commented Dec 3, 2025

Uh oh!

Uh oh!

Kobzol commented Dec 4, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Dec 4, 2025

Overall result: no relevant changes - BENCHMARK(S) FAILED

Uh oh!

This comment has been minimized.

Kobzol commented Dec 4, 2025

Uh oh!

rust-timer commented Dec 4, 2025

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

jdonszelmann commented Oct 18, 2025 •

edited

Loading