-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
refactor rustc-hash integration #150353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor rustc-hash integration #150353
Conversation
|
Some changes occurred in exhaustiveness checking cc @Nadrieril These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
cc1e3be to
20c25b8
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
20c25b8 to
7939ffb
Compare
|
Ok, I removed the |
This comment has been minimized.
This comment has been minimized.
7939ffb to
9f5645d
Compare
This comment has been minimized.
This comment has been minimized.
9f5645d to
1229efb
Compare
This comment has been minimized.
This comment has been minimized.
1229efb to
6976fbc
Compare
|
Ok, this compiles now and passes all tests. |
I found that rustc-hash is used in multiple compiler crates. Also some types use
FxBuildHasherwhereas others useBuildHasherDefault<FxHasher>(both do the same thing).In order to simplify future hashing experiments, I changed every location to use
rustc_data_structures::fx::*types instead, and also removed theBuildHasherDefaultvariant. This will simplify future experiments with hashing (for example trying out a hasher that doesn't implementDefaultfor whatever reason).