Skip to content

Unknown -> Unsupported compression algorithm#150630

Open
Mark-Simulacrum wants to merge 1 commit intorust-lang:mainfrom
Mark-Simulacrum:rephrase-compression-warn
Open

Unknown -> Unsupported compression algorithm#150630
Mark-Simulacrum wants to merge 1 commit intorust-lang:mainfrom
Mark-Simulacrum:rephrase-compression-warn

Conversation

@Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jan 2, 2026

Both zstd and zlib are known compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo.

cc #120953

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 2, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Unknown -> Unsupported compression algorithm
7dc36ad 
Both zstd and zlib are *known* compression algorithms, they just may not
be supported by the backend. We shouldn't mislead users into e.g.
thinking they made a typo.
@Mark-Simulacrum Mark-Simulacrum force-pushed the rephrase-compression-warn branch from a42131d to 7dc36ad Compare January 24, 2026 18:30
@Mark-Simulacrum Mark-Simulacrum marked this pull request as ready for review January 24, 2026 20:53
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 24, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 4, 2026

☔ The latest upstream changes (presumably #152104) made this pull request unmergeable. Please resolve the merge conflicts.

davidtwco
davidtwco approved these changes Feb 5, 2026
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing

View changes since this review

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

+1 more reviewer

@hkBst hkBst hkBst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@davidtwco davidtwco

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mark-Simulacrum @rust-log-analyzer @rustbot @davidtwco @hkBst