Skip to content

std: move errno and related functions into sys::io #150723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joboet wants to merge 2 commits into
base: main
Choose a base branch
from
Open

std: move errno and related functions into sys::io #150723

joboet wants to merge 2 commits into from
+902 −848

Conversation

@joboet
Copy link
Member

@joboet joboet commented Jan 6, 2026 •
edited by rustbot
Loading

Part of #117276.

Currently, errno and related functions like decode_error_kind are split across sys::pal and sys::pal::os. This PR moves all of them into a new module inside sys::io.

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 6, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor

tgross35 commented Jan 11, 2026

LGTM,
@bors r+

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

📌 Commit 5978980 has been approved by tgross35

It is now in the queue for this repository.

jdonszelmann added a commit to jdonszelmann/rust that referenced this pull request Jan 11, 2026
@jdonszelmann
Rollup merge of rust-lang#150723 - move_pal_error, r=tgross35
bd30062 
std: move `errno` and related functions into `sys::io`

Part of rust-lang#117276.

Currently, `errno` and related functions like `decode_error_kind` are split across `sys::pal` and `sys::pal::os`. This PR moves all of them into a new module inside `sys::io`.
@jdonszelmann jdonszelmann mentioned this pull request Jan 11, 2026
Closed
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rust-bors
Auto merge of #150974 - jdonszelmann:rollup-R4vhnZ0, r=jdonszelmann
7ce2e85 
Rollup of 7 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Jan 11, 2026

@bors r-
looke like this failed here
#150974 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

Commit 5978980 has been unapproved.

@joboet
Copy link
Member Author

joboet commented Jan 12, 2026

@bors r=@tgross35

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

📌 Commit 210c157 has been approved by @tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 12, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 12, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150723 - move_pal_error, r=@tgross35
6f28ef9 
std: move `errno` and related functions into `sys::io`

Part of rust-lang#117276.

Currently, `errno` and related functions like `decode_error_kind` are split across `sys::pal` and `sys::pal::os`. This PR moves all of them into a new module inside `sys::io`.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 12, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 12, 2026
@bors
Auto merge of #151023 - JonathanBrouwer:rollup-f6vMoSd, r=JonathanBro…
8d04a9f 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #145343 (Dogfood `-Zno-embed-metadata` in the standard library)
 - #150151 (Destabilise `target-spec-json`)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150826 (Add `f16` inline ASM support for s390x)
 - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
 - #150943 (Port `#[must_not_suspend]` to attribute parser)
 - #150990 (std: sys: net: uefi: Make TcpStream Send)
 - #150995 (core: ptr: split_at_mut: fix typo in safety doc)
 - #150998 (Relax test expectation for @__llvm_profile_runtime_user)
 - #151002 (Remove a workaround for a bug (take 2))
 - #151005 (Fix typo in `MaybeUninit` docs)
 - #151011 (Update books)

r? @ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 12, 2026
@matthiaskrgr
Rollup merge of rust-lang#150723 - move_pal_error, r=@tgross35
fa403e4 
std: move `errno` and related functions into `sys::io`

Part of rust-lang#117276.

Currently, `errno` and related functions like `decode_error_kind` are split across `sys::pal` and `sys::pal::os`. This PR moves all of them into a new module inside `sys::io`.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 12, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of #151038 - matthiaskrgr:rollup-fBdEuCE, r=matthiaskrgr
56cc9e3 
Rollup of 12 pull requests

Successful merges:

 - #145343 (Dogfood `-Zno-embed-metadata` in the standard library)
 - #150151 (Destabilise `target-spec-json`)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150826 (Add `f16` inline ASM support for s390x)
 - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
 - #150943 (Port `#[must_not_suspend]` to attribute parser)
 - #150990 (std: sys: net: uefi: Make TcpStream Send)
 - #150995 (core: ptr: split_at_mut: fix typo in safety doc)
 - #150998 (Relax test expectation for @__llvm_profile_runtime_user)
 - #151002 (Remove a workaround for a bug (take 2))
 - #151005 (Fix typo in `MaybeUninit` docs)
 - #151011 (Update books)

r? @ghost
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 13, 2026

@bors r-
#151038 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

Commit 210c157 has been unapproved.

@joboet
Copy link
Member Author

joboet commented Jan 13, 2026 •
edited
Loading

Ugh, this affects so many things...
@bors r=@tgross35 rollup=iffy

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

📌 Commit 0f25fca has been approved by @tgross35

It is now in the queue for this repository.

@rust-bors

This comment was marked as resolved.

Sign in to view
@joboet
Copy link
Member Author

joboet commented Jan 13, 2026

@bors try jobs=dist-various-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of #150723 - joboet:move_pal_error, r=<try>
a73fa46 
std: move `errno` and related functions into `sys::io`


try-job: dist-various-2
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

☀️ Try build successful (CI)
Build commit: a73fa46 (a73fa46d1758f1a2ea882ce1dc0d09c2cc4a3711, parent: 2f1bd3f3781c90a8447e37d65a898442b8618895)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150723 - move_pal_error, r=@tgross35
4361f72 
std: move `errno` and related functions into `sys::io`

Part of rust-lang#117276.

Currently, `errno` and related functions like `decode_error_kind` are split across `sys::pal` and `sys::pal::os`. This PR moves all of them into a new module inside `sys::io`.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 13, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150723 - move_pal_error, r=@tgross35
0331737 
std: move `errno` and related functions into `sys::io`

Part of rust-lang#117276.

Currently, `errno` and related functions like `decode_error_kind` are split across `sys::pal` and `sys::pal::os`. This PR moves all of them into a new module inside `sys::io`.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 13, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of #151070 - JonathanBrouwer:rollup-hfZvtaP, r=JonathanBro…
2719969 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items)
 - #150677 (Improve std::path::Path::join documentation)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150915 (Regression test for type params on eii)
 - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg)
 - #151017 (Port the rustc dump attributes to the attribute parser)
 - #151019 (Make `Type::of` support unsized types)
 - #151034 (std: Change UEFI env vars to volatile storage)
 - #151052 (ui: add regression test for macro resolution ICE (issue #150711))
 - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
 - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)

r? @ghost
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 14, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150723 - move_pal_error, r=@tgross35
c35c6aa 
std: move `errno` and related functions into `sys::io`

Part of rust-lang#117276.

Currently, `errno` and related functions like `decode_error_kind` are split across `sys::pal` and `sys::pal::os`. This PR moves all of them into a new module inside `sys::io`.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joboet @rustbot @rust-log-analyzer @tgross35 @matthiaskrgr @JonathanBrouwer