-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Remove the diagnostic lints #150879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove the diagnostic lints #150879
Conversation
…e_diagnostic` throughout the codebase This PR was mostly made by search&replacing
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer The Miri subtree was changed cc @rust-lang/miri Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to the CTFE machinery Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
|
As a nice side effect this will make patching rustc to support bootstrapping from rustc 1.83 and below a tiny bit easier. |
This comment has been minimized.
This comment has been minimized.
7be7f33 to
5889e9e
Compare
|
☔ The latest upstream changes (presumably #150957) made this pull request unmergeable. Please resolve the merge conflicts. |
Removes the
untranslatable_diagnosticanddiagnostic_outside_of_impllintsThese lints are allowed for a while already. Per rust-lang/compiler-team#959, we no longer want to enforce struct diagnostics for all usecases, so this is no longer useful.
r? @Kivooeo
I recommend reviewing commit by commit (also feel free to wait with reviewing until the MCP is accepted)
@rustbot +S-blocked
Blocked by rust-lang/compiler-team#959