Remove special case for `AllowedTargets::CrateLevel` #150930

JonathanBrouwer · 2026-01-10T13:23:25Z

r? @jdonszelmann

rustbot · 2026-01-10T13:23:28Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

jdonszelmann · 2026-01-10T13:33:43Z

r=me on green ci

JonathanBrouwer · 2026-01-10T14:56:20Z

@bors r=jdonszelmann rollup

rust-bors · 2026-01-10T14:56:24Z

📌 Commit da0dda1 has been approved by jdonszelmann

It is now in the queue for this repository.

@jdonszelmann

Remove special case for `AllowedTargets::CrateLevel` r? @jdonszelmann

@jdonszelmann

Remove special case for `AllowedTargets::CrateLevel` r? @jdonszelmann

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150786 (mGCA: Support array expression as direct const arguments) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) r? @ghost

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) - #150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - #150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

@jdonszelmann

Rollup merge of #150930 - crate_level, r=jdonszelmann Remove special case for `AllowedTargets::CrateLevel` r? @jdonszelmann

@ghost

Rollup of 14 pull requests Successful merges: - rust-lang/rust#148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - rust-lang/rust#150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - rust-lang/rust#150668 (Unix implementation for stdio set/take/replace) - rust-lang/rust#150743 (Reword the collect() docs) - rust-lang/rust#150776 (Fix the connect_error test on FreeBSD 15+) - rust-lang/rust#150781 (Use `rand` crate more idiomatically) - rust-lang/rust#150812 (Bump `diesel` to the most recent commit in `cargotest`) - rust-lang/rust#150862 (std: sys: fs: uefi: Implement File::flush) - rust-lang/rust#150873 (Reenable GCC CI download) - rust-lang/rust#150908 (llvm: Update `reliable_f16` configuration for LLVM22) - rust-lang/rust#150918 (std: sys: fs: uefi: Implement File::seek) - rust-lang/rust#150922 (Subscribe myself to attr parsing) - rust-lang/rust#150930 (Remove special case for `AllowedTargets::CrateLevel`) - rust-lang/rust#150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

Mark-Simulacrum · 2026-01-12T14:24:12Z

@rust-timer build 2bd58ff

cc #150957 (comment) (original perf results)

JonathanBrouwer · 2026-01-12T15:17:28Z

Looking at the perf result, could very well be this PR, lets see the results before making any conclusions tho

rust-timer · 2026-01-12T15:44:55Z

Finished benchmarking commit (2bd58ff): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	4
Regressions ❌ (secondary)	0.4%	[0.1%, 1.0%]	17
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	4

Max RSS (memory usage)

Results (primary 1.9%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	2.4%	[2.0%, 2.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.9%, 1.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.227s -> 472.544s (-0.35%)
Artifact size: 391.32 MiB -> 391.32 MiB (-0.00%)

JonathanBrouwer · 2026-01-12T15:49:30Z

I'll see if I can find the reason, otherwise we can revert

JonathanBrouwer · 2026-01-12T15:50:00Z

compiler/rustc_attr_parsing/src/target_checking.rs

        cx: &mut AcceptContext<'_, 'sess, S>,
    ) {
-        Self::check_type(matches!(allowed_targets, AllowedTargets::CrateLevel), target, cx);
+        if allowed_targets.allowed_targets() == &[Target::Crate] {


I'm guessing the allowed_targets call here

JonathanBrouwer · 2026-01-12T17:53:51Z

Should be fixed in github.com/rust-lang/rust/pull/151015
@rustbot label: +perf-regression-triaged

@jdonszelmann

…elmann Fix perf of `check_crate_level` refactor Fixes the perf of #150930 The problem is that `allowed_targets` allocates a `Vec` (also moves a comment around to a move useful place) r? @jdonszelmann

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2026

rustbot assigned jdonszelmann Jan 10, 2026

Remove special case for AllowedTargets::CrateLevel

da0dda1

JonathanBrouwer force-pushed the crate_level branch from f311092 to da0dda1 Compare January 10, 2026 13:27

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2026

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026

Rollup merge of rust-lang#150930 - crate_level, r=jdonszelmann

b6f2eb4

Remove special case for `AllowedTargets::CrateLevel` r? @jdonszelmann

Zalathar mentioned this pull request Jan 11, 2026

[EXPERIMENT] Rollup of 15 pull requests #150948

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026

Rollup merge of rust-lang#150930 - crate_level, r=jdonszelmann

0e33cac

Remove special case for `AllowedTargets::CrateLevel` r? @jdonszelmann

Zalathar mentioned this pull request Jan 11, 2026

Rollup of 14 pull requests #150952

Closed

matthiaskrgr mentioned this pull request Jan 11, 2026

Rollup of 14 pull requests #150957

Merged

rust-bors bot merged commit c6cf1c3 into rust-lang:main Jan 11, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 11, 2026

rust-timer added a commit that referenced this pull request Jan 11, 2026

Unrolled build for #150930

2bd58ff

Rollup merge of #150930 - crate_level, r=jdonszelmann Remove special case for `AllowedTargets::CrateLevel` r? @jdonszelmann

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Jan 12, 2026

JonathanBrouwer commented Jan 12, 2026

View reviewed changes

JonathanBrouwer mentioned this pull request Jan 12, 2026

Fix perf of check_crate_level refactor #151015

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jan 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Remove special case for `AllowedTargets::CrateLevel` #150930

Remove special case for `AllowedTargets::CrateLevel` #150930

JonathanBrouwer commented Jan 10, 2026

Uh oh!

rustbot commented Jan 10, 2026

Uh oh!

jdonszelmann commented Jan 10, 2026

Uh oh!

JonathanBrouwer commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

Uh oh!

Mark-Simulacrum commented Jan 12, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jan 12, 2026

Uh oh!

rust-timer commented Jan 12, 2026

Uh oh!

JonathanBrouwer commented Jan 12, 2026

Uh oh!

JonathanBrouwer Jan 12, 2026

Uh oh!

JonathanBrouwer commented Jan 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Remove special case for AllowedTargets::CrateLevel #150930

Remove special case for AllowedTargets::CrateLevel #150930

Conversation

JonathanBrouwer commented Jan 10, 2026

Uh oh!

rustbot commented Jan 10, 2026

Uh oh!

jdonszelmann commented Jan 10, 2026

Uh oh!

JonathanBrouwer commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

Uh oh!

Mark-Simulacrum commented Jan 12, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jan 12, 2026

Uh oh!

rust-timer commented Jan 12, 2026

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Jan 12, 2026

Uh oh!

JonathanBrouwer Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Remove special case for `AllowedTargets::CrateLevel` #150930

Remove special case for `AllowedTargets::CrateLevel` #150930

JonathanBrouwer commented Jan 12, 2026 •

edited

Loading