Rollup of 8 pull requests #151003
Merged
Rollup of 8 pull requests #151003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c grouping
Detect Python-style numeric grouping syntax in format strings (e.g. `{x:,}`)
and emit a clear diagnostic explaining that it is not supported in Rust.
This helps users coming from Python understand the error without exposing
the full set of valid Rust format specifiers.
Signed-off-by: Usman Akinyemi <[email protected]>
Because these folders only change regions. Note: `BottomUpFolder` folds all regions, while `fold_regions` skips some bound regions. But that's ok because these two folders only modify `ReVar`s.
The exact same call appears earlier in this function.
The only thing we do with the result is consult the `.def_id` field, which is unaffected by `erase_and_anonymize_regions`.
- Remove the vacuous `Types`, which provides extremely little value. - Make sure `src` comes before `dst` in all transmute-related functions. (Currently it's a mix: sometimes `src` is first, sometimes it is second`.)
It duplicates `has_erased_regions` from the compiler.
The read and read_vectored methods were returning the length of the input buffer, rather than the number of bytes actually read. Fix by changing read_inner to return the correct value, and have both read and read_vectored return that.
Folding/`ReErased` cleanups Various cleanups I found while reading this code closely, mostly involving folding and the use of `ReErased`. r? @lcnr
Emit error instead of delayed bug when meeting mismatch type for const tuple And rename some tests Fixes rust-lang#150841 r? @BoxyUwU
Use a hook to decouple `rustc_mir_transform` from `rustc_mir_build` I noticed that the only point of direct contact between the `rustc_mir_transform` and `rustc_mir_build` crates is a single `build_mir` function, which could easily be changed to a hook function instead. By making that function a hook, we can make `rustc_mir_transform` no longer have a dependency on `rustc_mir_build`, allowing them to be built/rebuilt independently. That should hopefully allow slightly more parallelism in clean builds and incremental rebuilds of the compiler.
rustc_parse_format: improve diagnostics for unsupported python numeric grouping
Detect Python-style numeric grouping syntax in format strings (e.g. `{x:,}`)
and emit a clear diagnostic explaining that it is not supported in Rust.
This helps users coming from Python understand the error without exposing
the full set of valid Rust format specifiers.
Rename EII attributes slightly (being consistent in naming things foreign items, not extern items) r? @Kivooeo
Use updated indexes to build reverse map for delegation generics Fixes rust-lang#150673. This was a bug that built the `param_def_id_to_index` map with indexes before the new generics were renumbered. r? @petrochenkov
std: Fix size returned by UEFI tcp4 read operations The read and read_vectored methods were returning the length of the input buffer, rather than the number of bytes actually read. Fix by changing read_inner to return the correct value, and have both read and read_vectored return that.
Remove `S-waiting-on-bors` after a PR is merged I just noticed that we have 50k+ PRs marked as waiting on bors, even though they have been merged, lol.
rustbot
added
A-attributes
rustbot
added
T-rust-analyzer
Member
Author
|
@bors r+ rollup=never p=5 |
rust-bors
bot
added
the
S-waiting-on-bors
Contributor
rust-bors
bot
removed
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
Rollup of 8 pull requests Successful merges: - #150861 (Folding/`ReErased` cleanups) - #150869 (Emit error instead of delayed bug when meeting mismatch type for const tuple) - #150920 (Use a hook to decouple `rustc_mir_transform` from `rustc_mir_build`) - #150941 (rustc_parse_format: improve diagnostics for unsupported python numeric grouping) - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) - #150980 (Use updated indexes to build reverse map for delegation generics) - #150986 (std: Fix size returned by UEFI tcp4 read operations) - #150996 (Remove `S-waiting-on-bors` after a PR is merged) r? @ghost
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for b53b0fa failed: CI. Failed jobs:
|
Member
Author
|
@bors retry |
rust-bors
bot
added
S-waiting-on-bors
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 137716908d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 1377169 (parent) -> aefa104 (this PR) Test differencesShow 38 test diffsStage 0
Stage 1
Stage 2
Additionally, 14 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard aefa10405d7b67b3780027484cb02c85d3a3bf36 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Jan 12, 2026
Collaborator
|
Finished benchmarking commit (aefa104): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.493s -> 474.371s (0.19%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ReErasedcleanups #150861 (Folding/ReErasedcleanups)rustc_mir_transformfromrustc_mir_build#150920 (Use a hook to decouplerustc_mir_transformfromrustc_mir_build)S-waiting-on-borsafter a PR is merged #150996 (RemoveS-waiting-on-borsafter a PR is merged)r? @ghost
Create a similar rollup