Rollup of 13 pull requests #151086
Closed
Rollup of 13 pull requests #151086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a trait parameter depends upon Sized, the error message only referred to the full trait itself and didn't mention Sized. This makes the failure to implement Sized explicit. It also notes when the Sized trait bound is explicit or implicit.
I chose to simply extend `dump.rs`, rather than create a new UI test.
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs Fix to comply with tidy Remove unnecessary whitespace
With the suggested value we were getting instead: ``` ERROR: Failed to parse '/tmp/rust/bootstrap.toml': unknown field `stage`, expected one of `build`, `description`, `host`, `target`, `build-dir`, `cargo`, `rustc`, `rustfmt`, `cargo-clippy`, `docs`, `compiler-docs`, `library-docs-private-items`, `docs-minification`, `submodules`, `gdb`, `lldb`, `nodejs`, `npm`, `yarn`, `python`, `windows-rc`, `reuse`, `locked-deps`, `vendor`, `full-bootstrap`, `bootstrap-cache-path`, `extended`, `tools`, `tool`, `verbose`, `sanitizers`, `profiler`, `cargo-native-static`, `low-priority`, `configure-args`, `local-rebuild`, `print-step-timings`, `print-step-rusage`, `check-stage`, `doc-stage`, `build-stage`, `test-stage`, `install-stage`, `dist-stage`, `bench-stage`, `patch-binaries-for-nix`, `metrics`, `android-ndk`, `optimized-compiler-builtins`, `jobs`, `compiletest-diff-tool`, `compiletest-allow-stage0`, `compiletest-use-stage0-libtest`, `tidy-extra-checks`, `ccache`, `exclude` for key `build` ```
The old toolchain is not working with recent rustc, as it does not defining `getauxval`
triagebot: add A-rustdoc-js autolabel Adds an autolabel rule for rustdoc JavaScript/TypeScript files so PRs touching rustdoc frontend assets and related tests are automatically labeled `A-rustdoc-js`. Fixes rust-lang#137983
Improve std::path::Path::join documentation Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs rust-lang#146447
diagnostics: make implicit Sized bounds explicit in E0277 When a trait parameter depends upon Sized, the error message only referred to the full trait itself and didn't mention Sized. This makes the failure to implement Sized explicit. It also notes when the Sized trait bound is explicit or implicit. Fixes rust-lang#150576
Remove legacy homu `try` and `auto` branch mentions ~~To be merged once we get rid of homu.~~ I think that we can merge this now.
…nethercote Make `--print=check-cfg` output compatible `--check-cfg` arguments This PR changes significantly the output of the unstable `--print=check-cfg` option. Specifically it removes the ad-hoc resemblance with `--print=cfg` in order to output a simplified but still compatible `--check-cfg` arguments. The goal is to future proof the output of `--print=check-cfg` like `--check-cfg` is, and the best way to do that is to use it's syntax. This is particularly relevant for [RFC3905](rust-lang/rfcs#3905) which wants to introduce a new predicate: `version(...)`.
Regression test for type params on eii Somewhere along the line I fixed this one with my other PRs. This just adds the regression tests Closes rust-lang#149983
Port the rustc dump attributes to the attribute parser Tracking issue has been updated: rust-lang#131229 Five easy ones r? @jdonszelmann
Make `Type::of` support unsized types Tracking issue: rust-lang#146922 Fixes rust-lang#151018 `Type::of` is a utility function for getting type reflection information, and internally just calls `TypeId::of::<T>().info()`. `Type::of` does not support unsized types like `str` and `[u8]` because it is missing a `?Sized` bound. I believe this is an oversight rather than an intentional decision, as `TypeId::of` _does_ support unsized types and `Type::size` is an `Option` to support types without sizes. This PR adds a `?Sized` bound to `Type::of` and extends the `dump.rs` test to ensure unsized types work in the future. r? @oli-obk
Support arrays in type reflection Tracking issue: rust-lang#146922 This PR adds support for inspecting arrays `[T; N]` through type reflection. It does so by adding `TypeKind::Array` and the `Array` struct: ```rust pub struct Array { pub element_ty: TypeId, pub len: usize, } ``` This can be used to inspect arrays like so: ```rust match const { Type::of::<[u16; 4]>() }.kind { TypeKind::Array(array) => { assert_eq!(array.element_ty, TypeId::of::<u16>()); assert_eq!(array.len, 4); } _ => unreachable!(), } ``` r? @oli-obk
armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syntax With the suggested value we were getting instead: ``` ERROR: Failed to parse '/tmp/rust/bootstrap.toml': unknown field `stage`, expected one of `build`, `description`, `host`, `target`, `build-dir`, `cargo`, `rustc`, `rustfmt`, `cargo-clippy`, `docs`, `compiler-docs`, `library-docs-private-items`, `docs-minification`, `submodules`, `gdb`, `lldb`, `nodejs`, `npm`, `yarn`, `python`, `windows-rc`, `reuse`, `locked-deps`, `vendor`, `full-bootstrap`, `bootstrap-cache-path`, `extended`, `tools`, `tool`, `verbose`, `sanitizers`, `profiler`, `cargo-native-static`, `low-priority`, `configure-args`, `local-rebuild`, `print-step-timings`, `print-step-rusage`, `check-stage`, `doc-stage`, `build-stage`, `test-stage`, `install-stage`, `dist-stage`, `bench-stage`, `patch-binaries-for-nix`, `metrics`, `android-ndk`, `optimized-compiler-builtins`, `jobs`, `compiletest-diff-tool`, `compiletest-allow-stage0`, `compiletest-use-stage0-libtest`, `tidy-extra-checks`, `ccache`, `exclude` for key `build` ```
ui: add regression test for macro resolution ICE (issue rust-lang#150711) Added a new test in `test/ui/resolve` for a macro resolution scenario that previously caused an ICE. Files added: - `tests/ui/resolve/decl-macro-use-no-ice.rs` - `tests/ui/resolve/decl-macro-use-no-ice.stderr` Fixes rust-lang#150711 r? @matthiaskrgr r? @petrochenkov
Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml` Fixes rust-lang#151006 (hopefully). Instead of asserting right away, it waits for the element count to be the one expected. r? @jieyouxu
Emit error instead of delayed bug when meeting mismatch type for const array r? BoxyUwU resolve: rust-lang#151024 cc: rust-lang#150869
rustbot
added
A-attributes
Member
|
🤔 Isn’t this a duplicate of rollup #151087 you also opened? |
Member
Author
|
O.o I'm very confused and even closed the other while I didn't intend to. >< No clue what happened here. Seems like a bug in bors no? @bors r+ p=5 rollup=never |
rust-bors
bot
added
the
S-waiting-on-bors
Contributor
rust-bors
bot
removed
the
S-waiting-on-review
Member
Author
|
Ah wait no, I can restore stuff. I'm very lost... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tryandautobranch mentions #150771 (Remove legacy homutryandautobranch mentions)--print=check-cfgoutput compatible--check-cfgarguments #150840 (Make--print=check-cfgoutput compatible--check-cfgarguments)Type::ofsupport unsized types #151019 (MakeType::ofsupport unsized types)tests/rustdoc-gui/notable-trait.goml#151053 (Reduce flakyness fortests/rustdoc-gui/notable-trait.goml)r? @ghost
Create a similar rollup