Generate macro expansion for rust compiler crates docs #151092
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Member
|
Unfortunately it seems to still ICE :( EDIT: oh, that's against the beta rustdoc. Do we need to wait until the next release when nightly rustdoc gets promoted to beta? |
jieyouxu
added
S-waiting-on-author
Member
Author
|
Oh a new bug. Perfect! =D |
Member
Author
Wait really? That's super weird. Let me check a bit if I can reproduce locally. |
Member
Author
|
I can reproduce locally so I think we found a new bug, perfect. =D |
Member
Author
|
Just checked locally and rediscovered that stage 1 compiler docs uses beta rustdoc. So stage 2 works just fine. Well, nothing else to be done except waiting for new release (which is in less than 2 weeks so it's fine 😄). |
jieyouxu
added
S-blocked
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
generate-macro-expansion-compiler-crates-docs
branch
from
b545b49 to
e79792c
Compare
Member
Author
|
CI passed! \o/ Thanks a lot @bjorn3 for the idea! |
bjorn3
reviewed
Jan 15, 2026
jieyouxu
added
S-waiting-on-review
GuillaumeGomez
force-pushed
the
generate-macro-expansion-compiler-crates-docs
branch
from
e79792c to
0f0abc1
Compare
This comment has been minimized.
This comment has been minimized.
…lds higher than 1
GuillaumeGomez
force-pushed
the
generate-macro-expansion-compiler-crates-docs
branch
from
0f0abc1 to
7544563
Compare
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Member
|
@bors rollup=iffy |
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for f8a2d31 failed: CI. Failed job:
|
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
Flaky. @bors retry |
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 17, 2026
Rollup of 5 pull requests Successful merges: - #151092 (Generate macro expansion for rust compiler crates docs) - #151120 (Fix deprecated attribute intra-doc link not resolved in the right location on reexported item) - #151207 (Preliminary match/capture test cleanup for PR 150681) - #151221 (Reorganizing `tests/ui/issues` 5 tests [1/N]) - #151222 (feat: Support references in reflection type info) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 17, 2026
GuillaumeGomez
deleted the
generate-macro-expansion-compiler-crates-docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable #150022, which was disabled in #149831 because some fixes hadn't been merged then.
r? @jieyouxu