resolve: Downgrade ambiguous_glob_imports to warn-by-default
#151130
Merged
+188
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
Member
|
The plan described in that comment looks good and will help smooth over the diesel transition. r? me @bors r+ |
rust-bors
bot
added
S-waiting-on-bors
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 14, 2026
resolve: Downgrade `ambiguous_glob_imports` to warn-by-default But still keep it report-in-deps, as decided in rust-lang#149845 (comment). This will need to be reverted after ~February 27 2026, when Rust 1.95 branches out from the main branch. Closes rust-lang#149845.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
…uwer Rollup of 16 pull requests Successful merges: - #150585 (Add a context-consistency check before emitting redundant generic-argument suggestions) - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - #150590 (Don't try to recover keyword as non-keyword identifier ) - #150817 (cleanup: remove borrowck handling for inline const patterns) - #150939 (resolve: Relax some asserts in glob overwriting and add tests) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #150966 (rustc_target: Remove unused Arch::PowerPC64LE) - #150971 (Disallow eii in statement position) - #151016 (fix: WASI threading regression by disabling pthread usage) - #151046 (compiler: Make Externally Implementable Item (eii) macros "semiopaque") - #151099 (Recover parse gracefully from `<const N>`) - #151117 (Avoid serde dependency in build_helper when not necessary) - #151127 (Delete `MetaItemOrLitParser::Err`) - #151128 (Add temporary new bors e-mail address to the mailmap) - #151130 (resolve: Downgrade `ambiguous_glob_imports` to warn-by-default) - #151138 (Rename `rust.use-lld` to `rust.bootstrap-override-lld` in INSTALL.md) r? @ghost
Contributor
rust-bors
bot
added
S-waiting-on-author
Contributor
|
Commit ff3bf0f has been unapproved. |
Contributor
|
Soft conflict with https://github.com/rust-lang/rust/pull/150939/changes, rebase on that after that merges |
But still keep it report-in-deps. To revert after ~February 27 2026, when Rust 1.95 branches out from the main branch.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=lqd |
rust-bors
bot
added
S-waiting-on-bors
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
Rollup of 4 pull requests Successful merges: - #150846 (include `HirId`s directly in the THIR, not wrapped in `LintLevel`s) - #150979 (Avoid ICEs after bad patterns, for the other syntactic variants) - #151103 (mir_build: Simplify length-determination and indexing for array/slice patterns) - #151130 (resolve: Downgrade `ambiguous_glob_imports` to warn-by-default) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 15, 2026
Rollup merge of #151130 - diesel2, r=lqd resolve: Downgrade `ambiguous_glob_imports` to warn-by-default But still keep it report-in-deps, as decided in #149845 (comment). This will need to be reverted after ~February 27 2026, when Rust 1.95 branches out from the main branch. Closes #149845.
Contributor
Author
|
Looks like the milestone both here and in #147984 is 1.94.0, so backport is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But still keep it report-in-deps, as decided in #149845 (comment).
This will need to be reverted after ~February 27 2026, when Rust 1.95 branches out from the main branch.
Closes #149845.