Skip to content

Revert "avoid phi node for pointers flowing into Vec appends #130998" #151150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 15, 2026
Merged

Revert "avoid phi node for pointers flowing into Vec appends #130998" #151150

rust-bors merged 1 commit into from
Jan 15, 2026

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jan 15, 2026 •
edited by Zalathar
Loading

This reverts PR #130998 because the added test seems to be flaky / non-deterministic, and has been failing in unrelated PRs during merge CI:

See also #t-infra > Tree ops.

Note

This is a "fallback" PR in case the FileCheck failure isn't obvious (i.e. fix-forward). This PR reverts #130998 wholesale in case the failure is genuine and indicative of a bug in the actual implementation change.

@jieyouxu
Revert "avoid phi node for pointers flowing into Vec appends rust-lan…
cd79ff2 
…g#130998"

This reverts PR <rust-lang#130998> because
the added test seems to be flaky / non-deterministic, and has been
failing in unrelated PRs during merge CI.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 15, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@Zalathar
Copy link
Member

Zalathar commented Jan 15, 2026

The original PR is small and self-contained enough that I think we should just revert ASAP and ask questions later.

r=me if you want to fast-track this.

@Zalathar
Copy link
Member

Zalathar commented Jan 15, 2026

The reverted PR has known perf effects.

@bors rollup=never

@Zalathar
Copy link
Member

Zalathar commented Jan 15, 2026

@bors r+ p=10

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 15, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

📌 Commit cd79ff2 has been approved by Zalathar

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2026
@Zalathar
Copy link
Member

Zalathar commented Jan 15, 2026

r? me

@rustbot rustbot assigned Zalathar and unassigned joboet Jan 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 15, 2026
@bors
Auto merge of #151150 - jieyouxu:revert-vec-append, r=Zalathar
f9ac04b 
Revert "avoid phi node for pointers flowing into Vec appends #130998"

This reverts PR #130998 because the added test seems to be flaky / non-deterministic, and has been failing in unrelated PRs during merge CI:

- #151129 (comment)
- #150772 (comment)
- #150925 (comment)

See also [#t-infra > Tree ops](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/with/568111767).

> [!NOTE]
>
> This is a "fallback" PR in case the FileCheck failure isn't obvious (i.e. fix-forward). This PR reverts #130998 wholesale in case the failure is genuine and indicative of a bug in the actual implementation change.
@jieyouxu
Copy link
Member Author

jieyouxu commented Jan 15, 2026

FYI @the8472

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 15, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
............................................       (144/144)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 254
    at `tests/rustdoc-gui/utils.goml` line 34: Error: The following CSS properties still don't match: [expected `block` for key `display`, found `none`]: for command `wait-for-css: ("#settings", {"display": "block"})`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

💔 Test for f9ac04b failed: CI. Failed jobs:

@Zalathar
Copy link
Member

Zalathar commented Jan 15, 2026

I'm going to try making a dedicated rollup containing this revert and #151145, so that they can stop breaking each other.

@bors r+ rollup=iffy

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 15, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

📌 Commit cd79ff2 has been approved by Zalathar

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2026
@Zalathar
Copy link
Member

Zalathar commented Jan 15, 2026

@bors r-

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 15, 2026
@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 15, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

Commit cd79ff2 has been unapproved.

@Zalathar
Copy link
Member

Zalathar commented Jan 15, 2026

@bors r+

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 15, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

📌 Commit cd79ff2 has been approved by Zalathar

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 15, 2026
@Zalathar Zalathar mentioned this pull request Jan 15, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 15, 2026
@bors
Auto merge of #151151 - Zalathar:rollup-kAQYrsB, r=Zalathar
c9af9c1 
Rollup of 2 pull requests

Successful merges:

 - #151150 (Revert "avoid phi node for pointers flowing into Vec appends #130998")
 - #151145 (Reduce rustdoc GUI flakyness, take 2)

r? @ghost
@rust-bors rust-bors bot merged commit 11b0079 into rust-lang:main Jan 15, 2026
11 of 12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 15, 2026
rust-timer added a commit that referenced this pull request Jan 15, 2026
@rust-timer
Unrolled build for #151150
37a6660 
Rollup merge of #151150 - revert-vec-append, r=Zalathar

Revert "avoid phi node for pointers flowing into Vec appends #130998"

This reverts PR #130998 because the added test seems to be flaky / non-deterministic, and has been failing in unrelated PRs during merge CI:

- #151129 (comment)
- #150772 (comment)
- #150925 (comment)
- #151145 (comment)

See also [#t-infra > Tree ops](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/with/568111767).

> [!NOTE]
>
> This is a "fallback" PR in case the FileCheck failure isn't obvious (i.e. fix-forward). This PR reverts #130998 wholesale in case the failure is genuine and indicative of a bug in the actual implementation change.
@jieyouxu jieyouxu deleted the revert-vec-append branch January 15, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Zalathar Zalathar

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jieyouxu @rustbot @Zalathar @rust-log-analyzer @joboet