Skip to content

feat: Support references in reflection type info #151222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 17, 2026
Merged

feat: Support references in reflection type info #151222

rust-bors merged 1 commit into from
Jan 17, 2026

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 16, 2026 •
edited
Loading

Tracking issue: #146922 #![feature(type_info)]

Based on #151119 implementation for pointers for consistency

r? oli-obk

@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2026

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

The reflection data structures are tied exactly to the implementation
in the compiler. Make sure to also adjust rustc_const_eval/src/const_eval/type_info.rs

cc @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2026

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

@clubby789 clubby789 added the F-type_info #![feature(type_info)] label Jan 16, 2026
@SpriteOvO SpriteOvO added the A-type-system Area: Type system label Jan 16, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

oli-obk
oli-obk reviewed Jan 16, 2026
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Jan 16, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 16, 2026

📌 Commit a23d2ba has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2026
SpriteOvO
SpriteOvO requested changes Jan 17, 2026
View reviewed changes
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@clubby789
Copy link
Contributor Author

clubby789 commented Jan 17, 2026

@bors r-

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 17, 2026

Commit a23d2ba has been unapproved.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 17, 2026
@clubby789
Copy link
Contributor Author

clubby789 commented Jan 17, 2026

@bors r=oli-obk rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 17, 2026

📌 Commit c7031e9 has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2026
@Zalathar Zalathar mentioned this pull request Jan 17, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 17, 2026
@bors
Auto merge of #151234 - Zalathar:rollup-mtOIaDC, r=Zalathar
defdb83 
Rollup of 5 pull requests

Successful merges:

 - #151092 (Generate macro expansion for rust compiler crates docs)
 - #151120 (Fix deprecated attribute intra-doc link not resolved in the right location on reexported item)
 - #151207 (Preliminary match/capture test cleanup for PR 150681)
 - #151221 (Reorganizing `tests/ui/issues` 5 tests [1/N])
 - #151222 (feat: Support references in reflection type info)

r? @ghost
@rust-bors rust-bors bot merged commit 2956932 into rust-lang:main Jan 17, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 17, 2026
@rust-timer
Unrolled build for #151222
f1e0546 
Rollup merge of #151222 - reflect-references, r=oli-obk

feat: Support references in reflection type info

Tracking issue: #146922 `#![feature(type_info)]`

Based on #151119 implementation for pointers for consistency

r? oli-obk
@rustbot rustbot added this to the 1.94.0 milestone Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

@SpriteOvO SpriteOvO SpriteOvO requested changes

Assignees

@oli-obk oli-obk

Labels

A-type-system Area: Type system F-type_info #![feature(type_info)] S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@clubby789 @rustbot @oli-obk @SpriteOvO @jamie-osec