Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost

Create a similar rollup

aerooneqq and others added 18 commits January 20, 2026 11:32
Since LLVM 22 the alloca must be passed directly. Do this by
stripping the addrspacecast if it exists.
As Intel has walked back on the existence of AVX 10.1-256, LLVM
no longer uses evex512 and avx-10.n-512 are now avx-10.n instead,
so we can skip all the special handling on LLVM 22.
…inarycat

[rustdoc] Make popover menus content scrollable on mobile devices

Fixes rust-lang#151209.

This is what it looks like:

<img width="468" height="601" alt="image" src="https://github.com/user-attachments/assets/39dcbfea-ca31-4875-947f-155b58ffa4bd" />

The only difference with the current display:

<img width="468" height="601" alt="image" src="https://github.com/user-attachments/assets/b49c6100-3566-4f79-8343-1bf4fe32da78" />

is that we now see the bottom border (and that we can scroll the content too of course).

I applied this change to both the settings and helps popover menus.

r? @lolbinarycat
Fix an ICE on transmute goals with placeholders in `param_env`

Fixes rust-lang#151300

The next solver short-circuits `consider_builtin_transmute_candidate` when the goal contains non-region placeholders, since `rustc_transmute` does not support type parameters.
However, this check should likely be refined to apply only to the predicate itself: excess bounds with type params in the param env can cause the goal to be rejected even when its predicate trivially holds.

r? types
…chenkov

Generate error delegation when delegation is not resolved

This PR is a part of the delegation feature rust-lang#118212 and fixes rust-lang#151356.

r? @petrochenkov
Use version 1.93.0 in `RELEASES.md` instead of 1.93
Fixes for LLVM 22 compatibility

This includes three fixes for LLVM 22 compatibility:

 * Update the AMDGPU data layout.
 * Update AVX512 target feature handling. `evex512` is no longer used and `avx10.[12]-512` are now just `avx10.[12]`, matching the Rust feature name.
 * Strip address space casts when emitting lifetime intrinsics. These are now required to directly work on the alloca.

r? @cuviper
chore: Remove redundant conversion

The type of `code` is `u32`, so this `u32::from` is not necessary.
Avoid pulling in unicode when calling io::Error::kind

Reduces binary size by ~1KB.
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Jan 20, 2026
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 20, 2026
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=5 rollup=never

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 20, 2026

📌 Commit 3682ed7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 21, 2026

☀️ Test successful - CI
Approved by: GuillaumeGomez
Duration: 3h 16m
Pushing af6695c to main...

@rust-bors rust-bors bot merged commit af6695c into rust-lang:main Jan 21, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 21, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#151216 [rustdoc] Make popover menus content scrollable on mobile d… 7455076bc0834aa66f4160502028ddab9fb28b67 (link)
#151373 Fix an ICE on transmute goals with placeholders in `param_e… f1204cfbe5a5af61d65de7bc914722e0115c0da4 (link)
#151399 Generate error delegation when delegation is not resolved f3207d29b84248c90b2b7e6f5ef3ae7d207fdc54 (link)
#151406 Use version 1.93.0 in RELEASES.md instead of 1.93 6e8890ea9843725359a9c51f4134c561bc751349 (link)
#151410 Fixes for LLVM 22 compatibility 470bcbe805cf2ad88417853e67e49e189ca5d2d6 (link)
#151415 chore: Remove redundant conversion f68fe2782f2ad48e4e24d272d111db92e0e8f932 (link)
#151418 Avoid pulling in unicode when calling io::Error::kind 8b9b6f2d8758e2ab2d96231960e05f21f72bd193 (link)

previous master: 5c49c4f7c8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5c49c4f (parent) -> af6695c (this PR)

Test differences

Show 19 test diffs

Stage 1

  • [ui] tests/ui/delegation/unresolved-delegation-ice-151356.rs: [missing] -> pass (J3)
  • [ui] tests/ui/transmutability/transmute-with-type-params.rs#current: [missing] -> pass (J3)
  • [ui] tests/ui/transmutability/transmute-with-type-params.rs#next: [missing] -> pass (J3)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM22: [missing] -> ignore (ignored when the LLVM version 21.1.8 is older than 22.0.0) (J4)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM22: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J5)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs: pass -> [missing] (J6)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM21: [missing] -> pass (J6)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM22: [missing] -> ignore (ignored when the LLVM version 20.1.2 is older than 22.0.0) (J9)

Stage 2

  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs: pass -> [missing] (J0)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM21: [missing] -> pass (J0)
  • [ui] tests/ui/delegation/unresolved-delegation-ice-151356.rs: [missing] -> pass (J1)
  • [ui] tests/ui/transmutability/transmute-with-type-params.rs#current: [missing] -> pass (J1)
  • [ui] tests/ui/transmutability/transmute-with-type-params.rs#next: [missing] -> pass (J1)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM22: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J2)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM22: [missing] -> ignore (ignored when the LLVM version 20.1.2 is older than 22.0.0) (J7)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM22: [missing] -> ignore (ignored when the LLVM version 21.1.8 is older than 22.0.0) (J8)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM22: [missing] -> ignore (ignored when the LLVM version 20.1.8 is older than 22.0.0) (J10)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard af6695c1142706c7a0718431f49057fa52e4c33f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 13242.2s -> 8398.3s (-36.6%)
  2. x86_64-gnu-distcheck: 8456.9s -> 7501.1s (-11.3%)
  3. x86_64-gnu-llvm-20-3: 7393.9s -> 6577.1s (-11.0%)
  4. x86_64-gnu-llvm-20: 4839.5s -> 4333.3s (-10.5%)
  5. dist-i586-gnu-i586-i686-musl: 5364.1s -> 4896.2s (-8.7%)
  6. x86_64-gnu-llvm-20-1: 4563.6s -> 4172.2s (-8.6%)
  7. i686-msvc-1: 10667.0s -> 9778.3s (-8.3%)
  8. dist-x86_64-llvm-mingw: 6618.5s -> 7160.2s (+8.2%)
  9. aarch64-msvc-2: 6238.6s -> 5747.0s (-7.9%)
  10. x86_64-gnu-debug: 7317.2s -> 6774.6s (-7.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (af6695c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.7% [2.7%, 4.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -0.6%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.2%] 2
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.574s -> 475.177s (0.13%)
Artifact size: 383.32 MiB -> 383.25 MiB (-0.02%)

@GuillaumeGomez GuillaumeGomez deleted the rollup-HAeLPDZ branch January 21, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-js Area: Rustdoc's JS front-end merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants