-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Cleanup offload datatransfer #151640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cleanup offload datatransfer #151640
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d9def93 to
4f29cbe
Compare
This comment has been minimized.
This comment has been minimized.
014d61d to
6b45680
Compare
|
I don't think jieyouxu will want to review this part of rustc. |
|
|
This comment has been minimized.
This comment has been minimized.
6b45680 to
1c28bd8
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
1c28bd8 to
c310bf7
Compare
c310bf7 to
b2b51e4
Compare
|
@rustbot reroll |
b2b51e4 to
3fb0092
Compare
3fb0092 to
446bd1d
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
spurious failure, cc @jieyouxu |
There are 3 steps to run code on a GPU: Copy data from the host to the device, launch the kernel, and move it back.
At the moment, we have a single variable describing the memory handling to do in each step, but that makes it hard for LLVM's opt pass to understand what's going on. We therefore split it into three variables, each only including the bits relevant for the corresponding stage.
cc @jdoerfert @kevinsala
r? compiler