Fix flakyness issue with tests/rustdoc-gui/globals.goml test
#151836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 29, 2026
…r=GuillaumeGomez Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test Part of rust-lang#93784. It fixes this error: ``` [ERROR] line 14: The following errors happened: [Property named `"searchIndex"` doesn't exist]: for command `assert-window-property-false: {"searchIndex": null}` at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo> ``` r? ghost
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
…uwer Rollup of 4 pull requests Successful merges: - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`) - #151811 (Fix false positive in unused_parens caused by break) - #151817 (Fix missing syntax context in lifetime hygiene debug output) - #151836 (Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test)
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
…uwer Rollup of 4 pull requests Successful merges: - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`) - #151811 (Fix false positive in unused_parens caused by break) - #151817 (Fix missing syntax context in lifetime hygiene debug output) - #151836 (Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 30, 2026
…r=GuillaumeGomez Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test Part of rust-lang#93784. It fixes this error: ``` [ERROR] line 14: The following errors happened: [Property named `"searchIndex"` doesn't exist]: for command `assert-window-property-false: {"searchIndex": null}` at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo> ``` r? ghost
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
Rollup of 6 pull requests Successful merges: - #151777 ( Reduce generics use in the query system.) - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`) - #151811 (Fix false positive in unused_parens caused by break) - #151817 (Fix missing syntax context in lifetime hygiene debug output) - #151836 (Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test) - #151844 (rustc-dev-guide subtree update)
Member
|
Failed in rollup: #151847 (comment) Not sure whether that's from a bug in this PR, or a separate source of flakiness. @bors r- |
rust-bors
bot
added
S-waiting-on-author
Contributor
Member
|
@bors try jobs=x86_64-gnu-tools |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test try-job: x86_64-gnu-tools
Contributor
Member
Author
|
Nah, it was trying to fix this flakyness. It failed. ^^' Closing then. |
rustbot
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #93784.
It fixes this error:
r? ghost