Rollup of 5 pull requests #151852

Zalathar · 2026-01-30T06:41:09Z

Successful merges:

Reduce generics use in the query system. #151777 ( Reduce generics use in the query system.)
Document a safety condition for TypedArena::alloc_raw_slice #151808 (Document a safety condition for TypedArena::alloc_raw_slice)
Fix false positive in unused_parens caused by break #151811 (Fix false positive in unused_parens caused by break)
Fix missing syntax context in lifetime hygiene debug output #151817 (Fix missing syntax context in lifetime hygiene debug output)
rustc-dev-guide subtree update #151844 (rustc-dev-guide subtree update)

This updates the rust-version file to 5c49c4f.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@5c49c4f Filtered ref: rust-lang/rustc-dev-guide@866efc3 Upstream diff: rust-lang/rust@44a5b55...5c49c4f This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

@BoxyUwU

r? @BoxyUwU

coercions.md: add date-check marker

Co-authored-by: Yuki Okushi <[email protected]>

Document experimental RFC process in walkthrough

…ting-docs Add a new subsection for contributors

Add info about unused_attributes

This updates the rust-version file to 873d468.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@873d468 Filtered ref: rust-lang/rustc-dev-guide@94e6e4f Upstream diff: rust-lang/rust@5c49c4f...873d468 This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

This updates the rust-version file to 0462e8f.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@0462e8f Filtered ref: rust-lang/rustc-dev-guide@a136707 Upstream diff: rust-lang/rust@873d468...0462e8f This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

Add missing autodiff run-make tests to the install docs

Refer to debug-logging bootstrap config by its full path.

sembr

`QueryStackFrame` is a generic type, and the `I` parameter leaks out to many other related types. However, it only has two instantiations in practice: - `QueryStackFrame<QueryStackFrameExtra>` - `QueryStackFrame<QueryStackDeferred<'tcx>>` And most of the places that currently use `QueryStackFrame` are actually specific to one of the instantiations. This commit removes the unneeded genericity. The following types are only ever used with `QueryStackDeferred<'tcx>`: - QueryMap - QueryJobInfo - QueryJob - QueryWaiter - QueryLatchInfo - QueryLatch - QueryState - QueryResult and their `` parameter is changed to `<'tcx>`. Also, the `QueryContext::QueryInfo` associated type is removed. `CycleError` and `QueryInfo` are still generic over type, because they are used with both instantiations. This required also adding a `<'tcx>` parameter to the traits `QueryDispatcher` and `QueryContext`, which is annoying but I can't see how to avoid it.

@oli-obk

…ercote Reduce generics use in the query system. In rust-lang#151203 I tried and failed to simplify `QueryStackFrame`. This is an alternative approach. There is no functional change, just tweaking of some names and types to make things clearer. Best reviewed one commit at a time. r? @oli-obk

Document a safety condition for `TypedArena::alloc_raw_slice` This method was marked safe in rust-lang@51edc21, because there was no apparent reason for it to be unsafe. However, I believe that `alloc_raw_slice` does actually impose a significant safety obligation on its caller, because the caller must ensure that each slot in the slice is properly initialized before the arena is dropped. This is because the arena's Drop impl will unconditionally drop every storage slot that has been handed out, so it has no way to handle slots that were accidentally left uninitialized because a hypothetical caller of `alloc_raw_slice` panicked before initializing them.

…d-parens-labeled-loops, r=Kivooeo Fix false positive in unused_parens caused by break Fixes rust-lang#143256

…e, r=jdonszelmann Fix missing syntax context in lifetime hygiene debug output `-Zunpretty=expanded,hygiene` was not printing the syntax context for lifetimes. For example, two macro-generated lifetimes `'a` with different hygiene would both print as `/* 2538 */` instead of `/* 2538#0 */` and `/* 2538#1 */`, making it impossible to distinguish them. This was fixed by changing `print_lifetime` to call `ann_post()` with the full `Ident`, matching how regular identifiers are handled in `print_ident`. Closes: rust-lang#151797

@ghost

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@e03697d. Created using https://github.com/rust-lang/josh-sync. r? @ghost

Zalathar · 2026-01-30T06:41:23Z

Rollup of everything.

@bors r+ rollup=never p=5

rust-bors · 2026-01-30T06:41:26Z

📌 Commit 5b54208 has been approved by Zalathar

It is now in the queue for this repository.

rust-bors · 2026-01-30T09:50:21Z

☀️ Test successful - CI
Approved by: Zalathar
Duration: 3h 8m 24s
Pushing 7d8ebe3 to main...

rust-timer · 2026-01-30T09:51:49Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#151777	Reduce generics use in the query system.	`b1aba3c8defebd8b4fa12af985fd175335091d64` (link)
#151808	Document a safety condition for `TypedArena::alloc_raw_slic…	`40fafe2980d3ce45fbd6422c516450d709d3b7bb` (link)
#151811	Fix false positive in unused_parens caused by break	`68ac097c81d43a17ee1056efea0b600fafc71d3a` (link)
#151817	Fix missing syntax context in lifetime hygiene debug output	`40f82c116346e69514db97d428ad23a16c66a7a1` (link)
#151844	rustc-dev-guide subtree update	`4db82c8cab0a20b43a24dd38d8a726edbb0e6454` (link)

previous master: ef2657cbaf

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-30T09:53:13Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ef2657c (parent) -> 7d8ebe3 (this PR)

Test differences

Show 32 test diffs

Stage 1

[ui] tests/ui/hygiene/unpretty-debug-lifetimes.rs: [missing] -> pass (J0)
[ui] tests/ui/lint/unused-parens-labeled-break-issue-143256.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/hygiene/unpretty-debug-lifetimes.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/unused-parens-labeled-break-issue-143256.rs: [missing] -> pass (J1)

Additionally, 28 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7d8ebe3128fc87f3da1ad64240e63ccf07b8f0bd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 8111.3s -> 5906.0s (-27.2%)
aarch64-apple: 12499.0s -> 9788.4s (-21.7%)
x86_64-gnu-gcc: 4154.3s -> 3350.4s (-19.4%)
x86_64-gnu-tools: 3731.5s -> 3104.0s (-16.8%)
dist-aarch64-msvc: 5477.0s -> 6397.0s (+16.8%)
x86_64-gnu-llvm-21-2: 5745.1s -> 4843.0s (-15.7%)
x86_64-gnu-stable: 8655.7s -> 7362.7s (-14.9%)
x86_64-rust-for-linux: 3082.4s -> 2646.3s (-14.1%)
pr-check-1: 1879.3s -> 1625.9s (-13.5%)
x86_64-gnu-llvm-20: 4501.2s -> 3930.8s (-12.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-30T10:32:48Z

Finished benchmarking commit (7d8ebe3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 3.0%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	3.1%	[2.1%, 4.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 545.612s -> 475.389s (-12.87%)
Artifact size: 397.86 MiB -> 397.80 MiB (-0.02%)

tshepang and others added 30 commits January 20, 2026 00:25

inline outlier links, for consistency

7f71511

replace _ with - in path names (for consistency)

9fad6f6

Add link to internals.rust-lang.org in walkthrough

db14255

Document experimental RFC process in walkthrough

f28c32a

Add link to RFC2033 in walkthrough

156cb44

Prepare for merging from rust-lang/rust

8fe3738

This updates the rust-version file to 5c49c4f.

fix dangling reference

307b9d9

fix grammar

b75e040

missing pause

5c8ba26

Merge pull request rust-lang#2735 from rust-lang/rustc-pull

92c7f4a

Rustc pull update

coercions.md: add date-check marker

6710b7f

r? @BoxyUwU

Merge pull request rust-lang#2737 from rust-lang/tshepang-patch-1

75f776b

coercions.md: add date-check marker

Fix typo

7ecd7cd

Co-authored-by: Yuki Okushi <[email protected]>

Merge pull request rust-lang#2734 from reddevilmidzy/eRFC

b7d9868

Document experimental RFC process in walkthrough

Add a new subsection for contributors

46483e6

Merge pull request rust-lang#2738 from rust-lang/add-offload-contribu…

dd6ccfd

…ting-docs Add a new subsection for contributors

Add info about unused_attributes

0b28b13

Merge pull request rust-lang#2739 from rust-lang/unused_attributes

f010f15

Add info about unused_attributes

Prepare for merging from rust-lang/rust

79549a0

This updates the rust-version file to 873d468.

Merge pull request rust-lang#2740 from rust-lang/rustc-pull

248ffb6

Rustc pull update

Prepare for merging from rust-lang/rust

8a24ab3

This updates the rust-version file to 0462e8f.

Merge pull request rust-lang#2741 from rust-lang/rustc-pull

1054091

Rustc pull update

Add missing autodiff run-make tests to the install docs

b7077f6

Merge pull request rust-lang#2743 from rust-lang/update-autodiff-tests

f2141d0

Add missing autodiff run-make tests to the install docs

Refer to debug-logging bootstrap config by its full path.

4571484

Merge pull request rust-lang#2744 from rust-lang/lolbinarycat-patch-1

9047b6d

Refer to debug-logging bootstrap config by its full path.

Fix false positive in unused_parens caused by break

4803644

tshepang and others added 7 commits January 30, 2026 01:05

Merge pull request rust-lang#2748 from rust-lang/tshepang/sembr

6ea1809

sembr

Rollup merge of rust-lang#151811 - chenyukang:yukang-fix-143256-unuse…

4500974

…d-parens-labeled-loops, r=Kivooeo Fix false positive in unused_parens caused by break Fixes rust-lang#143256

Rollup merge of rust-lang#151844 - tshepang:rdg-sync, r=tshepang

5b54208

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@e03697d. Created using https://github.com/rust-lang/josh-sync. r? @ghost

rust-bors bot added the rollup A PR which is a rollup label Jan 30, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2026

rust-bors bot mentioned this pull request Jan 30, 2026

Reduce generics use in the query system. #151777

Merged

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2026

rust-bors bot merged commit 7d8ebe3 into rust-lang:main Jan 30, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Jan 30, 2026

Zalathar deleted the rollup-jdJCcDh branch January 30, 2026 09:55

This was referenced Jan 30, 2026

constify Iterator, take IV #151281

Merged

Make some load-from-disk function pointers optional in query vtables #151736

Merged

Use the query vtable in query_feed plumbing #151853

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #151852

Rollup of 5 pull requests #151852

Uh oh!

Zalathar commented Jan 30, 2026

Uh oh!

Zalathar commented Jan 30, 2026

Uh oh!

rust-bors bot commented Jan 30, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 30, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Rollup of 5 pull requests #151852

Rollup of 5 pull requests #151852

Uh oh!

Conversation

Zalathar commented Jan 30, 2026

Uh oh!

Zalathar commented Jan 30, 2026

Uh oh!

rust-bors bot commented Jan 30, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 30, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 30, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants