Implement AST -> HIR generics propagation in delegation#151864
Open
aerooneqq wants to merge 10 commits intorust-lang:mainfrom
Open
Implement AST -> HIR generics propagation in delegation#151864aerooneqq wants to merge 10 commits intorust-lang:mainfrom
aerooneqq wants to merge 10 commits intorust-lang:mainfrom
Conversation
Collaborator
|
HIR ty lowering was modified cc @fmease |
This comment has been minimized.
This comment has been minimized.
Member
|
would it be possible to split this pr to commits? |
Contributor
@aerooneqq is sitting in the same office with me, we'll figure out how to review this better. |
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Jan 30, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
94fa69b to
a6d9e63
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for generics propagation during AST -> HIR lowering and is a part of #118212.
Nearest future work:
impl Traitparams in functionsreuse <u8 as Trait<_>>::foo as generic_arguments2reuse Trait::<_, _>::foo::<_>r? @petrochenkov