Skip to content

don't use env with infer vars#151871

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
jdonszelmann:no-env-with-infer-vars
Feb 22, 2026
Merged

don't use env with infer vars#151871
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
jdonszelmann:no-env-with-infer-vars

Conversation

@jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Jan 30, 2026 •
edited by rustbot
Loading

View all comments

This is a change lcnr added on top of 5bd20bb but we decided that it's a separate change for a separate problem. So, filed as a separate PR. Lcnr asked me to r? @BoxyUwU to take a look so hiii boxy :3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2026
BoxyUwU
BoxyUwU reviewed Feb 3, 2026
View reviewed changes
compiler/rustc_trait_selection/src/traits/coherence.rs Outdated
Copy link
Member

@BoxyUwU BoxyUwU Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intercrate mode isnt a thing can u change this to use the more modern terminology of typing modes and coherence

BoxyUwU
BoxyUwU reviewed Feb 3, 2026
View reviewed changes
@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 3, 2026

what's the context here? infer vars in the env are breaking something? somewhere? but there's no test or linked issue in this PR :3

@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 3, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 9, 2026

@BoxyUwU this came up when creating #151746. This change is required for that PR, but seemed more generally applicable

@jdonszelmann jdonszelmann force-pushed the no-env-with-infer-vars branch from 130a9e6 to ab53109 Compare February 9, 2026 11:45
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 17, 2026

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2026
@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 18, 2026

r=me after assertion

@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 18, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2026
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 18, 2026

Oki, ty!

@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 18, 2026

oh and the intercrate comment :>

@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 18, 2026

so i guess not r=me ill just look over it again once u do both 😅

@jdonszelmann jdonszelmann force-pushed the no-env-with-infer-vars branch from ab53109 to 20612fc Compare February 19, 2026 16:12
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann force-pushed the no-env-with-infer-vars branch from 20612fc to 7b46834 Compare February 19, 2026 16:22
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann force-pushed the no-env-with-infer-vars branch from 7b46834 to 642d9c4 Compare February 20, 2026 09:49
@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 21, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 21, 2026

📌 Commit 642d9c4 has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 21, 2026
@jhpratt
Rollup merge of rust-lang#151871 - jdonszelmann:no-env-with-infer-var…
91cad0d 
…s, r=BoxyUwU

don't use env with infer vars

This is a change lcnr added on top of rust-lang@5bd20bb but we decided that it's a separate change for a separate problem. So, filed as a separate PR. Lcnr asked me to r? @BoxyUwU to take a look so hiii boxy :3
@jhpratt jhpratt mentioned this pull request Feb 21, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 21, 2026
@bors
Auto merge of #152945 - jhpratt:rollup-0dxudNY, r=jhpratt
131f53e 
Rollup of 14 pull requests

Successful merges:

 - #150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - #151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - #151740 (Fix short backtraces from stripped executables)
 - #151871 (don't use env with infer vars)
 - #152591 (Simplify internals of `{Rc,Arc}::default`)
 - #152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - #152908 (Enable rust.remap-debuginfo in the dist profile)
 - #152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - #152767 (fix typo in `carryless_mul` macro invocation)
 - #152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - #152871 (Fix warnings in rs{begin,end}.rs files)
 - #152921 (Add build.rustdoc option to bootstrap config)
 - #152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - #152937 (remove unneeded reboxing)
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 22, 2026
@jhpratt
Rollup merge of rust-lang#151871 - jdonszelmann:no-env-with-infer-var…
95a7aa3 
…s, r=BoxyUwU

don't use env with infer vars

This is a change lcnr added on top of rust-lang@5bd20bb but we decided that it's a separate change for a separate problem. So, filed as a separate PR. Lcnr asked me to r? @BoxyUwU to take a look so hiii boxy :3
@jhpratt jhpratt mentioned this pull request Feb 22, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152950 - jhpratt:rollup-GqmsYmb, r=jhpratt
4359a16 
Rollup of 15 pull requests

Successful merges:

 - #149366 (GVN: consider constants of primitive types as deterministic)
 - #150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - #151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - #151871 (don't use env with infer vars)
 - #152591 (Simplify internals of `{Rc,Arc}::default`)
 - #152657 (std: move `exit` out of PAL)
 - #152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - #152908 (Enable rust.remap-debuginfo in the dist profile)
 - #152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - #152767 (fix typo in `carryless_mul` macro invocation)
 - #152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - #152871 (Fix warnings in rs{begin,end}.rs files)
 - #152921 (Add build.rustdoc option to bootstrap config)
 - #152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - #152937 (remove unneeded reboxing)
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 22, 2026
@jhpratt
Rollup merge of rust-lang#151871 - jdonszelmann:no-env-with-infer-var…
1cecb9c 
…s, r=BoxyUwU

don't use env with infer vars

This is a change lcnr added on top of rust-lang@5bd20bb but we decided that it's a separate change for a separate problem. So, filed as a separate PR. Lcnr asked me to r? @BoxyUwU to take a look so hiii boxy :3
@jhpratt jhpratt mentioned this pull request Feb 22, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152951 - jhpratt:rollup-NcY8xiT, r=jhpratt
5eddb80 
Rollup of 14 pull requests

Successful merges:

 - #150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - #151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - #151871 (don't use env with infer vars)
 - #152591 (Simplify internals of `{Rc,Arc}::default`)
 - #152657 (std: move `exit` out of PAL)
 - #152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - #152908 (Enable rust.remap-debuginfo in the dist profile)
 - #152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - #152767 (fix typo in `carryless_mul` macro invocation)
 - #152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - #152871 (Fix warnings in rs{begin,end}.rs files)
 - #152921 (Add build.rustdoc option to bootstrap config)
 - #152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - #152937 (remove unneeded reboxing)
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 22, 2026
@jhpratt
Rollup merge of rust-lang#151871 - jdonszelmann:no-env-with-infer-var…
c3adf8c 
…s, r=BoxyUwU

don't use env with infer vars

This is a change lcnr added on top of rust-lang@5bd20bb but we decided that it's a separate change for a separate problem. So, filed as a separate PR. Lcnr asked me to r? @BoxyUwU to take a look so hiii boxy :3
@jhpratt jhpratt mentioned this pull request Feb 22, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152957 - jhpratt:rollup-BJ4fXl2, r=jhpratt
57c8787 
Rollup of 13 pull requests

Successful merges:

 - #150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - #151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - #151871 (don't use env with infer vars)
 - #152591 (Simplify internals of `{Rc,Arc}::default`)
 - #152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - #152908 (Enable rust.remap-debuginfo in the dist profile)
 - #152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - #152767 (fix typo in `carryless_mul` macro invocation)
 - #152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - #152871 (Fix warnings in rs{begin,end}.rs files)
 - #152921 (Add build.rustdoc option to bootstrap config)
 - #152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - #152937 (remove unneeded reboxing)
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 22, 2026
@jhpratt
Rollup merge of rust-lang#151871 - jdonszelmann:no-env-with-infer-var…
232c29e 
…s, r=BoxyUwU

don't use env with infer vars

This is a change lcnr added on top of rust-lang@5bd20bb but we decided that it's a separate change for a separate problem. So, filed as a separate PR. Lcnr asked me to r? @BoxyUwU to take a look so hiii boxy :3
@jhpratt jhpratt mentioned this pull request Feb 22, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152960 - jhpratt:rollup-0QsFtMl, r=jhpratt
e505e98 
Rollup of 15 pull requests

Successful merges:

 - #150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - #151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - #151871 (don't use env with infer vars)
 - #152591 (Simplify internals of `{Rc,Arc}::default`)
 - #152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - #152908 (Enable rust.remap-debuginfo in the dist profile)
 - #147859 (reduce the amount of panics in `{TokenStream, Literal}::from_str` calls)
 - #152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - #152767 (fix typo in `carryless_mul` macro invocation)
 - #152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - #152871 (Fix warnings in rs{begin,end}.rs files)
 - #152879 (Remove `impl IntoQueryParam<P> for &'a P`.)
 - #152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - #152937 (remove unneeded reboxing)
 - #152953 (Fix typo in armv7a-vex-v5.md)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 22, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152965 - JonathanBrouwer:rollup-QnrcBRx, r=JonathanBro…
d40973f 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - #151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - #151871 (don't use env with infer vars)
 - #152591 (Simplify internals of `{Rc,Arc}::default`)
 - #152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - #147859 (reduce the amount of panics in `{TokenStream, Literal}::from_str` calls)
 - #152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - #152767 (fix typo in `carryless_mul` macro invocation)
 - #152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - #152871 (Fix warnings in rs{begin,end}.rs files)
 - #152879 (Remove `impl IntoQueryParam<P> for &'a P`.)
 - #152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - #152937 (remove unneeded reboxing)
 - #152953 (Fix typo in armv7a-vex-v5.md)
rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152965 - JonathanBrouwer:rollup-QnrcBRx, r=JonathanBro…
1500f0f 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - #151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - #151871 (don't use env with infer vars)
 - #152591 (Simplify internals of `{Rc,Arc}::default`)
 - #152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - #147859 (reduce the amount of panics in `{TokenStream, Literal}::from_str` calls)
 - #152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - #152767 (fix typo in `carryless_mul` macro invocation)
 - #152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - #152871 (Fix warnings in rs{begin,end}.rs files)
 - #152879 (Remove `impl IntoQueryParam<P> for &'a P`.)
 - #152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - #152937 (remove unneeded reboxing)
 - #152953 (Fix typo in armv7a-vex-v5.md)
@rust-bors rust-bors bot merged commit b3cfe5e into rust-lang:main Feb 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 22, 2026
rust-timer added a commit that referenced this pull request Feb 22, 2026
@rust-timer
Unrolled build for #151871
adbdbed 
Rollup merge of #151871 - jdonszelmann:no-env-with-infer-vars, r=BoxyUwU

don't use env with infer vars

This is a change lcnr added on top of 5bd20bb but we decided that it's a separate change for a separate problem. So, filed as a separate PR. Lcnr asked me to r? @BoxyUwU to take a look so hiii boxy :3
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 22, 2026

@rust-timer build adbdbed

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Feb 22, 2026

Finished benchmarking commit (adbdbed): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 3.4%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.835s -> 480.02s (-0.38%)
Artifact size: 397.84 MiB -> 397.93 MiB (0.02%)

github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Feb 23, 2026
@bors
Auto merge of #152965 - JonathanBrouwer:rollup-QnrcBRx, r=JonathanBro…
d21f4bf 
…uwer

Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - rust-lang/rust#151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - rust-lang/rust#151871 (don't use env with infer vars)
 - rust-lang/rust#152591 (Simplify internals of `{Rc,Arc}::default`)
 - rust-lang/rust#152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - rust-lang/rust#147859 (reduce the amount of panics in `{TokenStream, Literal}::from_str` calls)
 - rust-lang/rust#152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - rust-lang/rust#152767 (fix typo in `carryless_mul` macro invocation)
 - rust-lang/rust#152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - rust-lang/rust#152871 (Fix warnings in rs{begin,end}.rs files)
 - rust-lang/rust#152879 (Remove `impl IntoQueryParam<P> for &'a P`.)
 - rust-lang/rust#152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - rust-lang/rust#152937 (remove unneeded reboxing)
 - rust-lang/rust#152953 (Fix typo in armv7a-vex-v5.md)
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 23, 2026
@bors
Auto merge of #152965 - JonathanBrouwer:rollup-QnrcBRx, r=JonathanBro…
1f76d8d 
…uwer

Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#150468 (rustc_target: callconv: powerpc64: Use the ABI set in target options instead of guessing)
 - rust-lang/rust#151628 (Fix ICE in const eval of packed SIMD types with non-power-of-two element counts)
 - rust-lang/rust#151871 (don't use env with infer vars)
 - rust-lang/rust#152591 (Simplify internals of `{Rc,Arc}::default`)
 - rust-lang/rust#152865 (Fixed ByteStr not padding within its Display trait when no specific alignment is mentioned)
 - rust-lang/rust#147859 (reduce the amount of panics in `{TokenStream, Literal}::from_str` calls)
 - rust-lang/rust#152705 (Test(lib/win/proc): Skip `raw_attributes` doctest under Win7)
 - rust-lang/rust#152767 (fix typo in `carryless_mul` macro invocation)
 - rust-lang/rust#152837 (fix(codegen): Use `body_codegen_attrs` For Caller In `adjust_target_feature_sig`)
 - rust-lang/rust#152871 (Fix warnings in rs{begin,end}.rs files)
 - rust-lang/rust#152879 (Remove `impl IntoQueryParam<P> for &'a P`.)
 - rust-lang/rust#152933 (Start migration for `LintDiagnostic` items by adding API and migrating `LinkerOutput` lint)
 - rust-lang/rust#152937 (remove unneeded reboxing)
 - rust-lang/rust#152953 (Fix typo in armv7a-vex-v5.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jdonszelmann @BoxyUwU @rustbot @rust-log-analyzer @JonathanBrouwer @rust-timer @lcnr