Rollup of 3 pull requests by JonathanBrouwer · Pull Request #151911 · rust-lang/rust

JonathanBrouwer · 2026-01-31T14:17:06Z

Successful merges:

Remove unused method DroplessArena::contains_slice #151908 (Remove unused method DroplessArena::contains_slice)
refactor: add an enum DerefAdjustKind in favor of Option<OverloadedDeref> #151850 (refactor: add an enum DerefAdjustKind in favor of Option<OverloadedDeref>)
Fix ICE when parsing frontmatter without newline #151889 (Fix ICE when parsing frontmatter without newline)

…dDeref>`

Remove unused method `DroplessArena::contains_slice` - This method was added for rust-lang#120128. - It became unused in rust-lang#136593. Checking whether a particular slice is within an arena is a bit of a sketchy operation, so if there's no pressing need for it then I think we're better off not having it lying around.

…r=jackh726 refactor: add an `enum DerefAdjustKind` in favor of `Option<OverloadedDeref>` Part of rust-lang#149130. r? jackh726

…matter-ice, r=Kivooeo Fix ICE when parsing frontmatter without newline Fixes rust-lang#151882 we can not add a normal test case for it: - no newline at the end of file, we can bypass this with change test file name with `ignore-tidy` - multiple errors in stderr, this conflicts with the previous bypass, seems we can not add multiple error annotations in one line anyway, I added a `run-make` test for it.

JonathanBrouwer · 2026-01-31T14:17:23Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-31T14:17:26Z

📌 Commit 874c5d2 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-log-analyzer · 2026-01-31T15:29:07Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   4 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d
---
tests/ui/drain_collect.fixed ... ok
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/elidable_lifetime_names.rs ... ok
tests/ui/eager_transmute.rs ... ok
---
...............................................    (147/147)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: Error: The window properties still all match: for command `wait-for-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

rust-bors · 2026-01-31T19:35:25Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 11m 1s
Pushing 8afe9ff to main...

rust-timer · 2026-01-31T19:36:17Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#151850	refactor: add an `enum DerefAdjustKind` in favor of `Option…	`2828499e95a1d7633268b6e4b4d02aca651a9b46` (link)
#151889	Fix ICE when parsing frontmatter without newline	`e15234ad36accb91b26ababe85ac00b62b5e3f29` (link)
#151908	Remove unused method `DroplessArena::contains_slice`	`05b61bd2c66b960ac812e14dc78e38b060efb58a` (link)

previous master: 78865ca937

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-31T19:38:32Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 78865ca (parent) -> 8afe9ff (this PR)

Test differences

Show 26 test diffs

Stage 1

[run-make] tests/run-make/frontmatter-no-trailing-newline: [missing] -> pass (J3)

Stage 2

[run-make] tests/run-make/frontmatter-no-trailing-newline: [missing] -> pass (J0)
[run-make] tests/run-make/frontmatter-no-trailing-newline: [missing] -> ignore (only executed when the release channel is nightly) (J1)
[run-make] tests/run-make/frontmatter-no-trailing-newline: [missing] -> ignore (ignored if target does not support std) (J2)

Additionally, 22 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8afe9ff1caa97654c31fb8c259dac9fdf67d6302 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 11880.3s -> 9476.0s (-20.2%)
dist-x86_64-apple: 6506.6s -> 7539.3s (+15.9%)
dist-aarch64-llvm-mingw: 6944.8s -> 6124.3s (-11.8%)
x86_64-gnu-aux: 7497.6s -> 8359.0s (+11.5%)
dist-apple-various: 4279.8s -> 3803.6s (-11.1%)
dist-aarch64-msvc: 6203.3s -> 5557.5s (-10.4%)
dist-powerpc-linux: 5263.0s -> 5792.5s (+10.1%)
dist-x86_64-freebsd: 5301.6s -> 4836.9s (-8.8%)
x86_64-gnu-llvm-21-3: 6311.4s -> 6850.1s (+8.5%)
arm-android: 6311.6s -> 5804.9s (-8.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-31T20:16:21Z

Finished benchmarking commit (8afe9ff): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -17.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-17.0%	[-31.7%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.918s -> 476.06s (-0.18%)
Artifact size: 397.86 MiB -> 397.87 MiB (0.00%)

frank-king and others added 6 commits January 31, 2026 16:25

refactor: add an enum DerefAdjustKind in favor of `Option<Overloade…

996425b

…dDeref>`

Fix ICE when parsing frontmatter without newline

dc48704

Remove unused method DroplessArena::contains_slice

e60c475

Rollup merge of rust-lang#151850 - frank-king:refactor/pin-coerce-2, …

1b7a7c7

…r=jackh726 refactor: add an `enum DerefAdjustKind` in favor of `Option<OverloadedDeref>` Part of rust-lang#149130. r? jackh726

rust-bors bot added the rollup A PR which is a rollup label Jan 31, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2026

rust-bors bot merged commit 8afe9ff into rust-lang:main Jan 31, 2026
8 of 12 checks passed

rustbot added this to the 1.95.0 milestone Jan 31, 2026

rust-bors bot mentioned this pull request Jan 31, 2026

fix ice where unsafe fn was incorrectly handled #150213

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 3 pull requests#151911

Rollup of 3 pull requests#151911
rust-bors[bot] merged 6 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-ACi3J2a

JonathanBrouwer commented Jan 31, 2026

Uh oh!

JonathanBrouwer commented Jan 31, 2026

Uh oh!

rust-bors bot commented Jan 31, 2026

Uh oh!

rust-log-analyzer commented Jan 31, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 31, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 31, 2026

Uh oh!

github-actions bot commented Jan 31, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

JonathanBrouwer commented Jan 31, 2026

Uh oh!

JonathanBrouwer commented Jan 31, 2026

Uh oh!

rust-bors bot commented Jan 31, 2026

Uh oh!

rust-log-analyzer commented Jan 31, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 31, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 31, 2026

Uh oh!

github-actions bot commented Jan 31, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 31, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants