Skip to content

Gate #![reexport_test_harness_main] properly#152210

Open
Ozzy1423 wants to merge 1 commit intorust-lang:mainfrom
Ozzy1423:attrs7
Open

Gate #![reexport_test_harness_main] properly#152210
Ozzy1423 wants to merge 1 commit intorust-lang:mainfrom
Ozzy1423:attrs7

Conversation

@Ozzy1423
Copy link
Contributor

@Ozzy1423 Ozzy1423 commented Feb 6, 2026 •
edited by rustbot
Loading

View all comments

Address the FIXME

Removed from issue-43106-gating-of-builtin-attrs.rs since that is for stable attributes only.

This would be a breaking change, search of github shows it is mostly but not always used with #![test_runner] which is already gated correctly.

Details:
#50297

Feel free to close this issue if you think it is not worth addressing the FIXME...

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Feb 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • People who recently interacted with files modified in this PR: compiler
  • compiler expanded to 20 candidates
  • Random selection from 12 candidates

@fmease fmease added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. needs-crater This change needs a crater run to check for possible breakage in the ecosystem. labels Feb 6, 2026
@fee1-dead
Copy link
Member

fee1-dead commented Feb 17, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Feb 17, 2026
@bors
Auto merge of #152210 - Ozzy1423:attrs7, r=<try>
79452e8 
Gate #![reexport_test_harness_main] properly
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 17, 2026

☀️ Try build successful (CI)
Build commit: 79452e8 (79452e8441468c5568c20bfca2aa1fe75b645b2d, parent: 3c9faa0d037b9eecda4a440cc482ff7f960fb8a5)

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 17, 2026

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Feb 17, 2026

👌 Experiment pr-152210 created and queued.
🤖 Automatically detected try build 79452e8
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2026
@fee1-dead
Copy link
Member

fee1-dead commented Feb 17, 2026

(for reference, this was discussed in #t-compiler > MCP needed for gating an accidentally stable attribute?)

@craterbot
Copy link
Collaborator

craterbot commented Feb 17, 2026

🚧 Experiment pr-152210 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Feb 19, 2026

🎉 Experiment pr-152210 is completed!
📊 6 regressed and 8 fixed (818761 total)
📊 2503 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-152210/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 19, 2026
@JonathanBrouwer JonathanBrouwer added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 20, 2026
@rustbot rustbot mentioned this pull request Feb 20, 2026
Open
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 20, 2026 •
edited
Loading

All changes in the crater run are spurious.
@rust-lang/lang are you ok with this change?
r=me if you are

@JonathanBrouwer JonathanBrouwer added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination labels Feb 20, 2026
@traviscross traviscross added the P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang label Feb 20, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 24, 2026

☔ The latest upstream changes (presumably #153026) made this pull request unmergeable. Please resolve the merge conflicts.

@traviscross
Copy link
Contributor

traviscross commented Feb 25, 2026 •
edited
Loading

We talked about this in the meeting today. Let's propose to do this. Some people may do some further investigation; if we find things, we'll file concerns.

@rfcbot fcp merge lang

@rust-rfcbot

This comment was marked as resolved.

Sign in to view
@traviscross

This comment was marked as duplicate.

Sign in to view
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Feb 25, 2026 •
edited by scottmcm
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 25, 2026
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Feb 25, 2026

@rfcbot reviewed

@traviscross traviscross added I-lang-radar Items that are on lang's radar and will need eventual work or consideration. and removed I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Feb 25, 2026
@rust-rfcbot rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 25, 2026
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Feb 25, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@steffahn
Copy link
Member

steffahn commented Feb 25, 2026 •
edited
Loading

If anyone wonders the history, I tracked the git blame: the original marker as explicitly “ungated” came in https://github.com/rust-lang/rust/pull/28077/changes#diff-67980357baa8318a775fe4bc05336ea3feba90a64b58d0f8259e2665b2a719dbR237; the fixme comment was introduced in https://github.com/rust-lang/rust/pull/63824/changes#diff-2a0098fbcad74c47eafa44fd374d9f5740476a3af0134d9ec1bdc33e736a8063R188

@RalfJung
Copy link
Member

RalfJung commented Feb 25, 2026

the original marker as explicitly “ungated” came in

That just made the default explicit, didn't it? Adding it ungated happened in #22364.

@jackh726
Copy link
Member

jackh726 commented Feb 25, 2026 •
edited
Loading

Ah, I got nerd-sniped (oh well).

This attribute has been around since pre 1.0, and when feature-gated attributes were added (#22364), this just wasn't gated. The FIXME was added in #63824 alongside general other cleanups/refactors.

@jackh726
Copy link
Member

jackh726 commented Feb 25, 2026

This seems like an obvious case of "this probably wasn't a vetted stabilization", and given that it seems like this attribute shouldn't be used without test_runner, adding a feature gate seems obviously appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fee1-dead fee1-dead

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-crater This change needs a crater run to check for possible breakage in the ecosystem. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.