Fix LegacyKeyValueFormat report from docker build

[homersimpsons]

While checking job logs (https://github.com/rust-lang/rust/actions/runs/21779827147/job/62842068357#step:28:217) I noticed:

   2 warnings found (use docker --debug to expand):
   - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 24)
   - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 29)

I identified warnings with:

git ls-files --directory **/Dockerfile | sed -E -e "s/(\/Dockerfile)//" |xargs --verbose --replace={} docker build --check {}

I went with ENV ENVVAR="quoted" because it is the most working solution I found. Note that I did not touch lines that did not report a warning but that were written as ENV ENVVAR=unquoted or ENV ENVVAR=multi \\n line.

FROM alpine

ENV INLINE_UNQUOTE=this is a test
ENV INLINE_QUOTE="this is a test"
ENV MULTILINE_UNQUOTE= \
  this \
  is \
  a \
  test
ENV MULTILINE_QUOTE="\
  this \
  is \
  a \
  test"

Merge split:

1. aarch64-gnu-debug: Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug #153109

[rustbot]

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: infra-ci
• infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
• Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

[homersimpsons]

Note that here docker reports:

WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$CPATH' (did you mean $PATH?)
src/ci/docker/host-aarch64/dist-aarch64-linux/Dockerfile:77
--------------------
  75 |     ENV HOSTS=aarch64-unknown-linux-gnu
  76 |
  77 | >>> ENV CPATH=/usr/include/aarch64-linux-gnu/:$CPATH
  78 |
  79 |     ENV RUST_CONFIGURE_ARGS=" \

I'm not sure if this warning should be fixed or if there is an error regarding this.

(That is the sole remaining warning after this commit)

[homersimpsons]

My IDE probably did that, should I revert?

[marcoieni]

I'm sorry I didn't review this in time. This is still in my todo list :(
I wanted to ask you:

• Can you review the emoji from the commit and PR title? I don't remember I saw emojis in rust commits, but maybe I'm wrong. If you saw them, please link them to me 👍
• Can you open a smaller PR where you edit only aarch64-gnu-debug/Dockerfile‎? So that it's a small change. And once we verify it works and it's merged, we can apply the same changes to other Dockerfiles. Merging this PR is a bit scary as it changes many Dockerfile all at once. Wdyt? I would edit maximum ~5 Dockerfiles per PR.

[homersimpsons]

Thank you for your check.

Can you review the emoji from the commit and PR title?

Done

Can you open a smaller PR where you edit only aarch64-gnu-debug/Dockerfile‎?

I opened #153109

Merging this PR is a bit scary as it changes many Dockerfile all at once. Wdyt? I would edit maximum ~5 Dockerfiles per PR.

Yes, I agree it is scary. I would hope the CI would catch anything wrong, though. Okay, I will proceed with batches of Dockerfiles (I will try to group them logically per arch or something). I keep this merge request open for reference.