Skip to content

Conversation

@mu001999
Copy link
Contributor

@mu001999 mu001999 commented Feb 11, 2026

Detected by #152164.

Only allow unused_features if there are complex platform-specific features enabled.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 11, 2026
@mu001999 mu001999 marked this pull request as ready for review February 11, 2026 06:38
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2026

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2026

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 67 candidates
  • Random selection from 14 candidates

@Nadrieril
Copy link
Member

Hi, thanks for your contribution!

We should not remove these feature gates from tests. Features in tests sometimes test very subtle interactions and we don't want to break that. Also for tools and rustdoc we generally don't touch these directories unless strictly necessary; we're not running their whole test suite in CI so we could be removing a feature they actually use.

I'm also of the opinion that replacing a feature with cfg_attr(..., feature(...)) is noise and not worth the precision. E.g. all the platform-specific stuff in core.

The rest looks good to me, that's some nice cleanups.

@mu001999
Copy link
Contributor Author

@Nadrieril Make sense, I will keep the removal in compiler and replace the rest with just allowing unused_features

@mu001999 mu001999 force-pushed the cleanup/unused-features branch from aa64776 to b391897 Compare February 12, 2026 03:47
@rust-bors

This comment has been minimized.

@mu001999 mu001999 force-pushed the cleanup/unused-features branch from b391897 to 2833eea Compare February 12, 2026 07:37
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@mu001999 mu001999 force-pushed the cleanup/unused-features branch from 2833eea to 41b83c2 Compare February 12, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants