Rollup of 9 pull requests #152484
Rollup of 9 pull requests #152484
Conversation
Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity.
…e observed on stable
Keys and values now must be `Copy` due to erasing.
The derived version is equivalent to the hand-written version.
The latter is a new module. As well as the code motion, some other changes were required. - `QueryJobId` methods became free functions so they could move while `QueryJobId` itself stayed put. This was so `QueryMap` and `QueryJobInfo` could be moved. - Some visibilities in `rustc_query_system` required changing. - `collect_active_jobs_from_all_queries` is no longer required in `trait QueryContext`.
Because all uses are now in `rustc_query_impl`. This was made possible by the previous commit. Less code in `rustc_middle`, hooray.
From `rustc_query_system::query::job` to `rustc_query_impl::job`.
…rmal attribute logic instead of special cased checks
- CONTRIBUTING.md: add missing verb "is"
- INSTALL.md: fix subject-verb agreement ("requires" → "require")
- RELEASES.md: fix 4 issues (previous → previously, remove extra "is",
add hyphen in Rust-for-Linux, results → result)
- src/doc/not_found.md: fix misspelling ("Standary" → "Standard")
- src/doc/index.md: fix awkward grammar in Embedded Rust Book description
…ode, r=Zalathar Move more query system code Towards the goal of eliminating `rustc_query_system`, this commit moves some code from `rustc_query_system` to `rustc_middle` and `rustc_query_impl`, and from `rustc_middle` to `rustc_query_impl`. r? @Zalathar
…jdonszelmann Restrict the set of things that const stability can be applied to r? @jdonszelmann
…ati865 Reenable a GCI+mGCA+GCPT test case The GCI+mGCA+GCPT test case can now be made to work with the necessary features and tweaks.
…-2, r=shepmaster Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2 Promote the following targets to Tier 2 without host tools: - `aarch64-apple-tvos`. - `aarch64-apple-tvos-sim`. - `aarch64-apple-watchos`. - `aarch64-apple-watchos-sim`. - `aarch64-apple-visionos`. - `aarch64-apple-visionos-sim`. This implements MCP rust-lang/compiler-team#918. Fixes rust-lang#151705. r? shepmaster
…s-wfck, r=BoxyUwU mGCA: Add associated const type check rust-lang#151642 r? BoxyUwU I didn't bless tests just yet as it only fixes the dyn arm
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
… r=TaKO8Ki BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable Not sure if that's worth it, maybe this goes without saying for all these builtin traits?
Update books ## rust-lang/book 1 commits in 39aeceaa3aeab845bc4517e7a44e48727d3b9dbe..05d114287b7d6f6c9253d5242540f00fbd6172ab 2026-02-03 15:19:04 UTC to 2026-02-03 15:19:04 UTC - Temporarily remove the link to `Drop::drop` (rust-lang/book#4576) ## rust-lang/nomicon 1 commits in 050c002a360fa45b701ea34feed7a860dc8a41bf..b8f254a991b8b7e8f704527f0d4f343a4697dfa9 2026-01-29 12:15:01 UTC to 2026-01-29 12:15:01 UTC - Fix deprecation warning for compare_and_swap in atomics.md (rust-lang/nomicon#519) ## rust-lang/reference 12 commits in 990819b86c22bbf538c0526f0287670f3dc1a67a..addd0602c819b6526b9cc97653b0fadca395528c 2026-02-04 14:35:59 UTC to 2026-01-26 18:02:14 UTC - const-eval.const-expr.field: make paragraph more clear (rust-lang/reference#2157) - make more clear what the link target is (rust-lang/reference#2156) - Update two URLs (rust-lang/reference#2154) - Add a chapter on divergence (rust-lang/reference#2067) - Guarantee `repr(C)` union field offset (rust-lang/reference#2128) - Reference updates for forbidding object lifetime changing pointer casts (rust-lang/reference#1951) - Clarify only arrays undergo unsized coercion during dispatch (rust-lang/reference#2139) - Split the textual chapter into separate char and str chapters (rust-lang/reference#2145) - Document ppc inline asm support (rust-lang/reference#2056) - Unwrap items, expressions, patterns, and types (rust-lang/reference#2141) - undefined behavior: add missing plural in `undefined.misaligned.ptr` (rust-lang/reference#2146) - inline-assembly: add a space to the `asm.abi-clobbers.many` example (rust-lang/reference#2144)
Fix typos and grammar in top-level and src/doc documentation
Fix contextual typos and grammar issues in top-level and src/doc documentation that automated spellcheckers miss:
- `CONTRIBUTING.md`: add missing verb "is"
- `INSTALL.md`: fix subject-verb agreement ("requires" → "require")
- `RELEASES.md`: fix 4 issues (previous → previously, remove extra "is", add hyphen in Rust-for-Linux, results → result)
- `src/doc/not_found.md`: fix misspelling ("Standary" → "Standard")
- `src/doc/index.md`: fix awkward grammar in Embedded Rust Book description
No functional changes.
rustbot
added
A-attributes
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
rust-bors
bot
added
S-waiting-on-bors
|
Since this rollup is third in queue at the moment anyways, does it make sense to remake it with all rollupable PRs in queue and run the try jobs again? |
|
I don't see how this makes sense. |
|
So we can include more PRs in the rollup, if you don't want that it's fine tho |
|
how would this be helping? |
|
It would empty the queue quicker |
|
It's actually the opposite. You will add more failures on top, which will actually have the opposite effect of maximizing time to merged. |
|
I think the high closed rollups rate is because a lot of the time I close and remake rollups to add a few more PRs in, before they even start running, not a lot of them actually fail. Every "broken" PR in the queue will cause a failure at some point, so making a bigger rollup only moves the failures forwards, it does not add more failures |
|
I don't really feel like argueing about optimal rollup strategy tho, just wanted to make a suggestion, so I'll just let you do your thing :) |
exactly, it moves the failures forward means it moves the merge (shrinking of the queue) backwards which causes the queue to grow and everyone has to wait longer |
|
Moving the failures forwards increases the throughput (amount of PRs merged per time) but sacrifices latency. |
11 participants
Successful merges:
r? @ghost
Create a similar rollup