DepGraphQuery: correctly skip adding edges with not-yet-added nodes#152590
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 14, 2026
Merged
DepGraphQuery: correctly skip adding edges with not-yet-added nodes#152590rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-query-system
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This was referenced Feb 13, 2026
mati865
reviewed
Feb 13, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
petrochenkov
force-pushed
the
skipedge
branch
from
59d74d7 to
b0366ce
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=mati865 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 14, 2026
DepGraphQuery: correctly skip adding edges with not-yet-added nodes Fixes rust-lang#142152. The current logic already skips some edges, so I'm not sure how critical it is to have *all* the edges recorded, the logic seems to only be used for debug dumping. Recording all edges requires supporting holes in the `LinkedGraph` data structure, to add nodes and edges out of order, rust-lang#151821 implements that at cost of complicating the data structure.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #152001 (mGCA: Validate const literal against expected type) - #152120 (Don't ICE on layout error in vtable computation) - #152512 (core: Implement feature `float_exact_integer_constants`) - #152531 (`proc_macro::bridge`: simplify `ExecutionStrategy` and `DispatcherTrait`) - #152577 (Port #[rustc_proc_macro_decls] to the new attribute parser.) - #152590 (DepGraphQuery: correctly skip adding edges with not-yet-added nodes) - #152612 (Rename `inline_fluent!` to `msg!`)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
…uwer Rollup of 8 pull requests Successful merges: - #152618 (stdarch subtree update) - #152001 (mGCA: Validate const literal against expected type) - #152120 (Don't ICE on layout error in vtable computation) - #152531 (`proc_macro::bridge`: simplify `ExecutionStrategy` and `DispatcherTrait`) - #152577 (Port #[rustc_proc_macro_decls] to the new attribute parser.) - #152570 (Port #[rustc_test_marker] to the attribute parser) - #152590 (DepGraphQuery: correctly skip adding edges with not-yet-added nodes) - #152612 (Rename `inline_fluent!` to `msg!`)
rust-timer
added a commit
that referenced
this pull request
Feb 14, 2026
Rollup merge of #152590 - petrochenkov:skipedge, r=mati865 DepGraphQuery: correctly skip adding edges with not-yet-added nodes Fixes #142152. The current logic already skips some edges, so I'm not sure how critical it is to have *all* the edges recorded, the logic seems to only be used for debug dumping. Recording all edges requires supporting holes in the `LinkedGraph` data structure, to add nodes and edges out of order, #151821 implements that at cost of complicating the data structure.
Contributor
This is the opposite of what I have expected from a "proper fix". |
Contributor
Author
|
The proper fix is #152621. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142152.
The current logic already skips some edges, so I'm not sure how critical it is to have all the edges recorded, the logic seems to only be used for debug dumping.
Recording all edges requires supporting holes in the
LinkedGraphdata structure, to add nodes and edges out of order, #151821 implements that at cost of complicating the data structure.