Skip to content

Comments

Simpler find_attr!()#152759

Merged
rust-bors[bot] merged 13 commits intorust-lang:mainfrom
jdonszelmann:simpler-get-attrs
Feb 20, 2026
Merged

Simpler find_attr!()#152759
rust-bors[bot] merged 13 commits intorust-lang:mainfrom
jdonszelmann:simpler-get-attrs

Conversation

@jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Feb 17, 2026

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2026

Some changes occurred to constck

cc @fee1-dead

HIR ty lowering was modified

cc @fmease

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @JonathanBrouwer

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in compiler/rustc_attr_parsing

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 17, 2026
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 17, 2026

sorry for the pings! this changes nothing in the crates you got pinged for that you actually care about I'm afraid hehe

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann changed the title Simpler get_attrs!() Simpler get_attr!() Feb 18, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 18, 2026

I guess I do need to fix at least librustdoc

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 18, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 18, 2026

@rustbot review

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2026
JonathanBrouwer
JonathanBrouwer approved these changes Feb 18, 2026
View reviewed changes
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with my two comments addressed

View changes since this review

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 18, 2026

@bors rollup=iffy
Likely to cause soft conflicts

@jdonszelmann jdonszelmann changed the title Simpler get_attr!() Simpler find_attr!() Feb 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 20, 2026

@bors r=jonathanbrouwer rollup=iffy p=1

This PR can be part of a rollup, just not one with other attribute changes. May soft-conflict with attribute-related changes but unlikely with other changes. p=1 for the bitrot, but if a rollup makes it merge faster go for that.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit df46b2c has been approved by jonathanbrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2026
@jdonszelmann jdonszelmann mentioned this pull request Feb 20, 2026
Open
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 20, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

⚠️ A new commit 8e7bc3c7d1689e17319b2d6fdc1220c373de7596 was pushed to the branch, the PR will need to be re-approved.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 20, 2026

@bors r=jonathanbrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit 8e7bc3c has been approved by jonathanbrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 20, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 20, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 20, 2026
@bors
Auto merge of #152904 - JonathanBrouwer:rollup-8vFeFeZ, r=JonathanBro…
0376d43 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152759 (Simpler `find_attr!()`)
 - #152057 (bootstrap: respect POSIX jobserver)
 - #152818 (DOC: do not link to "nightly" in Iterator::by_ref() docstring)
 - #152840 (Add bootstrap snapshot tests for {`install`, `install src`})
 - #152844 (Rename `DepGraphQuery` to `RetainedDepGraph`)
 - #152846 (Clarify some variable names in the query proc-macro)
 - #152858 (Fix typo in doc for core::mem::type_info::Struct)
 - #152861 (resolve: do not suggest `_` for unresolved imports)
 - #152873 (std::ops::ControlFlow - use "a" before `Result`)
 - #152877 (std::ops::ControlFlow - use normal comment for internal methods)
 - #152883 (Deny final not followed by item)
@rust-bors rust-bors bot merged commit c0fe694 into rust-lang:main Feb 20, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 20, 2026
rust-timer added a commit that referenced this pull request Feb 20, 2026
@rust-timer
Unrolled build for #152759
8c1973b 
Rollup merge of #152759 - jdonszelmann:simpler-get-attrs, r=jonathanbrouwer

Simpler `find_attr!()`

r? @JonathanBrouwer
cc: @jyn514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

@blyxyas blyxyas blyxyas left review comments

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-json Area: Rustdoc JSON backend PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jdonszelmann @rustbot @rust-log-analyzer @JonathanBrouwer @GuillaumeGomez @blyxyas