core: make atomic primitives type aliases of Atomic<T>#153015
Open
joboet wants to merge 6 commits intorust-lang:mainfrom
Open
core: make atomic primitives type aliases of Atomic<T>#153015joboet wants to merge 6 commits intorust-lang:mainfrom
Atomic<T>#153015joboet wants to merge 6 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
7 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
atomic_alias_generic
branch
from
2065018 to
affc0ef
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joboet
added
A-atomic
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
atomic_alias_generic
branch
from
a560a10 to
eb42c0f
Compare
This comment has been minimized.
This comment has been minimized.
joboet
added
A-debuginfo
Member
Author
|
@rustbot author |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
atomic_alias_generic
branch
from
9b27200 to
7d17424
Compare
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
atomic_alias_generic
branch
from
7d17424 to
bbc357f
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-rustdoc-frontend
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
atomic_alias_generic
branch
from
708144d to
34463cb
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
The manual `DynSend` implementation for `AtomicPtr` blocks the auto-implementation for other atomic primitives since they forward to the same `Atomic<T>` type now. This breakage cannot occur in user code as it depends on `DynSend` being a custom auto-trait.
... and remove some unused diagnostic items.
joboet
force-pushed
the
atomic_alias_generic
branch
from
34463cb to
ce4deb4
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
atomic_alias_generic
branch
from
ce4deb4 to
f2ee6d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #130539
This makes
AtomicI32and friends type aliases ofAtomic<T>by encoding their alignment requirements via the use of an internalStorageassociated type. This is also used to encode thatAtomicBoolstore au8internally.Modulo the
Send/Syncimplementations, this PR does not move any trait implementations, methods or associated functions – I'll leave that for another PR.