Do not add implied outlives bounds containing external regions/params only

[ShoyuVanilla]

Fixes #151637

The actuall cause wasn't that the closure's return type is wf checked.
For example, the following code is errored out as intended:

struct Wrap<T: Default>(T);

fn error<T>(x: T) {
    || Wrap(x);
    //~^ ERROR: the trait bound `T: Default` is not satisfied
}

The problem was that we are adding implied bound T: 'static even when borrowck-ing the closures.

struct Wrap<T: 'static>(T);

fn no_error<T>(x: T) {
    || Wrap(x);
}

[ShoyuVanilla]

Filtering external bounds here regresses this

rust/tests/ui/impl-trait/issues/issue-104815.rs

Line 63 in eeb94be

.map(|&n| Container::new(n, &resolver))

[ShoyuVanilla]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 484ac15 (484ac156cc381bb2cfc74c800423322f261d074d, parent: eeb94be79adc9df7a09ad0b2421f16e60e6d932c)

[rust-timer]

Finished benchmarking commit (484ac15): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.4%	[2.9%, 7.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.5%, -4.1%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.498s -> 479.757s (-0.36%)
Artifact size: 395.88 MiB -> 397.89 MiB (0.51%)

[ShoyuVanilla]

@craterbot check

[craterbot]

👌 Experiment pr-153027 created and queued.
🤖 Automatically detected try build 484ac15
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[ShoyuVanilla]

This doesn't feel correct. I think I should rather add implied bounds as before and directly propagate them again as requirements.
@craterbot cancel

[craterbot]

🗑️ Experiment pr-153027 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more