Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`. by nnethercote · Pull Request #153029 · rust-lang/rust

nnethercote · 2026-02-23T23:29:27Z

The name pass_by_value is completely wrong. The lint actually checks for the use of pass by reference for types marked with rustc_pass_by_value.

The hardest part of this was choosing the new name. The disallowed_ part of the name closely matches the following clippy lints:

disallowed_macros
disallowed_methods
disallowed_names
disallowed_script_idents
disallowed_types

The pass_by_value part of the name aligns with the following clippy lints:

needless_pass_by_value
needless_pass_by_ref_mut
trivially_copy_pass_by_ref
large_types_passed_by_value (less so)

r? @Urgau

rustbot · 2026-02-23T23:29:31Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

nnethercote · 2026-02-24T01:19:55Z

BTW, I'm not 100% certain about how I handled bootstrapping. It seems reasonable but I couldn't find any other examples in the code that looked quite the same as what I did.

Urgau

Code looks fine.

Regarding the lint name in the face of our guidelines, and in particular rule 2, I'm wondering if it shouldn't be named: rustc::disallowed_pass_by_ref_types.

Though that seems a bit long, maybe we can just remove the pass part and have rustc::disallowed_by_ref_types. What do you think?

View changes since this review

nnethercote · 2026-02-24T20:23:09Z

I think the pass is more useful than the types. And I like the idea of being consistent with existing lint names, even if that goes against the guidelines.

Urgau · 2026-02-24T20:37:52Z

I'm fine with that.

Urgau · 2026-02-24T20:38:09Z

@bors r+ rollup

rust-bors · 2026-02-24T20:38:12Z

📌 Commit d60e15f has been approved by Urgau

It is now in the queue for this repository.

@Urgau

…, r=Urgau Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`. The name `pass_by_value` is completely wrong. The lint actually checks for the use of pass by reference for types marked with `rustc_pass_by_value`. The hardest part of this was choosing the new name. The `disallowed_` part of the name closely matches the following clippy lints: - `disallowed_macros` - `disallowed_methods` - `disallowed_names` - `disallowed_script_idents` - `disallowed_types` The `pass_by_value` part of the name aligns with the following clippy lints: - `needless_pass_by_value` - `needless_pass_by_ref_mut` - `trivially_copy_pass_by_ref` - `large_types_passed_by_value` (less so) r? @Urgau

nnethercote · 2026-02-24T21:20:36Z

For the record: @Urgau and I had a private discussion about the names. We both liked disallowed, I have a strong preference to keep pass (it mirrors rustc_pass_by_value, for example). We considered disallowed_pass_by_ref and disallowed_pass_by_ref_types, but decided that the types didn't really add anything other than extra characters.

Rollup of 8 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153051 (Migration of `LintDiagnostic` - part 3)

jhpratt · 2026-02-25T03:51:11Z

@bors r-

#153059 (comment)

rust-bors · 2026-02-25T03:51:17Z

Commit d60e15f has been unapproved.

This PR was contained in a rollup (#153059), which was also unapproved.

The name `pass_by_value` is completely wrong. The lint actually checks for the use of pass by reference for types marked with `rustc_pass_by_value`. The hardest part of this was choosing the new name. The `disallowed_` part of the name closely matches the following clippy lints: - `disallowed_macros` - `disallowed_methods` - `disallowed_names` - `disallowed_script_idents` - `disallowed_types` The `pass_by_value` part of the name aligns with the following clippy lints: - `needless_pass_by_value` - `needless_pass_by_ref_mut` - `trivially_copy_pass_by_ref` - `large_types_passed_by_value` (less so)

nnethercote · 2026-02-25T04:11:32Z

I added a temporary //@ ignore-stage1 to the failing test. This should be enough to fix the problem.

@bors r=Urgau

rust-bors · 2026-02-25T04:11:34Z

📌 Commit 8eed8bd has been approved by Urgau

It is now in the queue for this repository.

nnethercote · 2026-02-25T06:22:54Z

@bors try

Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.

rust-bors · 2026-02-25T08:33:46Z

☀️ Try build successful (CI)
Build commit: 7066b8e (7066b8e7ef535474e2dc6df77c745d1115426c88, parent: 11ad63a942c380b83a1fbfe5f0ecb1caaad4c7c1)

@Urgau

…, r=Urgau Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`. The name `pass_by_value` is completely wrong. The lint actually checks for the use of pass by reference for types marked with `rustc_pass_by_value`. The hardest part of this was choosing the new name. The `disallowed_` part of the name closely matches the following clippy lints: - `disallowed_macros` - `disallowed_methods` - `disallowed_names` - `disallowed_script_idents` - `disallowed_types` The `pass_by_value` part of the name aligns with the following clippy lints: - `needless_pass_by_value` - `needless_pass_by_ref_mut` - `trivially_copy_pass_by_ref` - `large_types_passed_by_value` (less so) r? @Urgau

@Urgau

…, r=Urgau Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`. The name `pass_by_value` is completely wrong. The lint actually checks for the use of pass by reference for types marked with `rustc_pass_by_value`. The hardest part of this was choosing the new name. The `disallowed_` part of the name closely matches the following clippy lints: - `disallowed_macros` - `disallowed_methods` - `disallowed_names` - `disallowed_script_idents` - `disallowed_types` The `pass_by_value` part of the name aligns with the following clippy lints: - `needless_pass_by_value` - `needless_pass_by_ref_mut` - `trivially_copy_pass_by_ref` - `large_types_passed_by_value` (less so) r? @Urgau

@Urgau

…, r=Urgau Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`. The name `pass_by_value` is completely wrong. The lint actually checks for the use of pass by reference for types marked with `rustc_pass_by_value`. The hardest part of this was choosing the new name. The `disallowed_` part of the name closely matches the following clippy lints: - `disallowed_macros` - `disallowed_methods` - `disallowed_names` - `disallowed_script_idents` - `disallowed_types` The `pass_by_value` part of the name aligns with the following clippy lints: - `needless_pass_by_value` - `needless_pass_by_ref_mut` - `trivially_copy_pass_by_ref` - `large_types_passed_by_value` (less so) r? @Urgau

@Urgau

…, r=Urgau Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`. The name `pass_by_value` is completely wrong. The lint actually checks for the use of pass by reference for types marked with `rustc_pass_by_value`. The hardest part of this was choosing the new name. The `disallowed_` part of the name closely matches the following clippy lints: - `disallowed_macros` - `disallowed_methods` - `disallowed_names` - `disallowed_script_idents` - `disallowed_types` The `pass_by_value` part of the name aligns with the following clippy lints: - `needless_pass_by_value` - `needless_pass_by_ref_mut` - `trivially_copy_pass_by_ref` - `large_types_passed_by_value` (less so) r? @Urgau

…uwer Rollup of 13 pull requests Successful merges: - #153079 (Revert "Move aarch64-apple dist builder to dynamic llvm linking") - #148146 (CI: use alternative disks if available) - #149937 (spliit out `linker-info` from `linker-messages`) - #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - #153075 (mGCA: Lower negated literals directly and reject non-integer negations) - #153078 (Remove `QuerySystemFns`) - #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153063 (`is_ty_must_use`: do not require a `span` argument) - #153071 (Update books) - #153092 (Remove redundant self usages) - #153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - #153091 (Migration of `LintDiagnostic` - part 4)

Rollup of 13 pull requests Successful merges: - #148146 (CI: use alternative disks if available) - #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - #153075 (mGCA: Lower negated literals directly and reject non-integer negations) - #153078 (Remove `QuerySystemFns`) - #153089 (interpret: avoid dummy spans in the stacktrace) - #153111 (Refactor url_parts to return is_absolute instead of out param) - #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153063 (`is_ty_must_use`: do not require a `span` argument) - #153071 (Update books) - #153092 (Remove redundant self usages) - #153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - #153091 (Migration of `LintDiagnostic` - part 4)

@Urgau

Rollup merge of #153029 - nnethercote:disallowed-pass-by-ref, r=Urgau Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`. The name `pass_by_value` is completely wrong. The lint actually checks for the use of pass by reference for types marked with `rustc_pass_by_value`. The hardest part of this was choosing the new name. The `disallowed_` part of the name closely matches the following clippy lints: - `disallowed_macros` - `disallowed_methods` - `disallowed_names` - `disallowed_script_idents` - `disallowed_types` The `pass_by_value` part of the name aligns with the following clippy lints: - `needless_pass_by_value` - `needless_pass_by_ref_mut` - `trivially_copy_pass_by_ref` - `large_types_passed_by_value` (less so) r? @Urgau

Rollup of 13 pull requests Successful merges: - rust-lang/rust#148146 (CI: use alternative disks if available) - rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations) - rust-lang/rust#153078 (Remove `QuerySystemFns`) - rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace) - rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param) - rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument) - rust-lang/rust#153071 (Update books) - rust-lang/rust#153092 (Remove redundant self usages) - rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)

rustbot assigned Urgau Feb 23, 2026

nnethercote changed the title ~~Rename pass_by_value lint as disallowed_pass_by_ref.~~ Rename rustc::pass_by_value lint as rustc::disallowed_pass_by_ref. Feb 23, 2026

Urgau reviewed Feb 24, 2026

View reviewed changes

Urgau approved these changes Feb 24, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2026

GuillaumeGomez mentioned this pull request Feb 24, 2026

Rollup of 8 pull requests #153059

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2026

nnethercote force-pushed the disallowed-pass-by-ref branch from d60e15f to 8eed8bd Compare February 25, 2026 04:10

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Feb 25, 2026

Auto merge of #153029 - nnethercote:disallowed-pass-by-ref, r=<try>

7066b8e

Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.

JonathanBrouwer mentioned this pull request Feb 25, 2026

Rollup of 10 pull requests #153084

Closed

JonathanBrouwer mentioned this pull request Feb 25, 2026

Rollup of 9 pull requests #153086

Closed

JonathanBrouwer mentioned this pull request Feb 25, 2026

Rollup of 10 pull requests #153088

Closed

JonathanBrouwer mentioned this pull request Feb 25, 2026

Rollup of 13 pull requests #153098

Closed

jhpratt mentioned this pull request Feb 26, 2026

Rollup of 13 pull requests #153116

Merged

rust-bors bot merged commit f8f4447 into rust-lang:main Feb 26, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 26, 2026

nnethercote deleted the disallowed-pass-by-ref branch February 26, 2026 08:12

Uh oh!

Conversation

nnethercote commented Feb 23, 2026

Uh oh!

rustbot commented Feb 23, 2026

Uh oh!

nnethercote commented Feb 24, 2026

Uh oh!

Urgau left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nnethercote commented Feb 24, 2026

Uh oh!

Urgau commented Feb 24, 2026

Uh oh!

Urgau commented Feb 24, 2026

Uh oh!

rust-bors bot commented Feb 24, 2026

Uh oh!

nnethercote commented Feb 24, 2026

Uh oh!

jhpratt commented Feb 25, 2026

Uh oh!

rust-bors bot commented Feb 25, 2026

Uh oh!

nnethercote commented Feb 25, 2026

Uh oh!

rust-bors bot commented Feb 25, 2026

Uh oh!

nnethercote commented Feb 25, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Urgau left a comment •

edited by rustbot

Loading