Skip to content

Comments

refactor(mgca): Change DefKind::Const and DefKind::AssocConst to have a is_type_const flag#153050

Open
JayanAXHF wants to merge 7 commits intorust-lang:mainfrom
JayanAXHF:refactor/change-is-type-const
Open

refactor(mgca): Change DefKind::Const and DefKind::AssocConst to have a is_type_const flag#153050
JayanAXHF wants to merge 7 commits intorust-lang:mainfrom
JayanAXHF:refactor/change-is-type-const

Conversation

@JayanAXHF
Copy link
Member

@JayanAXHF JayanAXHF commented Feb 24, 2026

Addresses #152940

  • Changed DefKind::Const and DefKind::AssocConst to have a is_type_const flag.
  • changed is_type_const query to check for this flag
  • removed is_rhs_type_const query

r? @BoxyUwU

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2026

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

changes to the core type system

cc @lcnr

Some changes occurred in match checking

cc @Nadrieril

HIR ty lowering was modified

cc @fmease

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 24, 2026
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Feb 24, 2026
@rust-log-analyzer

This comment has been minimized.

@JayanAXHF
Copy link
Member Author

@BoxyUwU I think this is mostly complete now

@JayanAXHF JayanAXHF removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-clippy Relevant to the Clippy team. labels Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants