Skip to content

Comments

stop marking deref_patterns as an incomplete feature#153053

Open
cyrgani wants to merge 1 commit intorust-lang:mainfrom
cyrgani:deref-patterns-not-imcomplete
Open

stop marking deref_patterns as an incomplete feature#153053
cyrgani wants to merge 1 commit intorust-lang:mainfrom
cyrgani:deref-patterns-not-imcomplete

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Feb 24, 2026

This PR removes the incomplete_feature warning for deref_patterns. The reason given for this in the tracking issue (#87121) was

Per policy, the incomplete_feature is supposed to stay on until the feature has an accepted RFC. We're slowly working on writing up that RFC so it'll take some more time unfortunately.

I don't know of any compiler crashes it causes today. The feature should be pretty usable.

However, I could not find any evidence of such a policy. The lint documentation for incomplete_features also only mentions features that are more likely to cause errors.
There are also many other features without an RFC that are not considered incomplete, e.g. macro_metavar_expr_concat, negative_impls or yeet_expr.
The feature does not cause any known ICEs either.

The concrete motivation is to use this feature to replace box_patterns in the compiler and pave the way towards removing that legacy feature.

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 24, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 13 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-cloud-vms rust-cloud-vms bot force-pushed the deref-patterns-not-imcomplete branch from 635d644 to 06b0bd2 Compare February 24, 2026 17:43
@cyrgani cyrgani removed the T-clippy Relevant to the Clippy team. label Feb 24, 2026
@jackh726
Copy link
Member

This is indeed more or less current policy. This should get an RFC before being marked as incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants