stop marking deref_patterns as an incomplete feature#153053
Open
cyrgani wants to merge 1 commit intorust-lang:mainfrom
Open
stop marking deref_patterns as an incomplete feature#153053cyrgani wants to merge 1 commit intorust-lang:mainfrom
deref_patterns as an incomplete feature#153053cyrgani wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
635d644 to
06b0bd2
Compare
Member
|
This is indeed more or less current policy. This should get an RFC before being marked as incomplete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
incomplete_featurewarning forderef_patterns. The reason given for this in the tracking issue (#87121) wasHowever, I could not find any evidence of such a policy. The lint documentation for
incomplete_featuresalso only mentions features that are more likely to cause errors.There are also many other features without an RFC that are not considered incomplete, e.g.
macro_metavar_expr_concat,negative_implsoryeet_expr.The feature does not cause any known ICEs either.
The concrete motivation is to use this feature to replace
box_patternsin the compiler and pave the way towards removing that legacy feature.