Reorganisation of UI Tests

[rishi-techo-14]

Reorganize 11 tests in tests/ui/issues to appropriate subdirectories

This PR reorganizes tests in tests/ui/issues folder following the workflow suggested in the comment on #149411

Workflow:

• Move 11 tests to appropriate directories (such as pattern, typeck, traits, borrowck, closures).
• Rename each test in {reason}-issue-xxxx.rs format along with its corresponding .stderr file
• Add issue links and short description about what the test checks

All tests pass tidy locally using

python x.py test tidy

[rustbot]

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 69 candidates
• Random selection from 15 candidates

[rishi-techo-14]

@rustbot r? @Kivooeo

[Kivooeo]

Remove the word "issue" from all test names and remove the issue numbers from those tests whose names are descriptive enough.

View changes since this review

[Kivooeo]

Also, remove the comments describing what the test is doing if the test is simple enough. However, keep an issue link and add a new line between your comment and the test.

Here's an example of what the test could look like: #152732.

[cyrgani]

This should not be moved to ui/traits, there are no traits involved at all.

[Kivooeo]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.