Skip to content

de-non_const some Iterator methods#154729

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Lars-Schumann:de-non_const-iterator
Apr 7, 2026
Merged

de-non_const some Iterator methods#154729
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Lars-Schumann:de-non_const-iterator

Conversation

@Lars-Schumann
Copy link
Copy Markdown
Contributor

@Lars-Schumann Lars-Schumann commented Apr 2, 2026

#92476

r? oli-obk

this is essentially just #153708 again (which I accidentally closed...), but with the changes to advance_by omitted, since that seems to have caused the ICE.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

@Zalathar
Copy link
Copy Markdown
Member

Zalathar commented Apr 3, 2026

@bors try jobs=x86_64-rust-for-linux

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of #154729 - Lars-Schumann:de-non_const-iterator, r=<try>
6703d5e 
de-non_const some `Iterator` methods


try-job: x86_64-rust-for-linux
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 3, 2026

☀️ Try build successful (CI)
Build commit: 6703d5e (6703d5e957add887d5bec773a34b41be229cc26b, parent: 5bbdeaa9a8dc563185f40e99f96704cbcc7a6e6e)

@Lars-Schumann
Copy link
Copy Markdown
Contributor Author

Lars-Schumann commented Apr 3, 2026

Looks like that solved the ICE.

@rust-bors

This comment has been minimized.

Sign in to view
@Lars-Schumann Lars-Schumann force-pushed the de-non_const-iterator branch from eba5951 to 4378386 Compare April 6, 2026 17:56
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

oli-obk
oli-obk reviewed Apr 6, 2026
View reviewed changes
oli-obk
oli-obk reviewed Apr 6, 2026
View reviewed changes
oli-obk
oli-obk reviewed Apr 6, 2026
View reviewed changes
oli-obk
oli-obk requested changes Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@oli-obk oli-obk left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nits

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@oli-obk
Copy link
Copy Markdown
Contributor

oli-obk commented Apr 6, 2026

@bors delegate+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 6, 2026

✌️ @Lars-Schumann, you can now approve this pull request!

If @oli-obk told you to "r=me" after making some further change, then please make that change and post @bors r=oli-obk.

@Lars-Schumann Lars-Schumann force-pushed the de-non_const-iterator branch from 4378386 to fc71bad Compare April 6, 2026 21:16
@Lars-Schumann
Copy link
Copy Markdown
Contributor Author

Lars-Schumann commented Apr 6, 2026

@bors r=oli-obk

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 6, 2026

📌 Commit fc71bad has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2026
@jhpratt jhpratt mentioned this pull request Apr 6, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 7, 2026
@bors
Auto merge of #154916 - jhpratt:rollup-RkdDmtW, r=jhpratt
49b6ac0 
Rollup of 6 pull requests

Successful merges:

 - #154627 (Move `rustc_middle::mir::mono` to `rustc_middle::mono`)
 - #154729 (de-non_const some `Iterator` methods)
 - #154891 (implement `StructuralPartialEq` for `MaybeDangling`)
 - #154894 (Slightly refactor mplace<->ptr conversions)
 - #154751 (compiletest: Remove `rfail` support from incremental tests)
 - #154901 (Update books)
@rust-bors rust-bors bot merged commit 312913e into rust-lang:main Apr 7, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 7, 2026
rust-timer added a commit that referenced this pull request Apr 7, 2026
@rust-timer
Unrolled build for #154729
e9d825f 
Rollup merge of #154729 - Lars-Schumann:de-non_const-iterator, r=oli-obk

de-non_const some `Iterator` methods

#92476

r? oli-obk

this is essentially just #153708 again (which I accidentally closed...), but with the changes to `advance_by` omitted, since that seems to have caused the ICE.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 8, 2026
@bors
Auto merge of #154916 - jhpratt:rollup-RkdDmtW, r=jhpratt
07f121f 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#154627 (Move `rustc_middle::mir::mono` to `rustc_middle::mono`)
 - rust-lang/rust#154729 (de-non_const some `Iterator` methods)
 - rust-lang/rust#154891 (implement `StructuralPartialEq` for `MaybeDangling`)
 - rust-lang/rust#154894 (Slightly refactor mplace<->ptr conversions)
 - rust-lang/rust#154751 (compiletest: Remove `rfail` support from incremental tests)
 - rust-lang/rust#154901 (Update books)
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 8, 2026
@bors
Auto merge of #154916 - jhpratt:rollup-RkdDmtW, r=jhpratt
a51f720 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#154627 (Move `rustc_middle::mir::mono` to `rustc_middle::mono`)
 - rust-lang/rust#154729 (de-non_const some `Iterator` methods)
 - rust-lang/rust#154891 (implement `StructuralPartialEq` for `MaybeDangling`)
 - rust-lang/rust#154894 (Slightly refactor mplace<->ptr conversions)
 - rust-lang/rust#154751 (compiletest: Remove `rfail` support from incremental tests)
 - rust-lang/rust#154901 (Update books)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk requested changes

+1 more reviewer

@bend-n bend-n bend-n left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Lars-Schumann @rustbot @Zalathar @oli-obk @bend-n