Make Rustc build with LLVM trunk.#55751
Closed
vext01 wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We were discussing in #55714 the possibility of having a LLVM version gated fix for the recent change to
DiBuilder::createGlobalVariableExpression.In short, an extra optional argument was added to this LLVM function, but for some reason it was not appended to the end of argument list, thus breaking backward compat.
This change uses conditional compilation to fix this.
All tests pass on yesterday's LLVM. Presumably Bors will test using an earlier LLVM before the change.
What do you think? Can we include this?
Thanks