Add Metadata in std::os::fortanix_sgx::io::FromRawFd #78953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
mzohreva
force-pushed
the
mz/from_raw_fd
branch
from
de2eae8
to
d569696
Compare
shirshak55
reviewed
Nov 11, 2020
| #[derive(Debug, Clone, Default)] | ||
| pub struct TcpStreamMetadata { | ||
| /// Local address of the TCP stream | ||
| pub local_addr: Option<String>, |
There was a problem hiding this comment.
shouldn't it be SocketAddr instead of String?
There was a problem hiding this comment.
jethrogb
reviewed
Nov 12, 2020
| #[derive(Debug, Clone, Default)] | ||
| pub struct TcpStreamMetadata { | ||
| /// Local address of the TCP stream | ||
| pub local_addr: Option<String>, |
There was a problem hiding this comment.
| @@ -71,18 +74,38 @@ impl AsRawFd for net::TcpListener { | |||
| } | |||
| } | |||
|
|
|||
| /// Metadata for `TcpStream`. | |||
| #[derive(Debug, Clone, Default)] | |||
| pub struct TcpStreamMetadata { | |||
There was a problem hiding this comment.
Missing stability attribute
| } | ||
| } | ||
|
|
||
| /// Metadata for `TcpListener`. | ||
| #[derive(Debug, Clone, Default)] | ||
| pub struct TcpListenerMetadata { |
There was a problem hiding this comment.
Missing stability attribute
|
@bors r+ -- normally we would check with libs for unstable additions, but this is SGX only so I'm just going to accept it. |
|
📌 Commit 084b0da has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 24, 2020
…ulacrum Add Metadata in std::os::fortanix_sgx::io::FromRawFd Needed for fortanix/rust-sgx#291 cc `@jethrogb`
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for fortanix/rust-sgx#291
cc @jethrogb