-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metadata in std::os::fortanix_sgx::io::FromRawFd #78953
Conversation
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
de2eae8
to
d569696
Compare
#[derive(Debug, Clone, Default)] | ||
pub struct TcpStreamMetadata { | ||
/// Local address of the TCP stream | ||
pub local_addr: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be SocketAddr instead of String?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[derive(Debug, Clone, Default)] | ||
pub struct TcpStreamMetadata { | ||
/// Local address of the TCP stream | ||
pub local_addr: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -71,18 +74,38 @@ impl AsRawFd for net::TcpListener { | |||
} | |||
} | |||
|
|||
/// Metadata for `TcpStream`. | |||
#[derive(Debug, Clone, Default)] | |||
pub struct TcpStreamMetadata { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing stability attribute
} | ||
} | ||
|
||
/// Metadata for `TcpListener`. | ||
#[derive(Debug, Clone, Default)] | ||
pub struct TcpListenerMetadata { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing stability attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bors r+ -- normally we would check with libs for unstable additions, but this is SGX only so I'm just going to accept it. |
📌 Commit 084b0da has been approved by |
…ulacrum Add Metadata in std::os::fortanix_sgx::io::FromRawFd Needed for fortanix/rust-sgx#291 cc `@jethrogb`
☀️ Test successful - checks-actions |
Needed for fortanix/rust-sgx#291
cc @jethrogb