set the executable bit on pre-commit.sh#87942
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 12, 2021
Merged
Conversation
`x.py setup` hardlinks this file into .git/hooks. Prior to this commit,
that led to the following warning emitted by `git commit`:
hint: The '.git/hooks/pre-commit' hook was ignored because it's not set as executable.
Making the checked-in script executable fixes this issue, as the
hardlinked copy uses the same flags.
It looks like the file was originally executable, but that bit was
unset in commit b908905 of
rust-lang#85305. It's possible that was
unintentional.
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ rollup Good catch, thank you! |
Collaborator
|
📌 Commit a0103e5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#85835 (Implement Extend<(A, B)> for (Extend<A>, Extend<B>)) - rust-lang#87671 (Warn when an escaped newline skips multiple lines) - rust-lang#87878 (:arrow_up: rust-analyzer) - rust-lang#87903 (Reduce verbosity of tracing output of RUSTC_LOG) - rust-lang#87925 (Update books) - rust-lang#87928 (Update cargo) - rust-lang#87942 (set the executable bit on pre-commit.sh) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x.py setuphardlinks this file into .git/hooks. Prior to this commit,that led to the following warning emitted by
git commit:Making the checked-in script executable fixes this issue, as the
hardlinked copy uses the same flags.
It looks like the file was originally executable, but that bit was
unset in commit b908905 of
#85305. It's possible that was
unintentional.