[DO NOT MERGE] Forbid `unused_lifetimes` lint for Crater run by Aaron1011 · Pull Request #92413 · rust-lang/rust

Aaron1011 · 2021-12-29T19:33:16Z

No description provided.

rust-highfive · 2021-12-29T19:33:19Z

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

Aaron1011 · 2021-12-29T19:33:25Z

@bors try

bors · 2021-12-29T19:33:32Z

⌛ Trying commit 240476a9a2089ebfcd39f752ddb6dfb485078c40 with merge df6b2a614694815ea299bbd35da94f863e9820f5...

bors · 2021-12-29T20:46:43Z

💔 Test failed - checks-actions

Aaron1011 · 2021-12-29T23:17:20Z

@bors try

bors · 2021-12-29T23:17:31Z

⌛ Trying commit 38ae19bc1731cd15c3fa3e6c9c1a4ad722a049bb with merge 80898e5127067c96aa73ad33f7ff29460aa0ded2...

bors · 2021-12-30T00:43:44Z

💔 Test failed - checks-actions

Aaron1011 · 2021-12-30T03:08:08Z

@bors try

bors · 2021-12-30T03:08:16Z

⌛ Trying commit 80bef08c8262abb75a4e4a05833d75bfe87d23bc with merge 1ecd5593dc72952fc2259078e12bfca1c351902b...

bors · 2021-12-30T04:34:20Z

💔 Test failed - checks-actions

This is blocking the Crater run in rust-lang/rust#92413, since a 'try' build needs to build Cargo.

Remove unused lifetimes This is blocking the Crater run in rust-lang/rust#92413, since a 'try' build needs to build Cargo.

joshtriplett · 2022-01-04T18:23:17Z

@Aaron1011 Cargo has been fixed now to no longer trigger unused_lifetimes, so we should give this another shot.

Aaron1011 · 2022-01-04T18:35:46Z

@bors try

craterbot · 2022-01-06T15:28:38Z

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-06T16:17:10Z

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-07T04:39:19Z

🚨 Experiment pr-92413 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Mark-Simulacrum · 2022-01-07T12:52:09Z

@craterbot retry

craterbot · 2022-01-07T12:52:11Z

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-07T12:52:14Z

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-07T12:57:15Z

🚨 Experiment pr-92413 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Mark-Simulacrum · 2022-01-08T04:04:56Z

@craterbot retry

cc rust-lang/crater#590

craterbot · 2022-01-08T04:04:58Z

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-08T04:08:36Z

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-08T19:11:11Z

🚨 Experiment pr-92413 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-08T19:39:52Z

🚨 Experiment pr-92413 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-08T20:28:14Z

🚨 Experiment pr-92413 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Mark-Simulacrum · 2022-01-08T20:34:16Z

@craterbot retry

Underlying failure should be addressed by rust-lang/crater#596, but it's an intermittent failure.

craterbot · 2022-01-08T20:34:17Z

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-01-08T20:50:39Z

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Retry timeout rust-lang/rust#92413 (comment) failed due to a request timeout, plausibly because of a parallel request (e.g., metrics) which locked out the database for long enough to cause a failure. This changes our retry logic to hopefully always retry timed out requests. (It does not take the step we took with docker builds of unilaterally retrying *all* requests, but that may be a better path rather than trying to guess... for now this seems a more limited answer).

craterbot · 2022-01-11T02:50:19Z

🎉 Experiment pr-92413 is completed!
📊 3666 regressed and 7 fixed (204570 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

apiraino · 2022-02-24T10:59:00Z

@Aaron1011 I've tried getting the context for this PR, is waiting for a review the actual status? thanks :)

JohnCSimon · 2022-11-27T01:48:02Z

@Aaron1011
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

rust-highfive assigned davidtwco Dec 29, 2021

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 29, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2021

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2021

This comment has been minimized.

Sign in to view

Aaron1011 force-pushed the crater-unused-lifetimes branch from 240476a to 38ae19b Compare December 29, 2021 22:28

This comment has been minimized.

Sign in to view

Aaron1011 force-pushed the crater-unused-lifetimes branch from 38ae19b to 80bef08 Compare December 30, 2021 03:07

This comment has been minimized.

Sign in to view

Aaron1011 added a commit to Aaron1011/cargo that referenced this pull request Dec 30, 2021

Remove unused lifetimes

c8761d4

This is blocking the Crater run in rust-lang/rust#92413, since a 'try' build needs to build Cargo.

Aaron1011 mentioned this pull request Dec 30, 2021

Remove unused lifetimes rust-lang/cargo#10238

Merged

bors added a commit to rust-lang/cargo that referenced this pull request Dec 30, 2021

Auto merge of #10238 - Aaron1011:remove-lifetimes, r=joshtriplett

9af67cf

Remove unused lifetimes This is blocking the Crater run in rust-lang/rust#92413, since a 'try' build needs to build Cargo.

Aaron1011 force-pushed the crater-unused-lifetimes branch from 80bef08 to 7fd7637 Compare January 4, 2022 18:35

Mark-Simulacrum mentioned this pull request Jan 8, 2022

Retry timeout rust-lang/crater#596

Merged

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 11, 2022

Aaron1011 mentioned this pull request Jan 14, 2022

Make unused_lifetimes lint warn-by-default #92386

Closed

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2022

jackh726 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2022

JohnCSimon closed this Nov 27, 2022

rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Nov 27, 2022

Uh oh!

Comments

Conversation

Aaron1011 commented Dec 29, 2021

Uh oh!

rust-highfive commented Dec 29, 2021

Uh oh!

Aaron1011 commented Dec 29, 2021

Uh oh!

bors commented Dec 29, 2021

Uh oh!

bors commented Dec 29, 2021

Uh oh!

This comment has been minimized.

Aaron1011 commented Dec 29, 2021

Uh oh!

bors commented Dec 29, 2021

Uh oh!

This comment has been minimized.

bors commented Dec 30, 2021

Uh oh!

Aaron1011 commented Dec 30, 2021

Uh oh!

bors commented Dec 30, 2021

Uh oh!

This comment has been minimized.

bors commented Dec 30, 2021

Uh oh!

joshtriplett commented Jan 4, 2022

Uh oh!

Aaron1011 commented Jan 4, 2022

Uh oh!

craterbot commented Jan 6, 2022

Uh oh!

craterbot commented Jan 6, 2022

Uh oh!

craterbot commented Jan 7, 2022

Uh oh!

Mark-Simulacrum commented Jan 7, 2022

Uh oh!

craterbot commented Jan 7, 2022

Uh oh!

craterbot commented Jan 7, 2022

Uh oh!

craterbot commented Jan 7, 2022

Uh oh!

Mark-Simulacrum commented Jan 8, 2022

Uh oh!

craterbot commented Jan 8, 2022

Uh oh!

craterbot commented Jan 8, 2022

Uh oh!

craterbot commented Jan 8, 2022

Uh oh!

craterbot commented Jan 8, 2022

Uh oh!

craterbot commented Jan 8, 2022

Uh oh!

Mark-Simulacrum commented Jan 8, 2022

Uh oh!

craterbot commented Jan 8, 2022

Uh oh!

craterbot commented Jan 8, 2022

Uh oh!

craterbot commented Jan 11, 2022

Uh oh!

apiraino commented Feb 24, 2022

Uh oh!

JohnCSimon commented Nov 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants