Conversation
Contributor
|
Small binary size regression in 146666 in crate_metadata/linked_artifact |
Member
Author
|
Thanks, I missed that one. I don't think that there's much to do though, the regression is small and I doubt we'd want to revert any PR based on that. |
Contributor
|
Yes, revert is too heavy tool, but in case pr is known, author can probably fix it, if it not difficult. |
panstromek
reviewed
Sep 23, 2025
panstromek
approved these changes
Sep 23, 2025
Contributor
panstromek
left a comment
panstromek
left a comment
There was a problem hiding this comment.
Looks ok, I can't check the grammar, though
nnethercote
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered