Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove trailing whitespace from multi-line tuple struct field prefix #5708

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

remove trailing whitespace from multi-line tuple struct field prefix #5708

wants to merge 3 commits into from

Commits on Dec 29, 2023

  1. remove trailing whitespace from multi-line tuple struct field prefix 

    Fixes 5703, Fixes 5525

visibility modifiers always contain a trailing space after them. If the
formatted tuple field needs to be written over multiple lines then the
extra space will cause issues.

In the best case the space will offset the type name by an extra space
and in the worst case it will lead to a "left behind trailing
whitespace" error.
    @ytmimi
    ytmimi committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    97c9aef View commit details
    Browse the repository at this point in the history

  2. Prevent format_visibility from adding trailing space with Version::Two

    @ytmimi
    ytmimi committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    09dbeda View commit details
    Browse the repository at this point in the history

  3. Add test case for issue 5997

    @ytmimi
    ytmimi committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    7894f70 View commit details
    Browse the repository at this point in the history