docs: pin a version of markedjs from cdnjs#6194
Merged
calebcartwright merged 1 commit intorust-lang:masterfrom Jun 16, 2024
jbr:fix-docs-markedjs
Merged
docs: pin a version of markedjs from cdnjs#6194calebcartwright merged 1 commit intorust-lang:masterfrom jbr:fix-docs-markedjs
calebcartwright merged 1 commit intorust-lang:masterfrom
jbr:fix-docs-markedjs
Conversation
|
@ytmimi thanks for the quick response, just confirming these changes do in fact resolve the problem for me (tested on Firefox 127.0 and Safari 17.5). Seems like this change would help prevent future similar breakages from upstream too! 👍 |
calebcartwright
approved these changes
Jun 16, 2024
Member
calebcartwright
left a comment
There was a problem hiding this comment.
Thanks for the changes and detailed explanations!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! It seems like the docs site is currently broken. Previous to this commit, the cdn markedjs url was not versioned, so when markedjs v13 introduced breaking changes on 2024-06-12, the rustfmt docs site automatically pulled them in.
In addition to fixing that problem by pinning to v12, this PR:
integrityhash so the browser can check that the retrieved executable content is in fact as-expected.However, this PR does not change the versions of any dependencies, many of which are significantly out of date.
Thanks!