return RewriteResult for rewrite_path & rewrite_struct_***#6236
return RewriteResult for rewrite_path & rewrite_struct_***#6236ytmimi merged 2 commits intorust-lang:masterfrom
Conversation
|
Thanks for another PR. This one is next on my todo list |
ytmimi
left a comment
There was a problem hiding this comment.
I think we're good to go on this one. We just need to address the merge conflict
- refactor rewrite_*** functions that call rewrite_path to return RewriteResult - modify rewrite_aligned_item method of AlignedItem
67d69e0 to
fe9b50a
Compare
|
Running the Diff-Check Job now Edit: The job passed ✅ |
|
Just noting that this broader change (not specifically this PR, but the overall mission of #6206, has a higher chance of causing merge conflicts on the subtree syncs so if possible it would be good to try to get some more frequent syncs through |
|
@calebcartwright Thanks for pointing that out. I'll try to follow your advice :) |
nothing for you to worry about @ding-young, it was mostly a note to myself & Yacin to try to get these in more frequently |
|
@calebcartwright good call out. I don't think there's been many changes in |
Tracked by #6206
Description
Modify following functions to return
RewriteResultImpl rewrite_result for
PreciseCapturingArg,AssocItemConstraint,PolyTraitRef,TraitRefin types.rs(These are the nodes that were waiting for certain rewrite_*** to return RewriteResult. see #6220)
Side notes
Option<String>since it is used for the possible range of width for struct prefix (see struct_field_prefix_max_min_width)unknown_error()calls since I haven't modifiedwrite_list,itemize_list, and similar functions. There's ongoing concern about modifying these functions and the iterator implementation forListItems.