Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - show file path in error message when parsing config from toml #6323

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Sep 12, 2024

Fixes #6302

Display the path to the toml config file that rustfmt failed to parse configurations from.

fixes 6302

Display the path to the toml config file that rustfmt failed to parse
configurations from.
@ytmimi
Copy link
Contributor Author

ytmimi commented Sep 12, 2024

@rufevean opening up this PR instead of #6310. Not sure what the issue was but this contains all your work boiled down into a single commit. Thanks for you help!

@ytmimi ytmimi added pr-ready-to-merge release-notes Needs an associated changelog entry and removed pr-not-reviewed labels Sep 12, 2024
@rufevean
Copy link
Contributor

rufevean commented Sep 12, 2024

@rufevean opening up this PR instead of #6310. Not sure what the issue was but this contains all your work boiled down into a single commit. Thanks for you help!

thats awesome, thanks a lot for your guidance. also just curious, will i be one of the contributors now? or should i have to do more ?

@ytmimi
Copy link
Contributor Author

ytmimi commented Sep 12, 2024

@rufevean I think we're all set! Just rerunning the failed integration job right now, but assuming that it passes I'll get this merged

@rufevean
Copy link
Contributor

Awesome,thank you

@ytmimi ytmimi merged commit 14d5165 into rust-lang:master Sep 12, 2024
26 checks passed
@ytmimi ytmimi deleted the issue_6302 branch September 12, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes Needs an associated changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message
3 participants